Commit Graph

52 Commits

Author SHA1 Message Date
Alexandre Alves 2786ad7612
add missing alt to image elements (#13383) 2025-02-13 11:44:10 +00:00
Phillip Rak 0568efe051 Fix Container Shell unit tests
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-12-02 15:53:11 -07:00
Phillip Rak 0832160a54 Update ContainerShell error messages
This updates the error messages printed to provide clarity by adding:

1. a timestamp and log level to the messages
2. human-readable explanation when `/bin/sh` is missing from a container

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-12-02 14:54:06 -07:00
Phillip Rak 3099018762 Use `writeln` instead of `write`
This uses `writeln` instead of `write` so that logs can default to printing in the terminal on multiple lines.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-12-02 14:54:06 -07:00
Jordon Leach 8e18f2e18c
ContainerShell window manager fixes (#11973)
* Remove border when terminal window is focused

Remove deep selector from non-scoped style

Migrate vue-resize library to vue3-resize

* Fix codeMirrorRef instance name

* Missing semicolon
2024-09-20 08:42:32 -04:00
Cody Jackson 5052c2a8e8 Enabling `vue/require-explicit-emits` linting rule
https://github.com/rancher/dashboard/issues/11961
2024-09-19 09:58:53 -07:00
Mo Mesgin 682a09cae5 replace trigger with triggers 2024-09-11 10:56:45 -07:00
Mo Mesgin 296f1a4cc5 replace old names/props from v-tooltip with new ones from floating-vue 2024-09-10 14:48:52 -07:00
Nancy 85c5c28c22
Vue3 fix unit tests (#11776)
* remove $set from AKS validators

* fix cruGKE not rendering

* fix most aks unit tests

* fix crueks and eks config unit tests

* fix eks networking and nodegroup unit tests

* fix gke unit tests

* fix consumption gauge test

* fix namespacefilter tests

* fix command and taints unit tests

* fix questions unit tests

* fix hpa and service unit tests

* fix registryconfigs unit tests

* fix job unit tests

* fix longhorn unit tests

* fix addextensionsrepos unit tests

* fix rke2 basics unit tests

* fix container shell unit tests

* fix last aks pool test

* fix mount tests

* fix namespace and pv unit tests

* fix codemirror unit tests

* clean up aks, boolean, namespacefilter unit tests

* fix namespacefilter test

* remove redundant test case
2024-09-10 08:07:21 -07:00
Mo Mesgin 6c6eec8e47 Merge branch 'master' of github.com:rancher/dashboard into 11684-popover-fix 2024-09-03 12:02:58 -07:00
Phillip Rak 1846eb8d32 Update virtual scroll behavior
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-08-30 10:24:58 -07:00
Alexandre Alves 60026587c3 fixing tooltips and metions of tooltips and dropdowns wherever I could find them 2024-08-30 15:49:34 +01:00
Phillip Rak b68adb3833 Revert "Refactoring the plain element <input> data bindings"
This reverts commit 7f1536d9cf.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-08-27 15:39:02 -07:00
Cody Jackson 8d59cd5914 Skipping all failing unit tests for the Vue3 merge. 2024-08-22 21:12:40 -07:00
Phillip Rak a71857ce7d Unit test updates - partially fixed
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-08-22 16:09:56 -07:00
Cody Jackson e22f306431 Changed how we styled ContainerShell
I couldn't get scoped to work with slotted and deep pseudo selectors. More investigation would be needed
2024-08-22 16:09:55 -07:00
Phillip Rak 7874da578f Fix slot syntax
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-08-22 16:09:54 -07:00
cnotv 78d70353c5 Unit test: Migrate unit tests with the script 2024-08-22 16:07:03 -07:00
Phillip Rak 399696ae73 Upgrade `v-tooltip` to `floating-vue`
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-08-22 16:05:37 -07:00
Cody Jackson 9b829c55ea Ran `yarn lint --fix` 2024-08-22 16:05:36 -07:00
Cody Jackson d5ce4fff2e Run the vue3 migration script
Commands run:

➤ yarn migrate
➤ git clean -fdx
➤ nvm use 20
➤ yarn
2024-08-22 16:05:36 -07:00
Cody Jackson 7f1536d9cf Refactoring the plain element <input> data bindings
Performing this change so the vue3 migration script can modify all @input, @v-model of components without changing plain elements. This will reduce the number of vue3 compiler errors.
2024-08-22 16:04:52 -07:00
Alexandre Alves 0b1a331c3a
recreate pr 9831 + fix e2e tests (#10245)
Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
2024-01-10 17:09:53 +00:00
LiuYan c9bb8a19f0
fix(ContainerLogs): fix display error if log is truncated (#10197)
* fix(ContainerLogs): fix display error if log is truncated

* test(ContainerLogs): adding test cases for truncated log processing

* add test for empty string

---------

Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
2024-01-02 17:37:29 +00:00
Neil MacDougall 29d8f34ba5
Fix for Monitoring Helm chart sometimes adds empty selector (#10085)
* Fix for Monitoring Helm chart sometimes adds empty selector

* Correct close icon styling

* Tweak close icon width

* Fix lint issues
2023-12-14 13:23:25 +00:00
Alexandre Alves 6637583874
remove "process." mentions from Dashboard and adjust code (#10119)
* remove process.client and process.server mentions and adjust code

* fix a couple of missing conditions for process.server

* remove commented line

* remove process.static

* fix lint errors

* uncomment code

---------

Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
2023-12-13 08:41:26 +00:00
Neil MacDougall fdb061bfbb
Fix bug with container log formatting (#9967)
* Fix bug with container log formatting

* Fix lint issue
2023-11-03 09:05:32 +00:00
Sean-McQ 5c2f28b4dc
this was a older line that got relocated up into the getSocketUrl method (#9462)
* this was a older line that got relocated up into the getSocketUrl method

* Fixes compiler warnings
2023-08-02 11:04:18 -04:00
Alexandre Alves 9462c5a817
fix issue with height on containerShell (#9448)
* fix issue with height on containerShell

* fix issue properly

---------

Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
2023-07-31 11:46:19 +01:00
Neil MacDougall 02e6e84f41
When execing into a container, try linux and windows commands when we can't determine if the node is windows (#9241)
* When execing into a container, try linux and windows commands when we can't determine if the node is windows

* Fix lint

* Lint: Remove trailing white space

* Use error message rather than last error

* extra failover, caching last working os against pod, errors, tests

* add __mocks__ folders to eslint ignore patterns

* standard user test fix

* removed unnecessary try/catch logic

* Revert "removed unnecessary try/catch logic"

This reverts commit c263131927.

---------

Co-authored-by: Sean <sean.mchugh@suse.com>
2023-07-28 21:28:03 -04:00
Giuseppe Leo 01eeb0548f
Add recommended lint rules globally (#8997)
* Update configuration

* Create default config for eslint

* Restore plugin:vue/recommended

* Add exceptions and overrides

* Correct manually remaining issues

* Adding further picked exceptions groupped up

* Fix or disable specific cases manually and singularly

* Add naming linting exception

* Remove unused variable in component

* Move rules to default

* Autocorrect rancher/components linting issues

* Configure VSCode to use multiple files, to display linting for rancher components

* Disable jest lint hook restriction for string list component

* Autofix
2023-06-23 17:02:55 +02:00
Shavindra c1e3897792
Remove empty selector from prometheus. (#8889)
* Remove empty prometheus selector values from API request.
* Add E2E for Prometheus selector.
2023-06-01 20:13:33 +02:00
codyrancher 8147edf9df Add the ability to execute a container shell command immediately after the shell connects. 2023-05-25 21:52:29 +03:00
Bastian Hofmann d6bbae46a6
Fix multi select styling (#7843)
* Fix multi select styling so that the form field expands if not all items fit into a single line anymore.

Fixes https://github.com/rancher/dashboard/issues/7842

Signed-off-by: Bastian Hofmann <mail@bastianhofmann.de>

* Remove duplication in _select.scss

* Fix select heights in ContainerLogs, ContainerShell, ApplicationLogs and ApplicationShell components

Signed-off-by: Bastian Hofmann <mail@bastianhofmann.de>

Signed-off-by: Bastian Hofmann <mail@bastianhofmann.de>
2023-01-12 23:01:07 +00:00
Nancy Butler d4a9bef75c move stuff again 2023-01-09 10:48:42 -07:00
Nancy Butler 53774ce38c move harvester-mgr stuff 2023-01-09 10:48:42 -07:00
Francesco Torchia d2de096f14
xterm, align theme properties to version 5.x
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-01-03 17:12:42 +01:00
Francesco Torchia ae27f57eeb
Terminal, restrict drag&drop to tabs bar
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2022-12-16 17:10:27 +01:00
Francesco Torchia 9a093baa6c
Merge pull request #7666 from torchiaf/fix/7148
fix terminal crash
2022-12-14 11:10:49 +01:00
Francesco Torchia 53f9282841
Window Manager, fix bottom actions layout
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2022-12-09 16:24:58 +01:00
Francesco Torchia 4b12313b0d
fix terminal crash
- Bump version, xterm.js
- adapt new version to the Dashboard

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2022-12-09 11:48:59 +01:00
Nancy 215d2466ed
Improve performance of pod logs (#7511)
* use a virtual list to render fewer log lines; restrict total number of lines kept when user has selected a 'show the last n lines' opt
2022-12-02 15:27:59 -07:00
Francesco Torchia 6125371a43
Configure Shell/Terminal location
- add ability to pin the WindowManager component to Left/Right/Bottom
- add new component DraggableZone
- update yarn.lock, rancher/icons#v2.0.6
- adapt to light/dark theme

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2022-11-18 15:18:48 +01:00
Catherine Luse 52bcdfe88c
Merge pull request #7351 from catherineluse/logs-container
Minor log styling fix
2022-11-17 16:03:16 -07:00
Phillip Rak 3d410d0974 Apply linter auto-fixes
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2022-11-16 18:38:20 -07:00
Giuseppe Leo d2d4122bc0
Review HTML formatting rules (#6805)
* Prevent ESLint to format generated paths

* Add HTML ESLint Rules

* Format all the Vue HTML templates except Harvester

* Exclude Harvester package from linting HTML, keeping old formatting rules
2022-11-11 17:04:22 +01:00
Catherine Luse 7df7fbf199 Minor log styling fix 2022-11-11 08:20:04 -07:00
Richard Cox 43d338fac2
Harvester Plugin (#6729)
* routing maybe

* remove nested edit views

* harvester custom routes

* fix loading imported dev cluster

* move harvester-manager hci.cluster type out of harvester pkg

* fixes for build-pkg

* fix harvester custom dialogs

* fix harvester pkg routing

* generateDynamicTypeImport hyphenated dirs

rename cloud_credential and machine_config back to cloud-credential and machine-config

* Appease linting

* Fix epinio pkg build
- Includes fixes for some dashboard component references

* Revert "Receiver credential secrets are deleted when secret is set to none"

This reverts commit 836460e2998959bcda0b14a9f6511f248980b7b5.

* Fix plugin modal cancel button in dark mode

* Ensure correct components loaded when a new version of a plugin is loaded
- The route matcher was never updated with new route-->component values
- This was due to `this.router.options.routes` not containing the result of `router.add`
- See https://github.com/vuejs/vue-router/issues/2280

* Revert "Revert "Receiver credential secrets are deleted when secret is set to none""

This reverts commit e524bb3d40ea7adfe35c38ec7870560625965d25.

* fix harvester manager->harvester routing

* rename dialogs

* move harvester-manager files out of harvester pkg

* Revert "remove nested edit views"

This reverts commit e835835943d63e74c50942884fec3706f8703047.

* plugin validators dynamic import - not working

* fix merge conflict

* fix harvester members

* fix conflict

* custom validators

* harvester table formatters

* members routing

* import path fixes

* harvester mutli load

* Port across tweaks made during dynamic plugin work
- harvester plugin can be bundled with the dashboard until dynamic work has been completed
- Nav directly to virt cluster dashboard instead of via /harvester-c-cluster
- Fix missing bottom border on virt cluster list, hide actions (as they're never populated)

* move config/settings and config/harvester-map

fix hci setting custom components

* fix harvester setting import path

* Move over SerialConsole and Novnc, remove harvester.notifications
- These components were so 1-1 with harvester in the end i moved them over
- Also removed the like-for-like generic.notification `harvester.notification` strings

* Remove isSingleVirtualCluster, most of isMultiVirtualCluster

* Fix two nav issues
- harv cluster members --> prefs --> click on-screen back
- dashboard --> prefs --> click on-screen back

Both of these would be better fixed by an incoming change to the default layout (don't show old content before switching page)

* Fix reload of project/namespace page

* Split out project namespace into it's own component (1 or 2)

* Split out project namespace into it's own component (2 or 2)

* use product hideSystemResources opt instead of isVirtual/product===virtual

* fix missing prop in header

* Move FilterLabel and CloudInitType to harv pkg + two other references

* Move Harvester Upgrade components to harv pkg
- Needs a review with Neil regarding generics

* rebase build+load not working

* fix harvester route in authenticated

* Experimental Changes

* Fix merge conflicts

* WIP Fix routing
- includes project/namespace and namespace pages

* Tidying up

* Move harvester core store to plugin, remove harvester code from authenticated flow
- harvester store is a steve store that now lives in the plugin
- harvester `loadVirtual` replaced with a shortened `loadCluster` in it's own store
- Also fix xterm css import

* Fix three routing related bugs
- Fix project/namespace create/edit/cancel/done flows
- Update harvester's loadCluster to better match loadCluster
- Make edit namespace page project resource agnostic

* Build fixes

* Fix create namespace button and other tweaks

* fix two issues with nav out of imported harvester cluster

* Fix alignment of action menu button
- Used in many places
  - all generic table action menus
  - global settings --> settings
  - rke1 cluster detail page machine pool group actions
  - project/namespace list project group actions
  - resource detail page action menu

* Revert changes to app and pkg creators
- This should fix `check-plugins-build` gate
- It does hide the underlying issue, but that won't have been brought in by this PR?

Co-authored-by: Nancy Butler <42977925+mantis-toboggan-md@users.noreply.github.com>
2022-09-01 08:57:05 -07:00
Richard Cox 7307a87b65 Address to container log streaming inssues
- No.1
  - validate and fix bad LOGS_RANGE preferences
  - at some point this became polluted and now breaks streaming of logs
  - fixes https://github.com/rancher/dashboard/issues/6122
- No.2
  - Ensure the `Everything` log range option is correctly selected when the value is `all`
  - Previously it would just show as an option underneath 'Everything`
2022-06-10 18:13:43 +01:00
Phillip Rak 72b36cb360
Create Rancher Component Library (#5504)
This adds a new project for Rancher Components under `pkg/rancher-components` and replaces components used throughout dashboard with the versions used here. All imports for the following components have been updated:

```
  |- BadgeState.vue
  |- Banner.vue
  |- Card.vue
  |- Form
    |- Checkbox.vue
    |- LabeledInput.vue
    |- LabeledTooltip.vue
    |- RadioButton.vue
    |- RadioGroup.vue
    |- TextAreaAutoGrow.vue
```
2022-05-24 15:09:53 -07:00