* working on key nav for cluster badge appearance
* color input is now key nav friendly + tooltip works on focus + trying to get focus trap to work properly
* remove console logs + add focus trap to card component with prop control + fix element for config badge button
* fix lint problem
* fix TS errors on pkg build
* remove step of building the skeleton app in the check-plugins-build step, which imo doesnt serve any purpose whatsoever
* add focus-trap as a shell dependency + revert publish script change
* remove focus-trap directive + improve chaining event handler modifiers
* pin focus-trap to 7.6.2 + replace link for button on cluster explorer main page + remove unused ev
* address pr comments
* add codemirror error reporting
wire in codemirror validation to rke2 addon config
update addon config validation status when list of available addons changes
* added e2e test for addon config validation;
* account for codemirror being used with no options
* cluster list now uses resource table
* New PaginatedResourceTable
* WIP
* add context to pag setting
* tidying up
* Add server-side pagination to cluster explorer events and general events list
* Servier-side pagination for catalog apps, cluster repo and operation
* Servier-side pagination for Service --> HPA, inmgress, services
* Server-side pagination for home page clusters list and side bar clusters
- Functional Changes
- SSP now works after vue3 bump
- Home Page Clusters list now uses server-side pagination
- Side Bar clusters list now uses server-side pagination
- Wire in now supported sorting / filtering by id and name used for table columns
- Allow pagination to be enabled given a specific context
- Call findPage without persisting to store
- New Pagination Tools
- PaginatedResourceTable - Convenience Component, wraps ResourceTable with pagination specific props
- PaginationWrapper - Convenience class to handle requests for resources and updates to them (avoiding store)
- Regressions
- Side Nav menu ready state was `mgmtCluster.isReady && !pCluster?.hasError`, now ???
* fixes after merge. apply PagResTable to node list, vue3 fixes
* - Fix issue where list components containing PaginatedResourceTables would incorrectly fetch all resources anyway
- convert reminaing storage lists
* policy section
* fix async button in manual refresh mode
* fgh
* aaaaa
* Server-side pagination for home page clusters list and side bar clusters
- Functional Changes
- SSP now works after vue3 bump
- Home Page Clusters list now uses server-side pagination
- Side Bar clusters list now uses server-side pagination
- Wire in now supported sorting / filtering by id and name used for table columns
- Allow pagination to be enabled given a specific context
- Call findPage without persisting to store
- New Pagination Tools
- PaginatedResourceTable - Convenience Component, wraps ResourceTable with pagination specific props
- PaginationWrapper - Convenience class to handle requests for resources and updates to them (avoiding store)
- Regressions
- Side Nav menu ready state was `mgmtCluster.isReady && !pCluster?.hasError`, now ???
* Iteration
Note - prov clusters is broken (only fetches local) due to blocking pr. breals
- notPinned list
* Fix dupe inStore
- remove from resource list, put in resource-fetch (used also by pag res table)
* Fix dupe inStore
- remove from resource list, put in resource-fetch (used also by pag res table)
* Two fixes
- changes namespaces kicked of side nav cluster requests (thought pinnedIds changed)
- fix generic lists re-fetching given ns filter changes (they don't have namespaced arg)
* fixes / updates
* testing/tidying
* WIP - Rest of workload lists
* finish off workloads
* tidying up
* fix non-generic list filtering by namespace
* remove comment, backport fix
* test fixes
* E2E: Ensure we wait for cluster entries to exist before clicking on them
* backport fix for local/api filtering
* Remove debug code
* Changes after review
* e2e fixes / debugging
* More e2e fixes
* More e2e fixes
* More e2e fixes
* Fix generic pages that filter on pagination
* Attempt to fix flaky vai test
* Fix after merge from master
* Updates following new indexed files
* Fix lint and test
* Changes given real cluster tests
- general fixes
- correct issue were sorting prov clusters on mgmt cluster props (issue in master as well...)
- bit the bullet, we now don't fetch all mgmt clusters on dashboard visit.
- there could be knock on affects, but we'd need to remove it sometime in 2.11....
* Fix issues with diplaying rke1 data in home page
- includes https://github.com/rancher/dashboard/pull/12881
* Fix unit tests
* remove invalid sort/filter type
* Running through new indexed fields
* fix unit tests
* lint fixes
* Fixes after small review
* lint
* Test for check-plugin-gates pkg build from shell
* e2e fixes
* Testing new indexed fields with dev image
* tidyuing up imports in hope to fix ts error in check-plugins gate
* Fix failing check-plugin-gates
- caused by shell/scripts/test-plugins-build.sh importing list/catalog.cattle.io.clusterrepo.vue
- the component had been updated to a TS component
- check-plugin build outputs TS errors for a component file imports
- vs code shows no errors for imported file
* tidying up a smidge
* Many tweaks
- Remove final todo's
- includes fix for service type clusterip/headless overlap
- Removed ununused ENDPOINT column (note ENDPOINT formatter used in other columns)
- Testing freshly added index fields
* Improve location of new place where componentWillFetch is set
* fix lint, comment updated
* Fix failing e2e tests
- fix cluster dashboard events test
- fix and greatly improve flaky events test
- fix hpa test
- functional fixes
- fix sorting/filtering events by object type
- fix hpa columns
* fix keyboard nav for home page
* minor fixes based on another PR comment
* add aria-sort to table column headers + remove space key bindings for links
* revert small change on Checkbox
* revert small change on Checkbox
* clear key space to trigger links
* change role for links that are in fact buttons + keep space key
* fix keyboard nav for app bar
* remove dones
* minor fixes based on another PR comment
* removed all space key for links + move floating-vue config to plugin definition
* rename tabbing-index to tab-order + add aria-label to main menu
* fix keyboard nav on login screen
* adjust for dark mode
* remove border radius from focus styles + dont open locale selector on focus
* add missing aria label
* minor fixes based on another PR comment
* remove tabbingindex from components + fix checkbox component disabled state
* remove tabbingindex from checkbox
* remove tabbingindex from LocaleSelector
* address pr comments
- Remove final todo's
- includes fix for service type clusterip/headless overlap
- Removed ununused ENDPOINT column (note ENDPOINT formatter used in other columns)
- Testing freshly added index fields
- Reduce the flicker of cluster icons when the top level menu component is recreated given a change to the page's layout
- Add finer changes and comments to reduce churn from user / system changes to resources
* Server-side pagination for home page clusters list and side bar clusters
- Functional Changes
- SSP now works after vue3 bump
- Home Page Clusters list now uses server-side pagination
- Side Bar clusters list now uses server-side pagination
- Wire in now supported sorting / filtering by id and name used for table columns
- Allow pagination to be enabled given a specific context
- Call findPage without persisting to store
- New Pagination Tools
- PaginatedResourceTable - Convenience Component, wraps ResourceTable with pagination specific props
- PaginationWrapper - Convenience class to handle requests for resources and updates to them (avoiding store)
- Regressions
- Side Nav menu ready state was `mgmtCluster.isReady && !pCluster?.hasError`, now ???
* Iteration
Note - prov clusters is broken (only fetches local) due to blocking pr. breals
- notPinned list
* Fix dupe inStore
- remove from resource list, put in resource-fetch (used also by pag res table)
* Two fixes
- changes namespaces kicked of side nav cluster requests (thought pinnedIds changed)
- fix generic lists re-fetching given ns filter changes (they don't have namespaced arg)
* remove comment, backport fix
* test fixes
* E2E: Ensure we wait for cluster entries to exist before clicking on them
* backport fix for local/api filtering
* Remove debug code
* Changes after review
* e2e fixes / debugging
* More e2e fixes
* More e2e fixes
* More e2e fixes
* Fix generic pages that filter on pagination
* Attempt to fix flaky vai test
* Fix after merge from master
* Updates following new indexed files
* Fix lint and test
* Changes given real cluster tests
- general fixes
- correct issue were sorting prov clusters on mgmt cluster props (issue in master as well...)
- bit the bullet, we now don't fetch all mgmt clusters on dashboard visit.
- there could be knock on affects, but we'd need to remove it sometime in 2.11....
* Fix issues with diplaying rke1 data in home page
- includes https://github.com/rancher/dashboard/pull/12881
* Fix unit tests
* fix keyboard nav for about page
* fix styling for dark mode
* address pr comments
* address pr comments
* change role and add key space handler for diagnostic button
* first iteration to improve extension point for tabs (missing default mode = VIEW)
* add default _DETAIL for the extension tabs extension point so that they are not added to EDIT views as well, unless specified otherwise
* revert harvester change
- caused by shell/scripts/test-plugins-build.sh importing list/catalog.cattle.io.clusterrepo.vue
- the component had been updated to a TS component
- check-plugin build outputs TS errors for a component file imports
- vs code shows no errors for imported file
- general fixes
- correct issue were sorting prov clusters on mgmt cluster props (issue in master as well...)
- bit the bullet, we now don't fetch all mgmt clusters on dashboard visit.
- there could be knock on affects, but we'd need to remove it sometime in 2.11....
This removes the `onChanges()` method from `ResourceYaml.vue` because the intent of the code is not clear and appears to provide no benefit in testing. This is a source of frustration for some users, making it impossible to add comments to YAML.
It appears that this function exists to automatically adjust the indentation of comment lines; it has failed to accomplish this task during testing, so it appears to be meaningless. If users wish to format yaml, we should support this with an explicit action in the YAML editor, not something that is performed on every keypress.
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Phillip Rak