Commit Graph

68 Commits

Author SHA1 Message Date
Richard Cox df9c4be595
Merge pull request #9714 from torchiaf/9665-provissioning-actions-error
Fix 'Scale Down' crash in cluster provisioning details page
2023-09-28 16:06:56 +01:00
Jordon Leach 8874a42305
Update bulk action condition to check for empty resource actions (#9784) 2023-09-27 13:43:41 -04:00
Francesco Torchia 09168d3683
Add empty availableActions to fake rows in cluster provisioning details page
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-09-14 17:38:41 +02:00
Francesco Torchia 14d4077a5d
Fix lint
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-09-04 10:49:11 +02:00
Francesco Torchia fa4d3dd1ca
Implement the page number getter of a row
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-09-04 10:49:10 +02:00
Yonas Berhe f0ba82c83f made updates per change request and fix merge conflict 2023-06-26 10:44:05 -07:00
Giuseppe Leo 01eeb0548f
Add recommended lint rules globally (#8997)
* Update configuration

* Create default config for eslint

* Restore plugin:vue/recommended

* Add exceptions and overrides

* Correct manually remaining issues

* Adding further picked exceptions groupped up

* Fix or disable specific cases manually and singularly

* Add naming linting exception

* Remove unused variable in component

* Move rules to default

* Autocorrect rancher/components linting issues

* Configure VSCode to use multiple files, to display linting for rancher components

* Disable jest lint hook restriction for string list component

* Autofix
2023-06-23 17:02:55 +02:00
yonasberhe23 5e9824edfd
cypress UI automation: account and api keys tests (#8857)
* account and api keys tests

* account & api keys tests: updates made per review

* account and api keys tests: added checkRowCount fn and added step to make test deterministic

* account and api keys tests: removed unused import

* account and api keys tests: update assertion

* account and api keys tests: update navigation test

* account and api keys tests: move deleteButton function, update selector value

---------

Co-authored-by: Yonas Berhe <yberhe@Yonass-MacBook-Pro.local>
2023-05-23 07:34:38 -07:00
Phillip Rak ade3c9f4e7 Replace all instances of `v-tooltip` with `v-clean-tooltip`
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2023-05-18 15:39:14 -07:00
codyrancher 2d575a7cb3
Merge pull request #8767 from codyrancher/standalone
Adding standalone layout for use with standalone extensions
2023-05-01 16:47:33 +02:00
codyrancher f09cb03733 Adding standalone layout for use with standalone extensions 2023-04-29 21:53:19 +02:00
richa 34c9a42147
Removed hasClass method (#8752)
* Removed hasClass method

* Clean code
2023-04-28 14:02:20 +02:00
richa a98ae8a7a9
Fixed selected rows counter (#8419)
* Fixed selected rows counter

* Fixed lint

* Fixed counter in selection.js

* Small fix in toAdd condition

* Lints

* Fixed condition for selected row counter

* Changes in focusAdjacent function

* Fixed lints
2023-04-27 09:26:33 +02:00
Francesco Torchia 74d2a0463d
SortableTable, safe scroll listener remove
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-04-19 16:29:41 +02:00
Francesco Torchia 110a5544f2
selection, fix event propagation on row click
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-04-19 16:18:13 +02:00
Francesco Torchia 8d0bc71df1
selection, safe classes update on row click
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-04-19 16:18:06 +02:00
Francesco Torchia eb1b97da1e
remove jquery, SortableTable
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-04-19 16:17:58 +02:00
Phillip Rak 7cecbc0f62 Replace all instances of `v-html` with `v-clean-html`
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2023-03-22 08:30:15 -07:00
Richard Cox f93ee861fc Fix stale RKE1 cluser information in clusters list
- For RKE1 clusters we use the mgmt cluster state instead of row's prov cluster
- This should all work generically by using the prov clusters stateObj
- However this does not work, updates sometimes bubble to the prov cluster level and when they do sometimes they even make it to the list
- Workaround is to conver the state column and sub row into custom cell and sub row slots
- These update correctly given changes to the mgmt object

Note - I haven't touched the machine summary column, a similar fix might be needed there
2023-02-24 16:04:01 +00:00
Alexandre Alves 6516e094b8
Extensions enhancements (#7777)
* add extensions API methods
---------

Co-authored-by: Alexandre Alves <aalves@Alexandres-MBP.lan>
Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
Co-authored-by: Neil MacDougall <nmacdougall@suse.com>
Co-authored-by: Richard Cox <richard.cox@suse.com>
2023-02-09 10:58:29 +00:00
Alexandre Alves 31ec71f75c
fix issue detected on advanced filtering where searching for a text with an uppercase yelded no results (should be case insensitive) (#8055)
Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
2023-02-06 17:07:15 +00:00
Alexandre Alves d00e8dc4cd
fix styling of visible cols in advanced filtering (#8071)
Co-authored-by: Alexandre Alves <aalves@Alexandres-MBP.lan>
2023-02-06 17:06:59 +00:00
Alexandre Alves 84e260d95e
Manual Refresh Performance Option (#7904)
* update resource fetching on list views so that secondary resources follow the logic of manual refres
h and/or incremental loading if the main resource defines it

* Update resource-fetch logic to take into consideration the storeType for each individual request + fix logic regarding namespace for fetching resources + update missing resources logic (nodes and prov clusters)

* fix tipo

* reinstate hash system to handle requests for nodes and prov cluster lists

* revert mutation code + add check to register type if it doesnt exist on loadDataPage action

* fix issue with timeout that wasnt working properly for the update of live and delayed cols after manual refresh

* Take in to account the per resource count when calculating `limit`
- This means primary resources with a smaller amount don't restrict secondary resources with larger amounts

Co-authored-by: Alexandre Alves <aalves@Alexandres-MBP.lan>
Co-authored-by: Richard Cox <richard.cox@suse.com>
2023-01-27 14:32:42 +00:00
Francesco Torchia 5895859a2b
Events tab, restore tooltips
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-01-25 10:01:49 +01:00
richa 45236c4a80
Fixed column-header tooltip postion (#7901)
* Fixed column-header tooltip postion

* Fixed tooltip position
2023-01-13 10:34:38 +01:00
richa c792d21dd9
Fixed icon size (#7557)
* Fixed icon size

* Add node inactive warning indicator (#7548)

* StringList, delete item on editing

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

* Bump @rancher/components version

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

* Add manage button to home page (#7546)

* Add manage button to home page

* Fix button spacing

* Make buttons smaller - looks better with extra button

* Fixed icon size in simplebox

* icon fix in GrowlManager.vue

* Add node inactive warning indicator (#7548)

* StringList, delete item on editing

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

* Bump @rancher/components version

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

* Add manage button to home page (#7546)

* Add manage button to home page

* Fix button spacing

* Make buttons smaller - looks better with extra button

* Fixed close icon size

* Fixed more icons sizes

* Fixed icon size in namespaces filter

* Reverd css changes in LabeledSelect component

* Fix on Header

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com>
Co-authored-by: Francesco Torchia <francesco.torchia@suse.com>
Co-authored-by: Richa Bisht <RBISHT@Richas-MacBook-Pro.local>
2022-12-08 16:52:53 +01:00
Richard Cox 762b3e4163 Updates following review
- Tweak settings text
- Use new filter icon
- Tweak "too many" text
- Allow only selecting a single namespace when in 'too many' mode
2022-12-02 12:37:35 +00:00
Richard Cox ab2ea9bc9f
Merge pull request #7422 from richard-cox/fix-multi-bulk-actions
Fix initial display of table bulk actions
2022-11-21 13:56:45 +00:00
Francesco Torchia 397069c6b3
Merge pull request #7297 from torchiaf/fix/7264
Sortable Table: prevent sort icons wrap
2022-11-18 10:54:47 +01:00
Phillip Rak a54c91d73d
Merge pull request #7475 from rak-phillip/chore/eslint-key-spacing
Update key-spacing eslint rule
2022-11-17 13:39:05 -07:00
Alexandre Alves 54032dd8d1
fix advanced filtering issue (#7453)
* fix adv filtering issue + bump rancher icons version

* update fix for advanced filtering

Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
2022-11-17 11:36:42 +00:00
Phillip Rak 3d410d0974 Apply linter auto-fixes
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2022-11-16 18:38:20 -07:00
Alexandre Alves 649d300e83
add query param to url for simple table filtering on SortableTable (#7368)
* add query param to url for simple table filtering on SortableTable

* enable query param for simple filtering for only default and custom single tabled list pages

* enable query param for simple filtering for workloads list + other minor updates

Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
2022-11-14 09:31:38 +00:00
Alexandre Alves 1259c4d3f2
fix height of applied filters in advanced filtering (#7340)
Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
2022-11-14 09:25:51 +00:00
Richard Cox e697d74f6c Fix initial display of table bulk actions
Issue 1)
- When there are multiple instances of the table the bulk actions weren't initially visible
- Caused by the `dedounce` definition shared between different instances of the table
Issue 2)
- K3s cluster nodes list would initially show 'delete' action and then magically dissappears
- Caused by mgmt node model canDelete returning undefined instead of false (due to missing norman node which is letter there)
- The check to then show the actions only checked for `false` rather than a falsey
- This would affect anywhere canDelete/canUpdate returns an undefined instead of false
2022-11-11 18:58:52 +00:00
Giuseppe Leo d2d4122bc0
Review HTML formatting rules (#6805)
* Prevent ESLint to format generated paths

* Add HTML ESLint Rules

* Format all the Vue HTML templates except Harvester

* Exclude Harvester package from linting HTML, keeping old formatting rules
2022-11-11 17:04:22 +01:00
Francesco Torchia 9393fb763d
Sortable Table: prevent sort icons wrap
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2022-10-27 11:15:01 +02:00
Alexandre Alves d23fdce250
extend nuxt.config to allow for passing of proxies as config options + fix issue label cols in sortable table for advanced filtering (#7257)
Co-authored-by: Alexandre Alves <aalves@Alexandres-MBP.lan>
2022-10-25 11:46:30 +01:00
Richard Cox bdf6f587be Fix hover state of lists with custom sub-rows
- Fixes #7263
- Covers both node and cis clusterscan tables
2022-10-24 13:44:41 +01:00
Alexandre Alves 105f5b1078
Separate "advanced filtering" feature from Elemental PR (#7134)
* add all changes regarding advanced filtering

* minor fix to filter logic on which the scenario for only value prop was not covered + fix styling issue on adv filter modal box

* remove unwanted prop on catalog.app table + clear white spaces

* clear white spaces

* fix broken dark mode on advanced filtering#

* fix merge conflicts

* fix issue where we couldnt load prov cluster details page + add solution so that manual refresh and adv filtering work together in terms of UX

* fix styling for dark mode

* address PR comments

* address PR comments with multiple changes + move adv filtering logic to a mixin + add missing translations

* fix live and delayed updates on adv filtering

* fix issues where label values where not appearing on the rows + move click event binding to toggle flag watcher + move update cols to box toggle flag watcher

* remove translation that was moved to dedicated file

* address PR comments + fix filtering of labels + keep cols previous visibility on each evaluation of the table options

Co-authored-by: Alexandre Alves <aalves@Alexandres-MBP.lan>
Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
2022-10-17 11:53:40 +01:00
Alexandre Alves 866f4d8032
Add manual refresh + incremental loading to all list views (#6908)
* removing check for restriction of types on incremental+manual + update masthead to incorportate directly the ResourceLoadingIndicator so that it can used by list views with custom mastheads + move catalog.clusterrepo typedescription to its rightful component and delete custom list view + updating custom list views to use resource-fetch mixin

* continue updating custom list views to use resource-fetch mixin

* finish updating custom list views to use resource-fetch mixin + prevent error on loadAdd mutation where type is not set in store yet + code cleanup

* address PR comments

* update all custom list views to use loading prop on ResourceTable rather than Loading component + use getter to get incremental updates propagated from the store into the table itself + other minor fixes

* revert changes to mutation loadAdd as check is not needed

* revert all changes to shell/list/harvesterhci.io.management.cluster.vue

* revert deletion of clusterrepo due to CI/CD validation of plugin

* add manual + refresh to namespaces list + fix issue where switching between workspaces results in the manual refresh button continually spinning

* move rows and loading flag to resource-fetch and do necessary changes to custom lists to minimize code changes for the future

* Minor fixes
- Match existing loading check in projectnamespace list (had a check for currentCluster, probably not needed but added just in case)
- Fixed masthead loading indicator for management users and features

Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
Co-authored-by: Alexandre Alves <aalves@Alexandres-MBP.lan>
Co-authored-by: Richard Cox <richard.cox@suse.com>
2022-10-09 10:37:38 +01:00
Neil MacDougall 332f7309ba
Plugins: Move formatter cache loading out of Sortable Table (#6978) 2022-09-24 09:57:24 +01:00
Alexandre Alves 8490dd4b59 remove check for timeout clearance 2022-09-19 14:52:32 +01:00
Alexandre Alves b26af7d738 bump timeout 2022-09-19 10:53:55 +01:00
Alexandre Alves 9938f0a7ba revert changes and increase timeout for applying watcherUpdateLiveAndDelayed with manual refresh 2022-09-19 10:53:55 +01:00
Alexandre Alves c33dea688b fix issue where where manual refresh wasnt triggering live and update of delayed cols in sortable table 2022-09-19 10:53:55 +01:00
Alexandre Alves dbce9a902f
update initialLoad flag watcher in order to be properly triggered when data is already on the store for a given resource (#6889)
Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
2022-09-14 15:11:38 +01:00
Richard Cox 3769c84b1f Fix text for list's collapsed bulk action button 2022-09-13 10:59:24 +01:00
Richard Cox 43d338fac2
Harvester Plugin (#6729)
* routing maybe

* remove nested edit views

* harvester custom routes

* fix loading imported dev cluster

* move harvester-manager hci.cluster type out of harvester pkg

* fixes for build-pkg

* fix harvester custom dialogs

* fix harvester pkg routing

* generateDynamicTypeImport hyphenated dirs

rename cloud_credential and machine_config back to cloud-credential and machine-config

* Appease linting

* Fix epinio pkg build
- Includes fixes for some dashboard component references

* Revert "Receiver credential secrets are deleted when secret is set to none"

This reverts commit 836460e2998959bcda0b14a9f6511f248980b7b5.

* Fix plugin modal cancel button in dark mode

* Ensure correct components loaded when a new version of a plugin is loaded
- The route matcher was never updated with new route-->component values
- This was due to `this.router.options.routes` not containing the result of `router.add`
- See https://github.com/vuejs/vue-router/issues/2280

* Revert "Revert "Receiver credential secrets are deleted when secret is set to none""

This reverts commit e524bb3d40ea7adfe35c38ec7870560625965d25.

* fix harvester manager->harvester routing

* rename dialogs

* move harvester-manager files out of harvester pkg

* Revert "remove nested edit views"

This reverts commit e835835943d63e74c50942884fec3706f8703047.

* plugin validators dynamic import - not working

* fix merge conflict

* fix harvester members

* fix conflict

* custom validators

* harvester table formatters

* members routing

* import path fixes

* harvester mutli load

* Port across tweaks made during dynamic plugin work
- harvester plugin can be bundled with the dashboard until dynamic work has been completed
- Nav directly to virt cluster dashboard instead of via /harvester-c-cluster
- Fix missing bottom border on virt cluster list, hide actions (as they're never populated)

* move config/settings and config/harvester-map

fix hci setting custom components

* fix harvester setting import path

* Move over SerialConsole and Novnc, remove harvester.notifications
- These components were so 1-1 with harvester in the end i moved them over
- Also removed the like-for-like generic.notification `harvester.notification` strings

* Remove isSingleVirtualCluster, most of isMultiVirtualCluster

* Fix two nav issues
- harv cluster members --> prefs --> click on-screen back
- dashboard --> prefs --> click on-screen back

Both of these would be better fixed by an incoming change to the default layout (don't show old content before switching page)

* Fix reload of project/namespace page

* Split out project namespace into it's own component (1 or 2)

* Split out project namespace into it's own component (2 or 2)

* use product hideSystemResources opt instead of isVirtual/product===virtual

* fix missing prop in header

* Move FilterLabel and CloudInitType to harv pkg + two other references

* Move Harvester Upgrade components to harv pkg
- Needs a review with Neil regarding generics

* rebase build+load not working

* fix harvester route in authenticated

* Experimental Changes

* Fix merge conflicts

* WIP Fix routing
- includes project/namespace and namespace pages

* Tidying up

* Move harvester core store to plugin, remove harvester code from authenticated flow
- harvester store is a steve store that now lives in the plugin
- harvester `loadVirtual` replaced with a shortened `loadCluster` in it's own store
- Also fix xterm css import

* Fix three routing related bugs
- Fix project/namespace create/edit/cancel/done flows
- Update harvester's loadCluster to better match loadCluster
- Make edit namespace page project resource agnostic

* Build fixes

* Fix create namespace button and other tweaks

* fix two issues with nav out of imported harvester cluster

* Fix alignment of action menu button
- Used in many places
  - all generic table action menus
  - global settings --> settings
  - rke1 cluster detail page machine pool group actions
  - project/namespace list project group actions
  - resource detail page action menu

* Revert changes to app and pkg creators
- This should fix `check-plugins-build` gate
- It does hide the underlying issue, but that won't have been brought in by this PR?

Co-authored-by: Nancy Butler <42977925+mantis-toboggan-md@users.noreply.github.com>
2022-09-01 08:57:05 -07:00
Giuseppe Leo 698194fea3
Create E2E tests for cluster CRUD operations (#6284)
* Set data test id and allow complex component to have default and inherited values for all the actions

* Create cluster tests with steps; Create cluster E2E test

* Extend command to use selector matchers

* Create test for cluster navigation and deletion

* Extend commands to find by id as in get method

* Extend documentation with guidelines and info about E2E

* Correct cluster delete and details tests to get menu within speciftc cluster row

* Add remaining E2E tests for the cluster

* Add baseUrl to the paths

* Add RKE2 selection on cluster creation for CI

* Add E2E debugging information

* Rename clluster manager E2E for consistency

* Correct data test ID after rebase

* Prevent cluster provider errors if no management parameter is provided

* Prevent accessing objects in mutation if none is provided

* Remove imported cluster sample due discarded logic

* Reset RKE2 switch on cluster creation

* Adjust test naming for cluster manager

* Group tests under scoped cases
2022-08-17 20:48:20 +02:00