Merge pull request #2750 from westlywright/2.2-bugs

GDNS Provider - remove secret key param

lib/global-admin/addon/global-dns/providers/new/controller.js

@@ -57,6 +57,19 @@ export default Controller.extend(ViewNewEdit, {
     }
   }),
 
+  validate() {
+    const providerConfig = get(this, `config.${ this.activeProvider }ProviderConfig`);
+    const { mode }       = this;
+
+    if (mode === 'edit' && providerConfig && providerConfig.hasOwnProperty('secretKey')) {
+      if (providerConfig.secretKey === '' || providerConfig.secretKey === null) {
+        delete providerConfig.secretKey;
+      }
+    }
+
+    return this._super(...arguments);
+  },
+
   doneSaving() {
     this.send('cancel');
   },

lib/global-admin/addon/templates/-alidns-dns-provider.hbs

@@ -45,7 +45,20 @@
         class="acc-label"
         for="alidns-api-key"
       >
-        {{t "globalDnsPage.providersPage.config.secretKey.label"}}{{field-required}}
+        {{t "globalDnsPage.providersPage.config.secretKey.label"}}
+        {{#if (eq mode "edit")}}
+          {{#tooltip-element
+             type="tooltip-basic"
+             model=(t "globalDnsPage.providersPage.config.secretKey.info")
+             tooltipTemplate="tooltip-static"
+             aria-describedby="tooltip-base"
+             tooltipFor="tooltipSecretKey"
+          }}
+            <i class="icon icon-info"></i>
+          {{/tooltip-element}}
+        {{else}}
+          {{field-required}}
+        {{/if}}
       </label>
       {{input
         classNames="form-control"

lib/global-admin/addon/templates/-route53-dns-provider.hbs

@@ -45,7 +45,20 @@
         class="acc-label"
         for="route53-secret-key"
       >
-        {{t "globalDnsPage.providersPage.config.secretKey.label"}}{{field-required}}
+        {{t "globalDnsPage.providersPage.config.secretKey.label"}}
+        {{#if (eq mode "edit")}}
+          {{#tooltip-element
+             type="tooltip-basic"
+             model=(t "globalDnsPage.providersPage.config.secretKey.info")
+             tooltipTemplate="tooltip-static"
+             aria-describedby="tooltip-base"
+             tooltipFor="tooltipSecretKey"
+          }}
+            <i class="icon icon-info"></i>
+          {{/tooltip-element}}
+        {{else}}
+          {{field-required}}
+        {{/if}}
       </label>
       {{input
         classNames="form-control"

translations/en-us.yaml

@@ -1176,6 +1176,7 @@ globalDnsPage:
       secretKey:
         label: Secret Key
         placeholder: Your secret key
+        info: Secret key already provided. It is only required when updating the keys themselves.
       apiEmail:
         label: API Email
         placeholder: Your API Email