diff --git a/lib/shared/addon/components/cluster-driver/driver-rke/component.js b/lib/shared/addon/components/cluster-driver/driver-rke/component.js index d8e07976d..b7c5b6454 100644 --- a/lib/shared/addon/components/cluster-driver/driver-rke/component.js +++ b/lib/shared/addon/components/cluster-driver/driver-rke/component.js @@ -548,10 +548,8 @@ export default InputTextFile.extend(ManageLabels, ClusterDriver, { return remapped; }), - canSave: computed('allErrors.[]', function() { - let { clusterOptErrors, } = this; - - return (clusterOptErrors || []).length > 0; + canEditForm: computed('clusterOptErrors.[]', function() { + return (this.clusterOptErrors || []).length === 0; }), kubeApiPodSecurityPolicy: computed('config.services.kubeApi.podSecurityPolicy', { @@ -826,11 +824,9 @@ export default InputTextFile.extend(ManageLabels, ClusterDriver, { }, set(key, value) { - if (this.clusterOptErrors && this.clusterOptErrors.length > 0) { - next(() => { - set(this, 'clusterOptErrors', this.checkYamlForRkeConfig(value)); - }); - } + next(() => { + set(this, 'clusterOptErrors', this.checkYamlForRkeConfig(value)); + }); return value; } @@ -881,7 +877,7 @@ export default InputTextFile.extend(ManageLabels, ClusterDriver, { let decamledYaml = this.parseOptsFromYaml(yamlValue); if (decamledYaml && isEmpty(decamledYaml.rancherKubernetesEngineConfig)) { - set(this, 'clusterOptErrors', [`Cluster Options Parse Error: Missing Rancher Kubernetes Engine Config`]); + set(this, 'clusterOptErrors', [`Cluster Options Parse Error: Missing rancher_kubernetes_engine_config key`]); return; } @@ -931,10 +927,6 @@ export default InputTextFile.extend(ManageLabels, ClusterDriver, { if (this.updateFromYaml) { this.updateFromYaml(newOpts); } - } else { - ok = false; - - return ok; } } @@ -1035,11 +1027,9 @@ export default InputTextFile.extend(ManageLabels, ClusterDriver, { errors = this.validateAuthorizedClusterEndpoint(errors); } - const clusterOptErrors = get(this, 'clusterOptErrors') || []; - set(this, 'errors', errors); - return errors.length === 0 && clusterOptErrors.length === 0; + return errors.length === 0; }, validateAuthorizedClusterEndpoint(errors) { diff --git a/lib/shared/addon/components/cluster-driver/driver-rke/template.hbs b/lib/shared/addon/components/cluster-driver/driver-rke/template.hbs index 61b6c9ac8..cd028ce20 100644 --- a/lib/shared/addon/components/cluster-driver/driver-rke/template.hbs +++ b/lib/shared/addon/components/cluster-driver/driver-rke/template.hbs @@ -16,23 +16,13 @@