rancher
/
ui
mirror of https://github.com/rancher/ui.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Ensure skipping works for multiple cis versions 

We validating the security scan config appropriately when
a version was already present in the skip list. This now
ensures a version exists before verifying that it contains an array.

We were also replacing the existing skip object in the
security-scan-config which prevented us from storing
multiple versions at a time. We now extend the object
instead using the spread operator.

rancher/rancher#24733
rancher/rancher#24742
This commit is contained in:
Cody Jackson 2019-12-23 10:10:05 -07:00
parent e88161745c
commit 2f58374c39
3 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/authenticated/cluster/cis/scan/controller.js
View File

@ -49,7 +49,7 @@ export default Controller.extend({
runningClusterScans: computed.filterBy('clusterScans', 'isRunning', true),
isRKE: computed.alias('scope.currentCluster.isRKE'),
isRKE: computed.alias('scope.currentCluster.isRKE'),
actions: {
runScan() {
get(this, 'scope.currentCluster').doAction('runSecurityScan', {
@ -59,7 +59,7 @@ export default Controller.extend({
}
},
disableRunScanButton: computed('runningClusterScans', 'scope.currentCluster.systemProject', function() {
return get(this, 'runningClusterScans') || !get(this, 'scope.currentCluster.systemProject');
return get(this, 'runningClusterScans.length') > 0 || !get(this, 'scope.currentCluster.systemProject');
}),
bulkActionHandler: computed(function() {

2
app/authenticated/cluster/cis/scan/detail/controller.js
View File

@ -62,7 +62,7 @@ export default Controller.extend({
},
disableRunScanButton: computed('runningClusterScans', 'scope.currentCluster.systemProject', function() {
return get(this, 'runningClusterScans') || !get(this, 'scope.currentCluster.systemProject');
return get(this, 'runningClusterScans.length') > 0 || !get(this, 'scope.currentCluster.systemProject');
}),
tests: computed('model.scan.report', 'securityScanConfig.skipList', function() {

11
lib/shared/addon/security-scan-config/service.js
View File

@ -77,7 +77,7 @@ export default Service.extend({
return;
}
if (!Array.isArray(parsed.skip[version])) {
if (parsed.skip[version] && !Array.isArray(parsed.skip[version])) {
throw new Error("Security Scan Config didin't contain the 'skip' array.");
}
} catch (error) {
@ -145,7 +145,14 @@ export default Service.extend({
editSkipList(newValue) {
const version = get(this, 'report.version');
const newSkipListObject = { skip: { [version]: newValue } };
const existingSkip = get(this, 'parsedSecurityScanConfig.skip') || {};
const newSkipListObject = {
skip: {
...existingSkip,
[version]: newValue
}
};
const newConfig = { [get(this, 'FILE_KEY')]: JSON.stringify(newSkipListObject) };
this.editSecurityScanConfig(newConfig);