We shouldn't need this param any longer and including it ensure that a new call
is made on every launch click. This is fine at small scale but will start to
slow everything down when at scale.
rancher/rancher#25024rancher/rancher#25026
When the promise was rejected it took the error value and
set that as the value of the promise.
This lead to code expecting one shape to completely fail. This
now assigns the errorValue to an errorValue property on the
promise and the defaultValue to value when a promise is rejected.
rancher/rancher#24620
I originally tried to fixrancher/rancher#24704 without completely
special casing. Unfortunately that lead to other issues:
rancher/rancher#24745rancher/rancher#24794rancher/rancher#24814
I decided to revert all of the related changes and to just special
case this one instance. Ultimately I think the removeEmpty is the
culprit but it requires backend changes in order to properly fix
and those changes are not happening right now.
Having this min num check here is not really incorrect but it makes for a weird
UX. The users typed value is overridden because it never reaches the minimum
since each keystroke causes the change event to fire.
rancher/rancher#24724
We were erroneously adding cloud_provider.awsCloudProvider on
digital ocean etc due to rancher/rancher#24515.
This change assumes that the presence of
onfig.rancher_kubernetes_engine_config.cloud_provider.name
implies that the cloud_provider should be present. If that
nested field isn't present we remove cloud_provider.
rancher/rancher#24745
we use this to hide the remove action button on the default row when creating
one fo the two mentioned resources. This is because the backend automatcially
sets up this binding on create. We display this fake member so the user doesnt
feel like they need to add themsevles as a member.
We validating the security scan config appropriately when
a version was already present in the skip list. This now
ensures a version exists before verifying that it contains an array.
We were also replacing the existing skip object in the
security-scan-config which prevented us from storing
multiple versions at a time. We now extend the object
instead using the spread operator.
rancher/rancher#24733rancher/rancher#24742
When the user doesn't have access to the systemProject we just
return an empty configMap so the page can proceed without error.
We also disable the runScan button if the systemProject isn't available.
rancher/rancher#24644
When adding input-yaml to a modal it required the user to click on
the input before the value would be loaded and the editor resized.
I found a github issue which suggested making use of the isVisible
property to force a refresh so I added the use of it to force refreshing
to happen.
I also made it so the header didn't add a margin if the header wasn't
present.
The downloaded report now has:
- A column for passed_nodes
- A column for failed_nodes
- A column for all nodes the test ran against
- The benchmark version in the header
rancher/rancher#24671
Westly Wright
Westly Wright
Cody Jackson
loganhz
shanewxy