Commit Graph

1919 Commits

Author SHA1 Message Date
Westly Wright 56305e3f18
alert global role remover how many users have role
rancher/rancher#24301
2019-12-03 11:46:30 -07:00
Cody Jackson 5126642250 Implement the list and detail views for CIS scan
This adds and implements the /c/<clusterid>/cis/scan
and /c/<clusterid>/cis/scan/detail/<scanid> routes.

rancher/rancher#20425
2019-12-02 14:45:56 -07:00
Westly Wright a7a81456b4
Feature: associate global role w/external group
rancher/rancher#23452

expose link-to new-group route

Translations change and move static property (convention)

Refactor form-global-roles

Refactor such that user and group are optional parameters. Adds
groupPrincipalId. Destructure smarter so that users are not required for the
mapper function to work. Move bindings to own init. Refactor make to recognize
groups. Translations changes.

Add cru-group-account component

This component does not actually create a group but a global-role-binding with a
groupPrincipalId instead of a userId. Perhaps cru-global-role-binding would work
but in the future this component can and probably will be adapted to create
local groups as well, so the name would fit. At that point the component could
also be refactored to work for the add user page because at that point pretty
much doing the same thing but that is not with-in the scope of this change.

Currently the componet is expected to be used with an auth provider that
supports groups which is why it does not also create the group. This should be
taken into consideration if we ever update this to work with local groups.

Translations changes.

formatting

wip

Add tab nav template only component

rename users index route -> users & add groups route

get groups from grb list and build groupPrincipal list

Add role binding to the fetched group principal

Add account-group-row component and define table row views

global role binding with group edit page

Fix transitionTo in cancel and doneSaving -> cru-group-account

translations

Add initialPrincipal param to input-identity to allow use on edit

reduce duplicate principal calls and display on groups list page

fix role links types from account-group-row

add group delete functionality

translations and bulk action fix

sort global role names in modal and row

delete GRB modal translations

move users route to security-> users, break out groups route security

remove unneeded component

Live update fixes

translation fix

fix broken link to old accounts route

remove unneeded props, angle bracket components, general cleanup

lint fixes

Change add group button

Add warning on add group for non-local auth only and translations

Remove warning from delete group modal and change translations

re-org form-global-roles display

breaks the display out into base|user-custom|additional roles
adds back in details & descriptions
fixes role ids in translations file
2019-12-02 09:40:26 -07:00
Westly Wright 904985c540
udpate aks default k8s version
rancher/rancher#24239
2019-11-25 15:22:06 -07:00
Westly Wright 5062e53a45
Fix borked jQuery targeting in input-password 2019-11-14 11:05:56 -07:00
Westly Wright 87cd611652
Merge pull request #3513 from westlywright/fp.cr8.template.from.cluster
[Forwardport] Convert Existing Cluster to RKE Cluster Template
2019-11-13 15:25:36 -07:00
Westly Wright 3223869788
make cloud provider uneditable
rancher/rancher#24008
2019-11-08 16:17:20 -07:00
Westly Wright a905dc2c0c
network plugin not editable
rancher/rancher#23999
2019-11-08 11:01:22 -07:00
Westly Wright a6d2020265
Merge pull request #3556 from westlywright/eks.vpc.init.state
Refactor the logic backing GKE network/subnetwork selections
2019-11-08 10:53:27 -07:00
Cody Jackson 76adaf8658 Notify user of value missing from options
When using an older vsphere node template in the latest version it was
possible that a user entered value would not be a valid option. When
the value isn't a valid option the dropdown has nothing selected. To
improve the UX we now notify the user that the current value is no
longer valid and sask them to select a new value.

rancher/rancher#23920
2019-11-07 16:51:15 -07:00
Westly Wright 3399b66bc3
refactor the logic backing GKE network/subnetwork selections
While working on a ticket to provide the ability to de-select subnetworks when
using the create subnetwork option I discovered the options were all messed up
and allowed you to misconfigure yourself into a hole.

I've moved ipalias and related networks settings out of advanced becuase
depending on what you select for your subnetwork the ability to choose ipalias
and the other settings changes.

This change allows you deselect a node subnet so you can create a subnetwork
automatically.

rancher/rancher#21079
2019-11-07 14:06:12 -07:00
Westly Wright 62bee3bdf0
Merge pull request #3553 from WuJun2016/my-master
[forwardport] Too many annotations are read-only
2019-11-07 09:14:33 -07:00
Westly Wright 62e116b00d
Merge pull request #3552 from westlywright/eks.vpc.init.state
Select Correct EKS VPS & Subnet on Edit
2019-11-07 09:14:16 -07:00
wj fda89eb4aa Too many annotations are read-only
https://github.com/rancher/rancher/issues/23849
2019-11-07 13:27:03 +08:00
Westly Wright 1ea956ee07
update vpc & subnet observers to watch steps to init correctly
rancher/rancher#23879
2019-11-06 12:18:37 -07:00
Westly Wright 0bf3ed5553
Fix translations bug in searchable-select
when I removed maybe-t helper I forgot to check grouped content in the
searchable select which was still looking for a translations. Moved the
translation lookup to the component when we generate the groupedContent so we
dont run into this issue again

rancher/rancher#23946
2019-11-06 11:07:09 -07:00
Westly Wright 5bc4737743
Fix sorting on cloud credentials page
While I was cleaning this up I found that groupByRef in cc this case did nothing
so I removed it. This exposed a bug in the sortable-table code where groupByRef
was coming back null but when we tried to get it, using embers getter, it would
fail because we passed a null value instead of an empty string.

Additionally I found that when using presorts we were continuously pushing into
the sort array on the component, which never gets reset, so I decided to clone
the array. We rarely use preSorts so it was never caught.

Additionally we never add/remove the descending key to our presorts so I've
added that. Without these when we pass the sort to embers sort we'd never
correctly sort any presorts based the descending flag.

rancher/rancher#23828
2019-11-01 09:14:20 -07:00
Westly Wright 9a1c05e8eb
Merge pull request #3524 from westlywright/fp.service.discovery
[forwardport] revert change to form-value-array
2019-10-31 14:37:55 -07:00
Westly Wright adcfbf96bb
Merge pull request #3527 from codyrancher/one-option-fp
[forwardport] Fix FormContextualSelectArray to accept 1 option
2019-10-31 14:34:27 -07:00
Cody Jackson 8c5e2f021f Fix FormContextualSelectArray to accept 1 option
When there was only one option we the add button was disabled and
we couldn't add the one option.

This change fixes it so that we can still select the single option if
desired.

rancher/rancher#23780
2019-10-31 13:55:33 -07:00
Westly Wright 40f95e8e9c
revert change to form-value-array
rancher/rancher#23791
2019-10-31 11:11:49 -07:00
Westly Wright 04c44e3f9e
Merge pull request #3519 from westlywright/fp.translation.fix
Fix Intermittent Translation Not Loading Issues
2019-10-31 09:38:15 -07:00
Westly Wright 77e1df7060
remove translation as we had localizedPrompt set true 2019-10-30 12:14:43 -07:00
Westly Wright 231c9b6f1f
remove maybe-t helpers because t has default (fallback) built in 2019-10-30 12:14:43 -07:00
Westly Wright d98edaa785
Merge pull request #3511 from codyrancher/aks-message
Use correct AKS messaging for create cluster
2019-10-30 11:09:36 -07:00
Westly Wright 8058d3de4d
refactor form-versions logic to reduce complexity and bugs
I think the file it self may look more verbose as I've broken several of the
confusing portions into pure(ish) functions. I think this reduces the complexity
of the logic and makes it easier to read. Hopefully this will reduce the bugs
that keep cropping up.
2019-10-29 14:07:49 -07:00
Westly Wright 281a922cb4
Add save as rke template action to clusters
rancher/rancher#23752
2019-10-29 13:51:31 -07:00
Cody Jackson 7a956b1fa5 Use correct AKS messaging for create cluster
When creating an AKS cluster an alert with an EKS message. This
simply switches the message to use the AKS message.

rancher/rancher#23601
2019-10-29 11:56:46 -07:00
Cody Jackson cb3bb885f1 Provide better node template UX
We want to provide the owner as additional information when showing
node templates on the node templates page. We also want to make it so
that when selecting a node template the users templates will be grouped
and sorted to the top by default.

rancher/rancher#23325
2019-10-29 09:42:14 -07:00
Westly Wright 113372e524
during jquery dep warnings fix we started grabbing the wrong element
which caused some undefined errors to start sprouting up

rancher/rancher23682
2019-10-25 14:22:36 -07:00
Westly Wright 4d1b629382
Merge pull request #3503 from westlywright/fp.k8s.version.bug
[Forwardport] Select correct k8s version when changing templates
2019-10-25 09:37:47 -07:00
Westly Wright b5173c2e46
Select correct k8s version when changing templates
rancher/rancher#23682
2019-10-25 09:27:07 -07:00
loganhz c74660df31 Fix graph issue
https://github.com/rancher/rancher/issues/23654
2019-10-25 11:41:15 +08:00
Westly Wright c32e1f2d05
Merge pull request #3492 from codyrancher/fp-master-3474
[forwardport] Ensure istio member type is correct on add
2019-10-23 12:01:25 -07:00
Westly Wright 66c05c2397
Merge pull request #3491 from codyrancher/fp-master-3490
[forwardport] Fix EKS cluster creation transition
2019-10-23 12:00:50 -07:00
Westly Wright 0a5a355e33
Merge pull request #3486 from lvuch/lh-1015
node pools help text
2019-10-23 11:59:38 -07:00
Westly Wright 7d74adedf6
Merge pull request #3483 from codyrancher/fp-master-3475
[forwardport] Improve vsphere driver UX
2019-10-23 11:58:00 -07:00
Cody Jackson f72836ef40 Ensure istio member type is correct on add
When adding a github group to be an instio member we wanted the
appropriate Member Type to be displayed. We wanted 'Organization'
instead of 'group'.

We noticed that addAuthorizedPrincipal was being invoked with a newly
created member object instead of just passing the principal. Since
everything we could inspect code wise expected a principal instead
of a member I went ahead and just passed the principal.

rancher/rancher#23264
2019-10-22 14:46:34 -07:00
Cody Jackson 7902a0fd62 Fix EKS cluster creation transition
After pressing the 'create' button of the EKS driver the user was being
transitioned back to step 3 (Vpc & Subnet) rather than waiting on the
final page until the save is complete and returning to the cluster page.

An observer was being triggered by the save process which subsequently
set the step back to 3. To resolve this we will only enter the branch if
there are initialized values that need to be set back to default.

rancher/rancher#23493
2019-10-22 14:16:01 -07:00
lvuch 1fa64d0c97 help text on node pools edit 22782 2019-10-21 15:33:57 -07:00
Cody Jackson 4b2c79ea3d Improve vsphere driver UX
-We now prepopulate fields as select component instead of just
free-form text fields.
-We added support for cloning from different sources.
-We also added support for custom attributes and tags.

To implement the above features we also added support for promise
based content for new-select and search-select and created a new
component contextual-select-array which provides a method for
filtering content based on previous selections.

rancher/rancher#21580
2019-10-21 13:19:14 -07:00
Cody Jackson 0fe6c33eb5 Improve kube version inspection on cluster edit
While editing a cluster properly support .x kube version comparisons when
filtering out cluster template revisions.

Coercing a .x version converts it to a .0 which made the revision look like
it was a kube downgrade. By making use of .satisfies when the revision
kube version ends with a '.x' we're now better able to check if the
kube version is a downgrade and filter appropriately.

rancher/rancher#23489
2019-10-21 12:21:09 -07:00
Westly Wright 1b192be926
Merge pull request #3358 from codyrancher/security-options
[WIP] Display security options when editing GKE cluster
2019-10-21 09:42:07 -07:00
Westly Wright d711b8b8bb
disp k8s ver correctly when editing cluster or clone rev
the check-override-allowed component did not know how to deal with the k8s
version question because of its tri state and how we deal with the patch version
that is an override but not really an override. I added a check to verify the
mode is view and we have the param then display param so we don't initialize the
form-version component which has logic to inject the current version into its
versions dropdown but only if we're new, editing, or cloning.

rancher/rancher#23478
rancher/rancher#23465
2019-10-17 10:48:37 -07:00
Westly Wright b24711b4e7
Merge pull request #3450 from codyrancher/aks
Add network plugin and supporting param
2019-10-17 09:55:06 -07:00
Cody Jackson ef63c2a9c6 Ensure the current Kubernetes version can display
The current kubernetes version wasn't being shown if it was no
longer a part of the supported versions when in view mode. Instead
the latest version was being displayed even if that wasn't what was
deployed. To resolve this we include the current version as one of
the choices if it's not present.

rancher/rancher#23465
2019-10-15 17:56:14 -07:00
Cody Jackson c7d26ecbce Add network plugin and supporting param
This adds the Network Plugin param as well as the PodCidr param.

rancher/rancher#22616
2019-10-15 16:06:13 -07:00
Westly Wright 738dc981b7
Merge pull request #3440 from westlywright/forward.tolerations
[Forwardport] Display Atypical Tolerations Correctly
2019-10-10 11:04:55 -07:00
Westly Wright 0c7a824c28
MAINTAINENCE - Use ember getters & setters 2019-10-10 09:53:22 -07:00
Westly Wright 997313b6fc
Clean up toleration template logic to display the correct info
there are certain params that are not required by the k8s toleration api, Key
and Operator, which if excluded mean different things. See
https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/ for
examples of how these two keys are used.

rancher/rancher#18605
2019-10-10 09:53:11 -07:00
loganhz d2b1382477 Hide catalog items if there is no templates 2019-10-10 11:46:27 +08:00
n313893254 440916a29b Fix jquery errors 2019-10-09 16:38:11 +08:00
Westly Wright 0f85e74fec
more jquery errors 2019-10-07 16:49:01 -07:00
Westly Wright 351fd47823
Fix various master bugs from ember upgrade
We fixed a few deprecation for jquery on the cluster page but there were some
errors firing when using so I fixed the targeting.
There was also a intl error because of a missing api.
2019-10-07 12:01:00 -07:00
Westly Wright 2c67c35c28
Exclude local user from principal search
rancher/rancher#23247
2019-10-07 09:18:21 -07:00
Westly Wright 94301e5fd4
Merge pull request #3411 from codyrancher/deprecation
Addressing a number of ember deprecations
2019-10-04 13:55:01 -07:00
Westly Wright b26a83c1c0
Merge pull request #3420 from westlywright/forwardport.istio.rbac.fixes
[Forwardport] Restrict Istio member access to groups only
2019-10-04 12:16:33 -07:00
Westly Wright 9feea7bbcc
Restrict Istio member access to groups only
Due to some oddities in the way that Istio currently allows access to members to
the kiali and jaeger ui's we've decided to restrict the member search to groups
only. I've changed the verbiage on the lables to reflect this. Additionally I've
also exposed the searchOnlyGroups param on the principal search component. I did
not expose the user only param because this is not something we're normally
going to be doing.

rancher/rancher#23215
2019-10-04 12:01:27 -07:00
Westly Wright bc00ac6a72
Change windows docker version for custom clusters
rancher/rancher#23219
2019-10-03 16:46:38 -07:00
Cody Jackson 6718c4886e Addressing a number of ember deprecations
- Moved from Ember.$() to importing jquery.
- Moved from fn().on() to on(fn())
- Moved from fn().observes() to observer(fn())

This got /g/clusters from 27 warnings to 5 warnings for me.
2019-10-03 10:53:36 -07:00
Westly Wright a2a0ce1e79
Merge pull request #3404 from westlywright/identicon.icons.fix.21440
[2.3.2] Ensure project-member-row uses same identicon as principal model
2019-10-02 14:00:03 -07:00
Westly Wright 5f572f3674
Upgrade Ember to 3.12
Remove ember object and use regular object instead

Found durning upgrade to 3.12, I'm not sure why we'd even need to declare an
ember object for this return anyway.

Get the current cluster's id from scope servervice

Found durning upgrade to 3.12, not sure how this ever worked as I looked on live
and it was failing but the system didn't explode on 3.8. In 3.12
transistion.params is undefined and the whole system explodes. We were never
passing the queryparams so they wouldn't have come through. I changed this so we
fetched the current cluster id from the scope service and everything seems to
work correctly.

Ensure that accordion items only try to expand once during the init

Found durning upgrade to 3.12, expanded was being double rendered.

lint fix

test fixes

lint
2019-10-02 13:33:15 -07:00
Westly Wright 10d148eecb
Ensure project-member-row uses same identicon as principal model
project-member-row was using `avatarSrc` on its component which was slightly
different then the same code used in the principal model but really should have
been the same. I got rid of the duplicate code in the component since the model
is the data owner. It really should manage the avatar source building.

I also updated single quotes to doubles in template and refactored the owner
logic since it wasn't doing anything extra that the noUpdate flag was doing.

rancher/rancher#21440
2019-10-01 09:00:07 -07:00
Cody Jackson 71a7fb8d2d Include Template/Revision in cluster table
We want to make it easier for someone that is managing multiple
clusters to see what template and template revision a cluster
is using. We also want to make it easy for a user to notice
that a cluster isn't using the latest revision.

To achieve this we added the template and revision to a column
in the clusters table to display both. We also indicate add
a warning badge beside a revision when the revision isn't
the latest.

rancher/rancher#22047
2019-09-26 09:20:45 -07:00
Westly Wright 702eb261ff
Fix k8s version dropdown when editing cluster with prohibitied k8s v
When a user upgraded there rancher install to >2.3 with clusters on now
unsupported versions of k8s we would show them the label that is used when
launching with a cluster template instead of the unsupported label

rancher/rancher#23085
2019-09-25 14:56:50 -07:00
Westly Wright 521ed6ca09
wireup ovveride row value to form value when cloning rke template
When cloning a RKE template revision with overrides the values of the override
in the form were not reflected in the overrides section at the bottom of the
page because the alias on the question was never created.

rancher/rancher#23056
2019-09-25 13:11:51 -07:00
Westly Wright 9bb9f17668
Show 'Latest' version label rather then derived version on temp view
When viewing or cloning a template version the form-versions component would
select the derived version rather then the semver version the template was
created with. Now we will display the correct label or select the correct semver
version when in a view or clone of RKE templates.

rancher/rancher#23065
2019-09-25 11:13:25 -07:00
Westly Wright 6005c1969b
Change bulk select pagination label for RKE Templates
rancher/rancher#23068
2019-09-25 10:49:35 -07:00
Westly Wright 59f7c37aca
Hide 'Custom Cluster Overrides' section when launching cluster
`Custom Cluster Overrides` was originally designed when we allowed users to
create custom overrides for items not in the UI but since that was removed the
template consumer will only ever see overrides for sections we have built in
and when launching we never display the overrides for ones with UI components.

rancher/rancher#23069
2019-09-25 10:17:42 -07:00
loganhz 5be694180d Update aks text 2019-09-25 10:28:08 +08:00
Westly Wright 36153de61a
Merge pull request #3381 from loganhz/alihub
Add Alibaba App Hub in catalog list and disable it by default
2019-09-24 09:56:01 -07:00
loganhz cc7d1bb477 Add Alibaba App Hub in catalog list 2019-09-24 11:19:07 +08:00
Westly Wright eba04c5eae
Use the correct variable to check if localClusterAuthEndpoint avail
I saw this while fixing another issue, if initialized to false we set the
`enableLocalClusterAuthEndpoint` variable as such but that did not propigate
back up the model when in the init lifecycle. Rather than check the model we
should check the local param so we don't run in to these out of sync issues.
2019-09-23 16:46:32 -07:00
Westly Wright cd25e2ebd8
check if cluster local auth endpoint from api is string or bool
Tweaking a change made in rancher/ui#3376 to account for both cases. the fix
added would allow the case when deploying from a template but would break for
nontemplate launches when the value would be a bool again. Added a type check to
handle both cases.

The real fix should be changing the types in the `listquestions` api
where the data is being pulled from. The root cause exists there where the type
`boolean` is saved as a string.

rancher/rancher#22972
2019-09-23 16:42:36 -07:00
Westly Wright 804ace7031
Merge pull request #3379 from westlywright/rke.templates
Cluster Template Revision Select Bug
2019-09-23 15:15:02 -07:00
Westly Wright 0f3f0daf67
Merge pull request #3376 from codyrancher/auth-endpoint
Use template value for localClusterAuthEndpoint
2019-09-23 14:48:49 -07:00
Westly Wright 63aef3fa30
change other occurrences of model.cluster.clusterTemplateRevisionId 2019-09-23 14:45:28 -07:00
Westly Wright 290a1f51f6
Attach correct value to be modified to cluster template id select
When consuming a cluster template selection of the template id from the drop
down didn't change the cluster template revision becuase the UI component was
using the readOnly value. Attached the selection to the correct value so the
action floats up (DDAU).

rancher/rancher#22977
2019-09-23 14:19:01 -07:00
Cody Jackson b8293d7546 Use template value for localClusterAuthEndpoint
When creating a cluster using a template localClusterAuthEndpoint was not
using the value provided by the template.  The component assumed that
localClusterAuthEndpoint was a boolean when it was in fact a string that
represented a boolean. To resolve this a string comparison needed to
be made.

rancher/rancher#22972
2019-09-20 14:59:56 -07:00
Cody Jackson 9c9b2160ab Make groups visible when editing cluster template
While editing a cluster template when the template was shared with a
group the group was not visible under the Share Template section. We
needed to ensure that the group was visible.

The reason that this was occuring was because we weren't fetching the
principal for the group because we were only fetching when the
userPrincipalId was present and not when the groupPrincipalId was
present.

rancher/rancher#22971
2019-09-20 13:45:02 -07:00
Vincent Fiduccia 9e0216a299
Merge pull request #3371 from loganhz/labels
Fix label missing issue
2019-09-19 11:52:05 -07:00
Vincent Fiduccia 5a96cda3fe
Merge pull request #3370 from codyrancher/editing-cluster-template
Making the cluster template revisionId saveable.
2019-09-19 11:51:28 -07:00
Cody Jackson 3370aa9ca0 Making the cluster template revisionId saveable.
When editing a cluster that was created with cluster template
the cluster template revision couldn't be saved.

The revisionId was stored as a component member variable instead
of as a part of the model. It needed to be stored as part of the
model in order for the NewOrEdit to see the changes and save
them. I went ahead and referenced the model directly everywhere
in the component and removed the component member variable.

rancher/rancher#22920
2019-09-19 11:47:48 -07:00
Vincent Fiduccia 5dac97299a
Only show disabled global catalogs on global level, gray out 2019-09-19 10:13:21 -07:00
loganhz 43e22b8fc8 Fix label missing issue 2019-09-20 00:23:09 +08:00
Vincent Fiduccia 466f699c9b
Regular rows for special catalogs 2019-09-19 04:31:50 -07:00
loganhz 37a9458a06 Add missing gce-pd fileds 2019-09-19 09:10:20 +08:00
n313893254 9226c5e983 Fix cannot edit v1.14 k8s EKS cluster
https://github.com/rancher/rancher/issues/22894
2019-09-17 11:06:10 +08:00
Cody Jackson df754f6f8f Display security options when editing GKE cluster
We want the user to be able to see the security options that were
selected even if they can't be edited when editing the cluster.

We had to extract and infer the selected options given the oauthScopes.
It would be better if our API could more closely reflect our fields.

rancher/rancher#19070
2019-09-16 16:13:45 -07:00
loganhz 9d2c9536a4 Support paging for events list
https://github.com/rancher/rancher/issues/22858
2019-09-14 23:26:28 +08:00
Vincent Fiduccia a7f8eabc1a
Merge pull request #3352 from codyrancher/master
Add more context to the title of deletion modals
2019-09-13 17:13:33 -07:00
Cody Jackson 2f990ced40 Add more context to the title of deletion modals
Adds the resource types "namespace", "cluster", "project" as
additional context to the titles of the respective deletion modals
in order to reduce the likelyhood of a user accidentally deleting
an unintented resource.

We changed the title from "Are you sure you want to delete" to
"Are you sure you want to delete the namespace:" with namespace
being bold. The same is true for cluster and project as well.

rancher/rancher#17619
2019-09-13 12:47:38 -07:00
loganhz 9f8acf0d39 Show Kubernetes events in UI 2019-09-12 14:44:30 +08:00
Vincent Fiduccia f935046709
No read-only role for clusters 2019-09-11 11:02:01 -07:00
loganhz 8a825860a1 Support search in apps and multi-cluster apps list page 2019-09-11 20:32:43 +08:00
Vincent Fiduccia 9621b09fb0
Don't overwrite cluster config with answers on edit (rancher/rancher#22085) 2019-09-11 01:55:41 -07:00
Vincent Fiduccia b169838925
Merge pull request #3338 from loganhz/bugs
[2.3]Bugs
2019-09-09 14:06:03 -07:00
loganhz d942a02495 Remove the tooltip when sharing template 2019-09-07 09:51:23 +08:00
Vincent Fiduccia 4820137ac2
Merge pull request #3334 from loganhz/registry
Strip off https:// for private registry
2019-09-06 18:46:22 -07:00
loganhz 326db19a55 Strip off https:// for private registry 2019-09-07 09:43:52 +08:00