It seems the previous way that the cluster id and project id was fetched from
various addons (alerts and istio) does not work in ember 3.12. After some
investigation it wasn't the corret way to grab those parameters anyway. I've
changed the routes to use the scope service which has the current cluster and
project (if in one) rather than fetch the query params off a parent route
outside the engine.
Remove ember object and use regular object instead
Found durning upgrade to 3.12, I'm not sure why we'd even need to declare an
ember object for this return anyway.
Get the current cluster's id from scope servervice
Found durning upgrade to 3.12, not sure how this ever worked as I looked on live
and it was failing but the system didn't explode on 3.8. In 3.12
transistion.params is undefined and the whole system explodes. We were never
passing the queryparams so they wouldn't have come through. I changed this so we
fetched the current cluster id from the scope service and everything seems to
work correctly.
Ensure that accordion items only try to expand once during the init
Found durning upgrade to 3.12, expanded was being double rendered.
lint fix
test fixes
lint
When adding the vitual services and destination rules are enabeld we were
showing the import yaml button twice. It needs to be visible on both tabs and we
should be able to pass the or to the rbac check so I removed the duplicates and
moved the button to before the potential other buttons in the istio nav.
rancher/rancher#23155
I commented out the destinationRules and virtualServices tabs from the
istio-project template, changed some verbiage in the remaining nav tabs, and
added to import yaml link to both tabs to make the ux a little less confusing.
In the next release this page will undergo a redesign so I did not remove the
code.
rancher/rancher#23108