I originally tried to fixrancher/rancher#24704 without completely
special casing. Unfortunately that lead to other issues:
rancher/rancher#24745rancher/rancher#24794rancher/rancher#24814
I decided to revert all of the related changes and to just special
case this one instance. Ultimately I think the removeEmpty is the
culprit but it requires backend changes in order to properly fix
and those changes are not happening right now.
We were erroneously adding cloud_provider.awsCloudProvider on
digital ocean etc due to rancher/rancher#24515.
This change assumes that the presence of
onfig.rancher_kubernetes_engine_config.cloud_provider.name
implies that the cloud_provider should be present. If that
nested field isn't present we remove cloud_provider.
rancher/rancher#24745
While working on a ticket to provide the ability to de-select subnetworks when
using the create subnetwork option I discovered the options were all messed up
and allowed you to misconfigure yourself into a hole.
I've moved ipalias and related networks settings out of advanced becuase
depending on what you select for your subnetwork the ability to choose ipalias
and the other settings changes.
This change allows you deselect a node subnet so you can create a subnetwork
automatically.
rancher/rancher#21079
After pressing the 'create' button of the EKS driver the user was being
transitioned back to step 3 (Vpc & Subnet) rather than waiting on the
final page until the save is complete and returning to the cluster page.
An observer was being triggered by the save process which subsequently
set the step back to 3. To resolve this we will only enter the branch if
there are initialized values that need to be set back to default.
rancher/rancher#23493
While editing a cluster properly support .x kube version comparisons when
filtering out cluster template revisions.
Coercing a .x version converts it to a .0 which made the revision look like
it was a kube downgrade. By making use of .satisfies when the revision
kube version ends with a '.x' we're now better able to check if the
kube version is a downgrade and filter appropriately.
rancher/rancher#23489
the check-override-allowed component did not know how to deal with the k8s
version question because of its tri state and how we deal with the patch version
that is an override but not really an override. I added a check to verify the
mode is view and we have the param then display param so we don't initialize the
form-version component which has logic to inject the current version into its
versions dropdown but only if we're new, editing, or cloning.
rancher/rancher#23478rancher/rancher#23465
The current kubernetes version wasn't being shown if it was no
longer a part of the supported versions when in view mode. Instead
the latest version was being displayed even if that wasn't what was
deployed. To resolve this we include the current version as one of
the choices if it's not present.
rancher/rancher#23465
- Moved from Ember.$() to importing jquery.
- Moved from fn().on() to on(fn())
- Moved from fn().observes() to observer(fn())
This got /g/clusters from 27 warnings to 5 warnings for me.
When cloning a RKE template revision with overrides the values of the override
in the form were not reflected in the overrides section at the bottom of the
page because the alias on the question was never created.
rancher/rancher#23056
`Custom Cluster Overrides` was originally designed when we allowed users to
create custom overrides for items not in the UI but since that was removed the
template consumer will only ever see overrides for sections we have built in
and when launching we never display the overrides for ones with UI components.
rancher/rancher#23069
When consuming a cluster template selection of the template id from the drop
down didn't change the cluster template revision becuase the UI component was
using the readOnly value. Attached the selection to the correct value so the
action floats up (DDAU).
rancher/rancher#22977
When editing a cluster that was created with cluster template
the cluster template revision couldn't be saved.
The revisionId was stored as a component member variable instead
of as a part of the model. It needed to be stored as part of the
model in order for the NewOrEdit to see the changes and save
them. I went ahead and referenced the model directly everywhere
in the component and removed the component member variable.
rancher/rancher#22920
We want the user to be able to see the security options that were
selected even if they can't be edited when editing the cluster.
We had to extract and infer the selected options given the oauthScopes.
It would be better if our API could more closely reflect our fields.
rancher/rancher#19070