Commit Graph

173 Commits

Author SHA1 Message Date
Westly Wright 0519376220
drop cluster validation into next block
This ensures that all changes to the cofig via yaml are applied before
validating the cluster params.

rancher/rancher#24971
2020-01-22 14:59:55 -07:00
Westly Wright 5d589a5bb9
Merge pull request #3705 from shanewxy/yaml-create
Fixed edit as yaml in cluster options stuck on "saving"
2020-01-14 09:18:39 -07:00
Westly Wright 0579c01111
expose kube version upgrade warning on apply cluster template.
rancher/rancher#24829
2020-01-13 13:30:07 -07:00
shanewxy dac4aabf43 Fixed edit as yaml in cluster options hang saving 2020-01-06 14:35:12 +08:00
Cody Jackson a2c2fde89f Making awsCloudProvider a special case
I originally tried to fix rancher/rancher#24704 without completely
special casing. Unfortunately that lead to other issues:
rancher/rancher#24745
rancher/rancher#24794
rancher/rancher#24814

I decided to revert all of the related changes and to just special
case this one instance. Ultimately I think the removeEmpty is the
culprit but it requires backend changes in order to properly fix
and those changes are not happening right now.
2020-01-02 13:46:15 -07:00
Cody Jackson 9c30e3ac15 The great reversion of awsCloudProvider changes 2020-01-02 10:21:08 -07:00
Westly Wright 51dea873b8
add extra conditional for cloud config edit as yaml
rancher/rancher#24745
2019-12-30 16:18:40 -07:00
Westly Wright 1d934e0cac On create cpConfig is empty so we need to check that
rancher/rancher#24749
2019-12-27 10:45:52 -08:00
Cody Jackson fd4f567d09 Remove cloud_provider if it's not intended
We were erroneously adding cloud_provider.awsCloudProvider on
digital ocean etc due to rancher/rancher#24515.

This change assumes that the presence of
onfig.rancher_kubernetes_engine_config.cloud_provider.name
implies that the cloud_provider should be present. If that
nested field isn't present we remove cloud_provider.

rancher/rancher#24745
2019-12-23 15:51:02 -07:00
Cody Jackson 2bbe8035b0 Ensure awsCloudProvider presense for custom clusterawsCloudProvider was being removed from custom clusters when editingthe YAML. This change ensures that the field is still present. It alsorequired modifying the removeEmpty method as it was removing fields thatwere in the excludedKeys argument.rancher/rancher#24515 2019-12-12 16:21:52 -07:00
Cody Jackson 0fe6c33eb5 Improve kube version inspection on cluster edit
While editing a cluster properly support .x kube version comparisons when
filtering out cluster template revisions.

Coercing a .x version converts it to a .0 which made the revision look like
it was a kube downgrade. By making use of .satisfies when the revision
kube version ends with a '.x' we're now better able to check if the
kube version is a downgrade and filter appropriately.

rancher/rancher#23489
2019-10-21 12:21:09 -07:00
Westly Wright d711b8b8bb
disp k8s ver correctly when editing cluster or clone rev
the check-override-allowed component did not know how to deal with the k8s
version question because of its tri state and how we deal with the patch version
that is an override but not really an override. I added a check to verify the
mode is view and we have the param then display param so we don't initialize the
form-version component which has logic to inject the current version into its
versions dropdown but only if we're new, editing, or cloning.

rancher/rancher#23478
rancher/rancher#23465
2019-10-17 10:48:37 -07:00
Cody Jackson ef63c2a9c6 Ensure the current Kubernetes version can display
The current kubernetes version wasn't being shown if it was no
longer a part of the supported versions when in view mode. Instead
the latest version was being displayed even if that wasn't what was
deployed. To resolve this we include the current version as one of
the choices if it's not present.

rancher/rancher#23465
2019-10-15 17:56:14 -07:00
Westly Wright 521ed6ca09
wireup ovveride row value to form value when cloning rke template
When cloning a RKE template revision with overrides the values of the override
in the form were not reflected in the overrides section at the bottom of the
page because the alias on the question was never created.

rancher/rancher#23056
2019-09-25 13:11:51 -07:00
Cody Jackson 3370aa9ca0 Making the cluster template revisionId saveable.
When editing a cluster that was created with cluster template
the cluster template revision couldn't be saved.

The revisionId was stored as a component member variable instead
of as a part of the model. It needed to be stored as part of the
model in order for the NewOrEdit to see the changes and save
them. I went ahead and referenced the model directly everywhere
in the component and removed the component member variable.

rancher/rancher#22920
2019-09-19 11:47:48 -07:00
Vincent Fiduccia 9621b09fb0
Don't overwrite cluster config with answers on edit (rancher/rancher#22085) 2019-09-11 01:55:41 -07:00
Vincent Fiduccia 01b07bdd9a
Fix azure required fields, rke templates option location 2019-08-30 17:49:20 -07:00
lvuch 59d3ffb8d4 cluster template to rke template 2019-08-29 21:31:20 -07:00
n313893254 ef6ac0189a Fix [Windows] Unable to set windows node advanced options
https://github.com/rancher/rancher/issues/22059
2019-08-22 13:45:31 +08:00
Vincent Fiduccia cf1195575b
Clear errors on click (rancher/rancher#22228) 2019-08-19 12:14:16 -07:00
Vincent Fiduccia b14c6501a6
Don't submit if there are errors 2019-08-15 17:24:39 -07:00
Vincent Fiduccia 440c9d1627
Missing RKE config error 2019-08-14 00:03:30 -07:00
Vincent Fiduccia d39b00ee22
Cluster template bugs 2019-08-13 17:28:17 -07:00
Westly Wright 8001f80119
lint 2019-08-09 16:12:04 -07:00
Westly Wright 989be5923e
Add check for rke config in yaml editor and error if it nil
rancher/rancher#22076
2019-08-09 16:03:00 -07:00
Westly Wright 9c81011e0b
fix edit bug when saving from yaml 2019-08-09 09:12:07 -07:00
Westly Wright 636aee8d1a
add back yaml view but make readOnly if view 2019-08-09 09:12:07 -07:00
Westly Wright 107e86ad12
Cluster template revision detail page
rancher/rancher#23734
2019-08-09 09:11:53 -07:00
Westly Wright 705a863c58
Fix private registry display and default issues
rancher/rancher#21567
2019-08-07 14:48:06 -07:00
Westly Wright 2bc2981321
Fix .x version being pushed into list on edit cluster
rancher/rancher#22021
2019-08-07 12:07:53 -07:00
Westly Wright 8449a6f5b1
Prevent selecting ct with lower kube version than current cluster
rancher/rancher#21756
rancher/rancher#22018
2019-08-07 10:57:51 -07:00
Westly Wright 814a04bdce
allow k8s version to check if editing only when using cluster templ 2019-08-07 09:29:43 -07:00
Westly Wright c44e9ca6e6
Add date created & default label to the cluster temp revision select 2019-08-07 09:29:43 -07:00
Westly Wright 62e7865568
mark cloud provider fields that are required as required in override
which can't be unchecked because the config will require an entry

rancher/rancher#21616
2019-08-07 09:29:43 -07:00
Westly Wright 80fc4b6efb
Fix issue when edit cluster and no access to cluster template
rancher/rancher#21473
2019-08-07 09:29:43 -07:00
Westly Wright 464acc4648
refactor new required error check into own function 2019-08-02 14:41:34 -07:00
Westly Wright 4b9fa17425
split cluster template/revisions into sep dropdowns cluster create
rancher/rancher#21891
2019-08-02 13:48:14 -07:00
Westly Wright c4392a5ef9
allow users to create cluster template with azure fields empty
rancher/rancher#21759
2019-08-02 11:53:52 -07:00
Westly Wright 461700a2a9
fix cluster/cluster template validation
rancher/rancher#21616
2019-08-02 11:53:52 -07:00
loganhz 73336b817f Use windowsPreferedCluster for windows cluster 2019-08-02 06:20:26 +08:00
Westly Wright d688b427ff
hide edit yaml when a cluster template revision is selected 2019-07-31 15:11:58 -07:00
Westly Wright 53a31f7a3d
fix bug applying default values of cluster template kube version
rancher/rancher#21721
2019-07-31 15:11:58 -07:00
Westly Wright 9fa2f1d116
backup strategy default values when applying cluster template
rancher/rancher#21724
2019-07-31 09:42:00 -07:00
Westly Wright e6a80707b4
fix bug in template enforcement and standard user template selct
rancher/rancher#21747
2019-07-31 09:41:59 -07:00
Westly Wright ce42f8c0c2
Fix bug where uiOverride questions were showing up on new revision
rancher/rancher#21758
2019-07-30 09:26:21 -07:00
Westly Wright 654d125b17
fix incorrect version selection bug with patch version selection
rancher/rancher#21715
rancher/rancher#21721
2019-07-30 09:26:21 -07:00
Westly Wright 507a5b21fb
Remove patched kube version display on cluster create
rancher/rancher#21615
2019-07-30 09:26:21 -07:00
Westly Wright 72153bda97
lint 2019-07-29 09:58:13 -07:00
Westly Wright 97992bbc36
edit yaml working 2019-07-29 09:49:02 -07:00
Westly Wright 04a0eaf783
more refactoring to get switch between yml/form 2019-07-29 09:49:02 -07:00