From f7ffdea3b1b9574a9c79dc0601f2d5363ea43ca3 Mon Sep 17 00:00:00 2001 From: Ryan Turner Date: Tue, 12 Jan 2021 20:31:26 -0800 Subject: [PATCH] Remove separator argument from toSetOfSpiffeIds() examples The ',' separator is not accepted as valid by the library. There is now an override method which uses a default separator, so prefer that for the examples, where the separator character is not particularly relevant. Signed-off-by: Ryan Turner --- java-spiffe-provider/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/java-spiffe-provider/README.md b/java-spiffe-provider/README.md index 300f67a..2bd12d8 100644 --- a/java-spiffe-provider/README.md +++ b/java-spiffe-provider/README.md @@ -190,7 +190,7 @@ with a [X509Source instance](../java-spiffe-core/README.md#x509-source). KeyManager keyManager = new SpiffeKeyManager(x509Source); // TrustManager gets the X509Source and the supplier of the Set of accepted SPIFFE IDs. - TrustManager trustManager = new SpiffeTrustManager(x509Source, () -> SpiffeIdUtils.toSetOfSpiffeIds("spiffe://example.org/workload-client", ',')); + TrustManager trustManager = new SpiffeTrustManager(x509Source, () -> SpiffeIdUtils.toSetOfSpiffeIds("spiffe://example.org/workload-client")); SslContextBuilder sslContextBuilder = SslContextBuilder @@ -213,7 +213,7 @@ the GRPC SSL context, analogous to the config for the Server: KeyManager keyManager = new SpiffeKeyManager(x509Source); - Supplier> acceptedSpiffeIds = () -> SpiffeIdUtils.toSetOfSpiffeIds("spiffe://example.org/workload-server", ','); + Supplier> acceptedSpiffeIds = () -> SpiffeIdUtils.toSetOfSpiffeIds("spiffe://example.org/workload-server"); TrustManager trustManager = new SpiffeTrustManager(x509Source, acceptedSpiffeIds); SslContextBuilder sslContextBuilder = SslContextBuilder