tikv
/
client-go
mirror of https://github.com/tikv/client-go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

do not cache snapshot with version maxuint64 (#1320) 

Signed-off-by: you06 <you1474600@gmail.com>
This commit is contained in:
you06 2024-04-24 14:23:42 +09:00 committed by GitHub
parent edba2544d5
commit 0229f4077f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
integration_tests/snapshot_test.go
View File

@ -47,6 +47,7 @@ import (
"github.com/pkg/errors"
"github.com/stretchr/testify/suite"
"github.com/tikv/client-go/v2/error"
"github.com/tikv/client-go/v2/oracle"
"github.com/tikv/client-go/v2/tikv"
"github.com/tikv/client-go/v2/tikvrpc"
"github.com/tikv/client-go/v2/txnkv"
@ -395,3 +396,27 @@ func (s *testSnapshotSuite) TestRCRead() {
s.deleteKeys(keys)
}
}
func (s *testSnapshotSuite) TestSnapshotCacheBypassMaxUint64() {
txn := s.beginTxn()
s.Nil(txn.Set([]byte("x"), []byte("x")))
s.Nil(txn.Set([]byte("y"), []byte("y")))
s.Nil(txn.Set([]byte("z"), []byte("z")))
s.Nil(txn.Commit(context.Background()))
// cache version < math.MaxUint64
startTS, err := s.store.GetTimestampWithRetry(tikv.NewNoopBackoff(context.Background()), oracle.GlobalTxnScope)
s.Nil(err)
snapshot := s.store.GetSnapshot(startTS)
snapshot.Get(context.Background(), []byte("x"))
snapshot.BatchGet(context.Background(), [][]byte{[]byte("y"), []byte("z")})
s.Equal(snapshot.SnapCache(), map[string][]byte{
"x": []byte("x"),
"y": []byte("y"),
"z": []byte("z"),
})
// not cache version == math.MaxUint64
snapshot = s.store.GetSnapshot(math.MaxUint64)
snapshot.Get(context.Background(), []byte("x"))
snapshot.BatchGet(context.Background(), [][]byte{[]byte("y"), []byte("z")})
s.Empty(snapshot.SnapCache())
}

5
txnkv/txnsnapshot/snapshot.go
View File

@ -1007,6 +1007,11 @@ func (s *KVSnapshot) SnapCache() map[string][]byte {
// UpdateSnapshotCache sets the values of cache, for further fast read with same keys.
func (s *KVSnapshot) UpdateSnapshotCache(keys [][]byte, m map[string][]byte) {
// s.version == math.MaxUint64 is used in special transaction, which always read the latest data.
// do not cache it to avoid anomaly.
if s.version == math.MaxUint64 {
return
}
s.mu.Lock()
defer s.mu.Unlock()
if s.mu.cached == nil {