tikv
/
client-go
mirror of https://github.com/tikv/client-go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix metrics error (#365) 

Signed-off-by: yisaer <disxiaofei@163.com>
This commit is contained in:
Song Gao 2021-11-02 20:05:33 +08:00 committed by GitHub
parent c0efee0618
commit b8cc5a319d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
internal/client/client.go
View File

@ -344,22 +344,23 @@ func (c *RPCClient) closeConns() {
var sendReqHistCache sync.Map
type sendReqHistCacheKey struct {
tp tikvrpc.CmdType
id uint64
tp tikvrpc.CmdType
id uint64
staleRad bool
}
func (c *RPCClient) updateTiKVSendReqHistogram(req *tikvrpc.Request, start time.Time) {
func (c *RPCClient) updateTiKVSendReqHistogram(req *tikvrpc.Request, start time.Time, staleRead bool) {
key := sendReqHistCacheKey{
req.Type,
req.Context.GetPeer().GetStoreId(),
staleRead,
}
v, ok := sendReqHistCache.Load(key)
if !ok {
reqType := req.Type.String()
storeID := strconv.FormatUint(req.Context.GetPeer().GetStoreId(), 10)
staleRead := strconv.FormatBool(req.StaleRead)
v = metrics.TiKVSendReqHistogram.WithLabelValues(reqType, storeID, staleRead)
v = metrics.TiKVSendReqHistogram.WithLabelValues(reqType, storeID, strconv.FormatBool(staleRead))
sendReqHistCache.Store(key, v)
}
@ -386,13 +387,14 @@ func (c *RPCClient) SendRequest(ctx context.Context, addr string, req *tikvrpc.R
}
start := time.Now()
staleRead := req.GetStaleRead()
defer func() {
stmtExec := ctx.Value(util.ExecDetailsKey)
if stmtExec != nil {
detail := stmtExec.(*util.ExecDetails)
atomic.AddInt64(&detail.WaitKVRespDuration, int64(time.Since(start)))
}
c.updateTiKVSendReqHistogram(req, start)
c.updateTiKVSendReqHistogram(req, start, staleRead)
}()
// TiDB RPC server supports batch RPC, but batch connection will send heart beat, It's not necessary since