Commit Graph

82 Commits

Author SHA1 Message Date
zyguan dbea404a84
avoid too frequent logs (#1100)
Signed-off-by: zyguan <zhongyangguan@gmail.com>
2024-01-02 14:52:58 +08:00
Smilencer 6ba909c4ad
config: enable user configuration for retry strategy. (#1055)
Signed-off-by: Smityz <smityz@qq.com>
Co-authored-by: disksing <i@disksing.com>
2023-11-14 14:54:10 +08:00
crazycs 476ea22ffb
fix request source tag unset (#1025)
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Co-authored-by: disksing <i@disksing.com>
2023-10-20 14:26:25 +08:00
lucasliang e70513e671
bugfix: fix invalid nil pointer when trying to record Store.SlownessStat. (#1017)
* bugfix: fix invalid nil pointer when trying to record Store.SlownessStat.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>

* Polish codes.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>

* Polish comments.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>

---------

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
2023-10-16 12:02:43 +08:00
buffer 4c2ae43454
dco (#988)
Signed-off-by: bufferflies <1045931706@qq.com>
2023-09-26 13:16:11 +08:00
zyguan 44b0cf7aba
do not try leader if it's unreachable (#971)
* do not try leader if it's unreachable

Signed-off-by: zyguan <zhongyangguan@gmail.com>

* fix the flaky test

Signed-off-by: zyguan <zhongyangguan@gmail.com>

---------

Signed-off-by: zyguan <zhongyangguan@gmail.com>
2023-09-25 11:25:02 +08:00
crazycs 39084386b3
*: configurable kv_read_timeout should not affect write request (#978)
* *: configurable kv_read_timeout should not affect write request

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* refine test

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* refine logic

Signed-off-by: crazycs520 <crazycs520@gmail.com>

---------

Signed-off-by: crazycs520 <crazycs520@gmail.com>
2023-09-18 11:17:51 +08:00
crazycs 342301689f
*: fix issue of configure kv timeout not work when disable batch client (#980)
* *: fix issue of configure kv timeout not work when disable batch client

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* refine test

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* address comment

Signed-off-by: crazycs520 <crazycs520@gmail.com>

---------

Signed-off-by: crazycs520 <crazycs520@gmail.com>
2023-09-15 23:49:42 +08:00
crazycs 001735b0b5
*: try follower when stale read request timeout (#969)
* fix stalre read retry logic when got timeout error

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* add test

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* refine

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* fix test

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* add log

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* add log

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* refine

Signed-off-by: crazycs520 <crazycs520@gmail.com>

---------

Signed-off-by: crazycs520 <crazycs520@gmail.com>
2023-09-15 12:53:37 +08:00
buffer 79843ce227
Merge branch 'master' into add_log 2023-09-12 20:24:24 +08:00
you06 fb8e4c0eac
add region cache state test & fix some issues of replica selector (#910) (#942)
* add region cache state test & fix some issues of replica selector (#910)

Signed-off-by: you06 <you1474600@gmail.com>

remove duplicate code

Signed-off-by: you06 <you1474600@gmail.com>

* remove comment

Signed-off-by: you06 <you1474600@gmail.com>

* lint

Signed-off-by: you06 <you1474600@gmail.com>

* fix flaky test

Signed-off-by: you06 <you1474600@gmail.com>

---------

Signed-off-by: you06 <you1474600@gmail.com>
2023-09-12 12:36:53 +08:00
bufferflies 3216af2cb1
add cancel reason
Signed-off-by: bufferflies <1045931706@qq.com>
2023-09-12 11:59:38 +08:00
you06 89493ff985
set the request source at the last section (#960)
Signed-off-by: you06 <you1474600@gmail.com>
2023-09-07 21:23:09 +08:00
buffer 5c9fcf3e85
metrics: add bucket version not match metrics (#957) 2023-08-30 04:09:50 -06:00
you06 295094e5b5
add retry info to request source (#953)
* add retry info to request source

Signed-off-by: you06 <you1474600@gmail.com>

* handle upper layer retry

Signed-off-by: you06 <you1474600@gmail.com>

* stabilize test

Signed-off-by: you06 <you1474600@gmail.com>

* retry in 3 dimension

Signed-off-by: you06 <you1474600@gmail.com>

* record and restore req.ReadType

Signed-off-by: you06 <you1474600@gmail.com>

---------

Signed-off-by: you06 <you1474600@gmail.com>
2023-08-29 08:28:46 +08:00
cfzjywxk fc88757771
log: group replica selector logging and split not leader errors (#929)
* group replica selector logging and split not leader errors

Signed-off-by: cfzjywxk <lsswxrxr@163.com>

* use atomic to read epoch

Signed-off-by: cfzjywxk <lsswxrxr@163.com>

---------

Signed-off-by: cfzjywxk <lsswxrxr@163.com>
2023-08-24 16:00:22 +08:00
buffer ff39b4af09
error: handle bucket version not match (#918) 2023-08-22 03:25:20 -06:00
you06 1ea3d66418
use leader read when `tryFollower` is fallback from `accessKnownLeader` (#952)
* fix tryFollower

Signed-off-by: you06 <you1474600@gmail.com>

* address comment

Signed-off-by: you06 <you1474600@gmail.com>

---------

Signed-off-by: you06 <you1474600@gmail.com>
2023-08-22 14:45:13 +08:00
you06 a0ac170698
handle mismatch peer id (#935)
Signed-off-by: you06 <you1474600@gmail.com>
2023-08-14 15:27:20 +08:00
you06 44f5025f5a
fallback to follower when leader is busy (#916) (#923)
* fallback to follower when leader is busy

Signed-off-by: you06 <you1474600@gmail.com>
Co-authored-by: cfzjywxk <cfzjywxk@gmail.com>
Co-authored-by: cfzjywxk <lsswxrxr@163.com>
2023-08-11 21:36:47 +08:00
crazycs 8a214402da
use tidb_kv_read_timeout as first kv request timeout (#919)
* support tidb_kv_read_timeout as first round kv request timeout

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* fix ci

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* fix ci

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* fix ci

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* fix ci

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* fix ci

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* update comment

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* refine test

Signed-off-by: crazycs520 <crazycs520@gmail.com>

---------

Signed-off-by: crazycs520 <crazycs520@gmail.com>
2023-08-11 11:37:10 +08:00
cfzjywxk a47e1c2537
Resume max retry time check for stale read retry with leader option(#903) (#911)
* Resume max retry time check for stale read retry with leader option

Signed-off-by: cfzjywxk <lsswxrxr@163.com>

* add cancel

Signed-off-by: cfzjywxk <lsswxrxr@163.com>

---------

Signed-off-by: cfzjywxk <lsswxrxr@163.com>
2023-08-07 14:41:06 +08:00
crazycs 719e6456f7
use context logger as much as possible (#908)
* use context logger as much as possible

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* refine

Signed-off-by: crazycs520 <crazycs520@gmail.com>

---------

Signed-off-by: crazycs520 <crazycs520@gmail.com>
2023-07-31 11:23:49 +08:00
crazycs 9f94221c2d
add more log for diagnose (#915)
* add more log for diagnose

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* fix

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* add more log for diagnose

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* add more log

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* address comment

Signed-off-by: crazycs520 <crazycs520@gmail.com>

---------

Signed-off-by: crazycs520 <crazycs520@gmail.com>
2023-07-28 20:35:05 +08:00
crazycs d880eca9e1
fix unexpected slow query during GC running after stop 1 tikv-server (#899) (#909)
* fix unexpected slow query during GC running after stop 1 tikv-server

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* fix test

Signed-off-by: crazycs520 <crazycs520@gmail.com>

---------

Signed-off-by: crazycs520 <crazycs520@gmail.com>
2023-07-26 13:57:33 +08:00
you06 85fc8f3375
reload region cache when store is resolved from invalid status (#843)
Signed-off-by: you06 <you1474600@gmail.com>
Co-authored-by: disksing <i@disksing.com>
2023-07-14 13:27:14 +08:00
crazycs 4ec212d5f2
*: fix stale read ops metric (#878) (#889)
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Co-authored-by: disksing <i@disksing.com>
2023-07-14 11:03:10 +08:00
crazycs fbec023060
*: refine non-global stale-read request retry logic (#863)
Signed-off-by: crazycs520 <crazycs520@gmail.com>
2023-07-03 12:12:02 +08:00
you06 c946782286
Fallback to leader read when replica read meets flashback-in-progress error (#796)
* handle flashback error when follower read

Signed-off-by: you06 <you1474600@gmail.com>

* add test

Signed-off-by: you06 <you1474600@gmail.com>

* trigger CI

Signed-off-by: you06 <you1474600@gmail.com>

* fix panic

Signed-off-by: you06 <you1474600@gmail.com>

* trigger CI

Signed-off-by: you06 <you1474600@gmail.com>

* trigger CI

Signed-off-by: you06 <you1474600@gmail.com>

---------

Signed-off-by: you06 <you1474600@gmail.com>
2023-05-11 13:49:08 +08:00
you06 c619a50474
add metrics for stale-read traffic (#776)
Signed-off-by: you06 <you1474600@gmail.com>
2023-04-27 14:55:46 +08:00
MyonKeminta 2be71b35ee
Add afterSendReqToRegion failpoint (#780)
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
2023-04-26 15:50:11 +08:00
Artem Danilov 415713766f
avoid dataIsNotReady error while retrying stale read on the leader (#765)
* avoid dataIsNotReady error while retrying stale read on the leader

Signed-off-by: artem_danilov <artem_danilov@airbnb.com>

* move StaleRead flag reset to retry section

Signed-off-by: artem_danilov <artem_danilov@airbnb.com>

* move all logic to #next and allow retry on the leader

Signed-off-by: artem_danilov <artem_danilov@airbnb.com>

---------

Signed-off-by: artem_danilov <artem_danilov@airbnb.com>
Co-authored-by: artem_danilov <artem_danilov@airbnb.com>
2023-04-19 10:48:52 +08:00
ekexium f3e87039d8
Finer `is_retry_request` settings (#763)
* set is_retry_request only for requests that is possible to have undetermined errors

Signed-off-by: ekexium <eke@fastmail.com>

* rename tryTimes to retryTimes

Signed-off-by: ekexium <eke@fastmail.com>

---------

Signed-off-by: ekexium <eke@fastmail.com>
Co-authored-by: cfzjywxk <lsswxrxr@163.com>
2023-04-10 10:39:43 +08:00
Daniël van Eeden f7e35b25be
Log request info for label warning (#744)
Signed-off-by: Daniël van Eeden <git@myname.nl>
Co-authored-by: disksing <i@disksing.com>
2023-03-27 14:51:16 +08:00
you06 884a634378
compatible batch copr with load-based replica read (#739)
* compatible batch copr with load-based replica read

Signed-off-by: you06 <you1474600@gmail.com>

* handle batch cop when server is busy

Signed-off-by: you06 <you1474600@gmail.com>

debug

Signed-off-by: you06 <you1474600@gmail.com>

debug

Signed-off-by: you06 <you1474600@gmail.com>

debug

Signed-off-by: you06 <you1474600@gmail.com>

remove debug

Signed-off-by: you06 <you1474600@gmail.com>

* address comment

Signed-off-by: you06 <you1474600@gmail.com>

* ci

Signed-off-by: you06 <you1474600@gmail.com>

* ci

Signed-off-by: you06 <you1474600@gmail.com>

---------

Signed-off-by: you06 <you1474600@gmail.com>
2023-03-17 11:26:22 +08:00
Lucas a7e3df4ab1
[Metrics] Supply extra metrics to monitor the flows under `prefer-leader` mode. (#716)
Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
2023-03-13 18:08:39 +08:00
guo-shaoge bd24a9e443
Merge branch 'master' into support_engine_role 2023-03-07 15:47:49 +08:00
cfzjywxk bdd41058aa
metrics: seperate metrics with source scope for txn command (#723)
* seperate metrics with source scope

Signed-off-by: cfzjywxk <lsswxrxr@163.com>

* fix async pessimistic rollback

Signed-off-by: cfzjywxk <lsswxrxr@163.com>

* fix missing definition

Signed-off-by: cfzjywxk <lsswxrxr@163.com>

---------

Signed-off-by: cfzjywxk <lsswxrxr@163.com>
2023-03-06 22:12:45 +08:00
guo-shaoge 0d003d077b region_cache: support <engine_role, write> for disaggregated tiflash
Signed-off-by: guo-shaoge <shaoge1994@163.com>
2023-03-06 17:53:57 +08:00
Yongbo Jiang 3f7860f109
region_request: handle resource group error before Backoff (#719)
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Co-authored-by: disksing <i@disksing.com>
2023-03-02 13:40:57 +08:00
Yilin Chen a27994e5aa
Support load-based replica read (#675)
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
2023-02-22 15:35:43 +08:00
iosmanthus e0e6019f8a
attach keyspace_id to tikv/tiflash requests (#682) 2023-02-20 13:10:03 +08:00
JmPotato bdcfab8928
Consider the number of replicas when calculating RU (#684)
Signed-off-by: JmPotato <ghzpotato@gmail.com>
2023-02-08 22:56:14 +08:00
Lucas bce56a5831
ReadMode: introduce AutoFollowerRead mechanism by adding a new `ReadMode == PreferLeader` (#671)
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
2023-02-07 16:42:52 +08:00
Hangjie Mo 56c521f109
internal: update `FlashbackInProgress` error msg (#692)
Signed-off-by: Hangjie Mo <mohangjie1995@gmail.com>
2023-02-06 17:34:59 +08:00
Yang Zhang 1b1a805e61
Support learner replica read (#643)
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
2023-01-11 14:37:06 +08:00
Lucas c59833429b
Bug fix: fix the Round-Robin algorithm when "ReadMode == ReplicaReadMixed". (#663)
Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
2023-01-11 14:15:36 +08:00
David f313ddf58d
reformat codec and add keyspace support (#649)
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
2023-01-10 15:15:33 +08:00
Zwb c20405f345
support witness peers (#633)
Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>
2023-01-09 20:53:19 +08:00
guo-shaoge ffc2788663 region_cache: refine GetTiFlashComputeRPCContextByConsistentHash(for detect alive)
Signed-off-by: guo-shaoge <shaoge1994@163.com>
2022-12-17 16:41:11 +08:00