Fix health checking issue (#748)

Signed-off-by: shiyuhang <1136742008@qq.com>
This commit is contained in:
shi yuhang 2023-05-25 21:20:34 +08:00 committed by ti-chi-bot
parent 1417e52397
commit a7605a17be
3 changed files with 42 additions and 5 deletions

View File

@ -256,11 +256,8 @@ public class RegionManager {
if (!s.isReachable()) {
continue;
}
for (Metapb.StoreLabel label : s.getStore().getLabelsList()) {
if (label.getKey().equals(storeType.getLabelKey())
&& label.getValue().equals(storeType.getLabelValue())) {
tiflashStores.add(s);
}
if (s.isTiFlash()) {
tiflashStores.add(s);
}
}
// select a tiflash with Round-Robin strategy

View File

@ -20,17 +20,22 @@ import io.grpc.ManagedChannel;
import io.grpc.health.v1.HealthCheckRequest;
import io.grpc.health.v1.HealthCheckResponse;
import io.grpc.health.v1.HealthGrpc;
import io.grpc.stub.ClientCalls;
import java.util.LinkedList;
import java.util.List;
import java.util.concurrent.BlockingQueue;
import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.TimeUnit;
import java.util.function.Supplier;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.tikv.common.ReadOnlyPDClient;
import org.tikv.common.util.ChannelFactory;
import org.tikv.common.util.ConcreteBackOffer;
import org.tikv.kvproto.Metapb;
import org.tikv.kvproto.Mpp;
import org.tikv.kvproto.Mpp.IsAliveRequest;
import org.tikv.kvproto.TikvGrpc;
public class StoreHealthyChecker implements Runnable {
private static final Logger logger = LoggerFactory.getLogger(StoreHealthyChecker.class);
@ -75,6 +80,30 @@ public class StoreHealthyChecker implements Runnable {
private boolean checkStoreHealth(TiStore store) {
String addressStr = store.getStore().getAddress();
if (store.isTiFlash()) {
return checkTiFlashHealth(addressStr);
}
return checkTiKVHealth(addressStr);
}
private boolean checkTiFlashHealth(String addressStr) {
try {
ManagedChannel channel = channelFactory.getChannel(addressStr, pdClient.getHostMapping());
TikvGrpc.TikvBlockingStub stub =
TikvGrpc.newBlockingStub(channel).withDeadlineAfter(timeout, TimeUnit.MILLISECONDS);
Supplier<IsAliveRequest> factory = () -> Mpp.IsAliveRequest.newBuilder().build();
Mpp.IsAliveResponse resp =
ClientCalls.blockingUnaryCall(
stub.getChannel(), TikvGrpc.getIsAliveMethod(), stub.getCallOptions(), factory.get());
return resp != null && resp.getAvailable();
} catch (Exception e) {
logger.info(
"fail to check TiFlash health, regard as unhealthy. TiFlash address: " + addressStr, e);
return false;
}
}
private boolean checkTiKVHealth(String addressStr) {
try {
ManagedChannel channel = channelFactory.getChannel(addressStr, pdClient.getHostMapping());
HealthGrpc.HealthBlockingStub stub =
@ -83,6 +112,7 @@ public class StoreHealthyChecker implements Runnable {
HealthCheckResponse resp = stub.check(req);
return resp.getStatus() == HealthCheckResponse.ServingStatus.SERVING;
} catch (Exception e) {
logger.info("fail to check TiKV health, regard as unhealthy. TiKV address: " + addressStr, e);
return false;
}
}

View File

@ -105,4 +105,14 @@ public class TiStore implements Serializable {
public long getId() {
return this.store.getId();
}
public boolean isTiFlash() {
for (Metapb.StoreLabel label : store.getLabelsList()) {
if (label.getKey().equals(TiStoreType.TiFlash.getLabelKey())
&& label.getValue().equals(TiStoreType.TiFlash.getLabelValue())) {
return true;
}
}
return false;
}
}