From ef1678724fbe1e66b2dcc32685111f10ac07f279 Mon Sep 17 00:00:00 2001 From: iosmanthus Date: Mon, 28 Mar 2022 09:41:49 +0800 Subject: [PATCH] [close #572] misc: fix syntax issues in github issue/pr templates (#573) --- .github/ISSUE_TEMPLATE/bug_report.md | 2 +- .github/ISSUE_TEMPLATE/feature_request.md | 2 +- .github/pull_request_template.md | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 3a802039b3..c7cfb4221e 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -18,7 +18,7 @@ labels: type/bug ### 4. What did you expect to see? (Required) -### 5. What is your Java Client and TiKV version? (Required) +### 5. What are your Java Client and TiKV versions? (Required) - Client Java: - TiKV: diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index 1a780c11f4..6483859153 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -18,6 +18,6 @@ frustrated when [...] --> you've considered. --> **Teachability, Documentation, Adoption, Migration Strategy:** - diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 0335cfa2ce..8d824c518e 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,7 +8,7 @@ Issue Number: close #issue_number Problem Description: **TBD** -### What is changed and how it works? +### What is changed and how does it work? @@ -17,13 +17,13 @@ Problem Description: **TBD** - Has exported function/method change - Has exported variable/fields change -- Has interface methods change +- Has methods of interface change - Has persistent data change - No code ### Check List for Tests -This PR has been tested by the at least one of the following methods: +This PR has been tested by at least one of the following methods: - Unit test - Integration test - Manual test (add detailed scripts or steps below)