fix: prometheus feature flag fixup

Signed-off-by: John Lewis <github@jlewis.sh>
This commit is contained in:
John Lewis 2024-12-01 13:28:01 +01:00
parent 2d75f2da6f
commit 13aafc6625
3 changed files with 12 additions and 0 deletions

View File

@ -107,6 +107,7 @@ mod pd;
mod proto; mod proto;
mod region; mod region;
mod region_cache; mod region_cache;
#[cfg(feature = "prometheus")]
mod stats; mod stats;
mod store; mod store;
mod timestamp; mod timestamp;

View File

@ -20,6 +20,7 @@ use crate::proto::pdpb::{self};
use crate::region::RegionId; use crate::region::RegionId;
use crate::region::RegionWithLeader; use crate::region::RegionWithLeader;
use crate::region::StoreId; use crate::region::StoreId;
#[cfg(feature = "prometheus")]
use crate::stats::pd_stats; use crate::stats::pd_stats;
use crate::Error; use crate::Error;
use crate::Result; use crate::Result;
@ -75,15 +76,22 @@ impl<Cl> RetryClient<Cl> {
macro_rules! retry_core { macro_rules! retry_core {
($self: ident, $tag: literal, $call: expr) => {{ ($self: ident, $tag: literal, $call: expr) => {{
#[cfg(feature = "prometheus")]
let stats = pd_stats($tag); let stats = pd_stats($tag);
let mut last_err = Ok(()); let mut last_err = Ok(());
for _ in 0..LEADER_CHANGE_RETRY { for _ in 0..LEADER_CHANGE_RETRY {
let res = $call; let res = $call;
#[cfg(feature = "prometheus")]
match stats.done(res) { match stats.done(res) {
Ok(r) => return Ok(r), Ok(r) => return Ok(r),
Err(e) => last_err = Err(e), Err(e) => last_err = Err(e),
} }
#[cfg(not(feature = "prometheus"))]
match res {
Ok(r) => return Ok(r),
Err(e) => last_err = Err(e),
}
let mut reconnect_count = MAX_REQUEST_COUNT; let mut reconnect_count = MAX_REQUEST_COUNT;
while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await { while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await {

View File

@ -21,6 +21,7 @@ use crate::request::shard::HasNextBatch;
use crate::request::NextBatch; use crate::request::NextBatch;
use crate::request::Shardable; use crate::request::Shardable;
use crate::request::{KvRequest, StoreRequest}; use crate::request::{KvRequest, StoreRequest};
#[cfg(feature = "prometheus")]
use crate::stats::tikv_stats; use crate::stats::tikv_stats;
use crate::store::HasRegionError; use crate::store::HasRegionError;
use crate::store::HasRegionErrors; use crate::store::HasRegionErrors;
@ -60,6 +61,7 @@ impl<Req: KvRequest> Plan for Dispatch<Req> {
type Result = Req::Response; type Result = Req::Response;
async fn execute(&self) -> Result<Self::Result> { async fn execute(&self) -> Result<Self::Result> {
#[cfg(feature = "prometheus")]
let stats = tikv_stats(self.request.label()); let stats = tikv_stats(self.request.label());
let result = self let result = self
.kv_client .kv_client
@ -67,6 +69,7 @@ impl<Req: KvRequest> Plan for Dispatch<Req> {
.expect("Unreachable: kv_client has not been initialised in Dispatch") .expect("Unreachable: kv_client has not been initialised in Dispatch")
.dispatch(&self.request) .dispatch(&self.request)
.await; .await;
#[cfg(feature = "prometheus")]
let result = stats.done(result); let result = stats.done(result);
result.map(|r| { result.map(|r| {
*r.downcast() *r.downcast()