commit
3851972f0c
|
|
@ -74,7 +74,7 @@
|
|||
- [#586](https://github.com/volcano-sh/volcano/pull/586) dep ensure (@sivanzcw)
|
||||
- [#584](https://github.com/volcano-sh/volcano/pull/584) change node not found errors (@invalid-email-address)
|
||||
- [#581](https://github.com/volcano-sh/volcano/pull/581) Change Statement unevict method to call UpdateTask (@yodarshafrir1)
|
||||
- [#578](https://github.com/volcano-sh/volcano/pull/578) Add explict info about what todo to update generated yaml (@hzxuzhonghu)
|
||||
- [#578](https://github.com/volcano-sh/volcano/pull/578) Add explicit info about what todo to update generated yaml (@hzxuzhonghu)
|
||||
- [#577](https://github.com/volcano-sh/volcano/pull/577) Enable CI verify (@hzxuzhonghu)
|
||||
- [#576](https://github.com/volcano-sh/volcano/pull/576) Enable networkpolicy create/get permission (@hzxuzhonghu)
|
||||
- [#572](https://github.com/volcano-sh/volcano/pull/572) fix validate victims check for preempt action (@zionwu)
|
||||
|
|
|
|||
|
|
@ -111,7 +111,7 @@ The subject line should feature the what and the body of the commit should descr
|
|||
```
|
||||
scripts: add test codes for metamanager
|
||||
|
||||
this add some unit test codes to imporve code coverage for metamanager
|
||||
this add some unit test codes to improve code coverage for metamanager
|
||||
|
||||
Fixes #12
|
||||
```
|
||||
|
|
|
|||
|
|
@ -70,7 +70,7 @@ The similar Slurm command lines are listed below:
|
|||
| `vcctl queue list ` | `vqueues` |
|
||||
|
||||
#### `vsub` submit via file
|
||||
Command `vsub` can aslo submit a batch job via `.sh` file, like:
|
||||
Command `vsub` can also submit a batch job via `.sh` file, like:
|
||||
```shell
|
||||
[user@host]$ vsub test.sh
|
||||
Submitted batch job test
|
||||
|
|
|
|||
|
|
@ -1,6 +1,6 @@
|
|||
# FAQs
|
||||
|
||||
This page contains a few commonly occuring questions.
|
||||
This page contains a few commonly occurring questions.
|
||||
For further support please contact us using the [support page](../getting-started/support.md)
|
||||
|
||||
// TODO need to update
|
||||
|
|
@ -301,7 +301,7 @@ func TestJobCache_Update(t *testing.T) {
|
|||
if testcase.ExpectedErr == nil {
|
||||
job, err := jobCache.Get(fmt.Sprintf("%s/%s", testcase.UpdatedJob.Namespace, testcase.UpdatedJob.Name))
|
||||
if err != nil {
|
||||
t.Errorf("Expected Error not to have occured in case %d", i)
|
||||
t.Errorf("Expected Error not to have occurred in case %d", i)
|
||||
}
|
||||
if job.Job.Status.State.Phase != testcase.UpdatedJob.Status.State.Phase {
|
||||
t.Errorf("Error in updating Job, Expected: %s, but got: %s in case %d", testcase.UpdatedJob.Status.State.Phase, job.Job.Status.State.Phase, i)
|
||||
|
|
@ -382,7 +382,7 @@ func TestJobCache_Delete(t *testing.T) {
|
|||
if testcase.ExpectedErr == nil {
|
||||
job, err := jobCache.Get(fmt.Sprintf("%s/%s", testcase.DeleteJob.Namespace, testcase.DeleteJob.Name))
|
||||
if err == nil {
|
||||
t.Errorf("Expected Error to have occured in case %d", i)
|
||||
t.Errorf("Expected Error to have occurred in case %d", i)
|
||||
}
|
||||
if job != nil {
|
||||
t.Errorf("Expected Job to be nil but got value in case %d", i)
|
||||
|
|
@ -578,7 +578,7 @@ func TestJobCache_DeletePod(t *testing.T) {
|
|||
if err == nil {
|
||||
job, err := jobCache.Get(fmt.Sprintf("%s/%s", namespace, "job1"))
|
||||
if err != nil {
|
||||
t.Errorf("Expected Error not to have occured but got error: %s in case %d", err, i)
|
||||
t.Errorf("Expected Error not to have occurred but got error: %s in case %d", err, i)
|
||||
}
|
||||
if len(job.Pods["task1"]) != 1 {
|
||||
t.Errorf("Expected total pods to be 1, but got: %d in case %d", len(job.Pods["task1"]), i)
|
||||
|
|
@ -685,7 +685,7 @@ func TestJobCache_UpdatePod(t *testing.T) {
|
|||
if err == nil {
|
||||
job, err := jobCache.Get(fmt.Sprintf("%s/%s", namespace, "job1"))
|
||||
if err != nil {
|
||||
t.Errorf("Expected Error not to have occured but got error: %s in case %d", err, i)
|
||||
t.Errorf("Expected Error not to have occurred but got error: %s in case %d", err, i)
|
||||
}
|
||||
for _, task := range job.Pods {
|
||||
for _, pod := range task {
|
||||
|
|
|
|||
|
|
@ -110,7 +110,7 @@ func TestAddCommandFunc(t *testing.T) {
|
|||
ExpectValue int
|
||||
}{
|
||||
{
|
||||
Name: "AddCommand Sucess Case",
|
||||
Name: "AddCommand Success Case",
|
||||
command: &bus.Command{
|
||||
ObjectMeta: metav1.ObjectMeta{
|
||||
Name: "Valid Command",
|
||||
|
|
@ -517,7 +517,7 @@ func TestUpdatePodGroupFunc(t *testing.T) {
|
|||
ExpectValue int
|
||||
}{
|
||||
{
|
||||
Name: "AddCommand Sucess Case",
|
||||
Name: "AddCommand Success Case",
|
||||
oldPodGroup: &scheduling.PodGroup{
|
||||
ObjectMeta: metav1.ObjectMeta{
|
||||
Name: "pg1",
|
||||
|
|
|
|||
|
|
@ -173,7 +173,7 @@ func validateIO(volumes []batchv1alpha1.VolumeSpec) error {
|
|||
}
|
||||
if len(volume.VolumeClaimName) != 0 {
|
||||
if volume.VolumeClaim != nil {
|
||||
return fmt.Errorf("confilct: If you want to use an existing PVC, just specify VolumeClaimName." +
|
||||
return fmt.Errorf("conflict: If you want to use an existing PVC, just specify VolumeClaimName." +
|
||||
"If you want to create a new PVC, you do not need to specify VolumeClaimName")
|
||||
}
|
||||
if errMsgs := validation.ValidatePersistentVolumeName(volume.VolumeClaimName, false); len(errMsgs) > 0 {
|
||||
|
|
|
|||
Loading…
Reference in New Issue