volcano-sh
/
volcano
mirror of https://github.com/volcano-sh/volcano.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

golint: Add failure file 

Signed-off-by: Ce Gao <ce.gao@outlook.com>
This commit is contained in:
Ce Gao 2018-02-13 23:11:30 +08:00
parent 90e140882c
commit 90ff6961ca
2 changed files with 38 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
hack/.golint_failures Normal file
View File

@ -0,0 +1,35 @@
cmd/kube-batchd/app
cmd/kube-batchd/app/options
cmd/kube-quotalloc/app
cmd/kube-quotalloc/app/options
contrib/pkg/batch/apis/v1
contrib/pkg/batch/client
contrib/pkg/batch/client/informers/internalinterfaces
contrib/pkg/batch/controller
contrib/pkg/batch/controller/combosetresources
contrib/pkg/batch/controller/combosetresources/pod
contrib/pkg/batch/schedulercache
pkg/batchd/apis/v1
pkg/batchd/cache
pkg/batchd/client
pkg/batchd/client/clientset
pkg/batchd/client/clientset/scheme
pkg/batchd/client/clientset/typed/v1
pkg/batchd/client/informers/internalinterfaces
pkg/batchd/controller
pkg/batchd/policy
pkg/batchd/policy/drf
pkg/batchd/policy/util
pkg/quotalloc/apis/v1
pkg/quotalloc/cache
pkg/quotalloc/client
pkg/quotalloc/client/clientset
pkg/quotalloc/client/clientset/scheme
pkg/quotalloc/client/clientset/typed/v1
pkg/quotalloc/client/informers/internalinterfaces
pkg/quotalloc/controller
pkg/quotalloc/policy
pkg/quotalloc/policy/preemption
pkg/quotalloc/policy/proportion
pkg/quotalloc/policy/util
test/integration/framework

4
hack/verify-golint.sh
View File

@ -61,7 +61,7 @@ export IFS=$'\n'
# as the prefix, however if we run it outside it returns the full path of the file
# with a leading underscore. We'll need to support both scenarios for all_packages.
all_packages=(
$(go list -e ./... | egrep -v "/(third_party|vendor|staging/src/k8s.io/client-go/pkg|generated|clientset_generated)" | sed -e 's|^k8s.io/kubernetes/||' -e "s|^_${KUBE_ROOT}/\?||")
$(go list -e ./... | egrep -v "/(third_party|vendor|staging/src/k8s.io/client-go/pkg|generated|clientset_generated)" | sed -e 's|^github.com/kubernetes-incubator/kube-arbitrator/||' -e "s|^_${KUBE_ROOT}/\?||")
)
failing_packages=(
$(cat $failure_file)
@ -75,6 +75,8 @@ for p in "${all_packages[@]}"; do
# Packages with a corresponding foo_test package will make golint fail
# with a useless error. Just ignore that, see golang/lint#68.
failedLint=$(golint "$p"/*.go 2>/dev/null)
echo $p
echo $failedLint
array_contains "$p" "${failing_packages[@]}" && in_failing=$? || in_failing=$?
if [[ -n "${failedLint}" ]] && [[ "${in_failing}" -ne "0" ]]; then
errors+=( "${failedLint}" )