Commit Graph

4537 Commits

Author SHA1 Message Date
baude 1d36501f96 code cleanup
clean up code identified as problematic by golands inspection

Signed-off-by: baude <bbaude@redhat.com>
2019-07-08 09:18:11 -05:00
OpenShift Merge Robot f7407f2eb5
Merge pull request #3472 from haircommander/generate-volumes
generate kube with volumes
2019-07-04 22:22:07 +02:00
OpenShift Merge Robot 1fe2965e4f
Merge pull request #3495 from baude/golandcodecleanup
trivial cleanups from golang
2019-07-04 13:51:27 +02:00
OpenShift Merge Robot 1de81bc717
Merge pull request #3493 from baude/psnostore
ps should use nostore when possible
2019-07-04 10:16:27 +02:00
baude fec1de6ef4 trivial cleanups from golang
the results of a code cleanup performed by the goland IDE.

Signed-off-by: baude <bbaude@redhat.com>
2019-07-03 15:41:33 -05:00
baude 24e1eebde4 ps should use nostore when possible
when not using --size with ps, we do not need a store.  this should make
ps more effecient when the system is under heavy load.

also, prune unused ps functions as no longer needed.

Signed-off-by: baude <bbaude@redhat.com>
2019-07-03 13:21:58 -05:00
OpenShift Merge Robot f5593d305f
Merge pull request #3488 from marcov/ctr-or-pod-id
libpod: discerne partial IDs between containers and pods
2019-07-03 16:55:24 +02:00
OpenShift Merge Robot 0e8b66cc68
Merge pull request #3242 from adel-mamin/adel-mamin/install-md-update-for-manjaro
Updated install.md for Manjaro Linux
2019-07-03 16:39:18 +02:00
OpenShift Merge Robot 4712fe009a
Merge pull request #3486 from openSUSE/ocicni-bump
Vendor latest OCICNI version
2019-07-03 16:17:33 +02:00
OpenShift Merge Robot a22a32a0a5
Merge pull request #3437 from giuseppe/fix-nocgo
build: allow to build without cgo on RISC-V
2019-07-03 15:58:26 +02:00
OpenShift Merge Robot bf7d5a9ce8
Merge pull request #3483 from mheon/get_conmon_pid
Store and print PID of conmon
2019-07-03 12:45:48 +02:00
OpenShift Merge Robot 2fbf716632
Merge pull request #3484 from mheon/bump_readme
Bump current version in README
2019-07-03 12:11:33 +02:00
Marco Vedovati 64a91b09ae libpod: discerne partial IDs between containers and pods
When specifying a podman command with a partial ID, container and pod
commands matches respectively only containers or pods IDs in the BoltDB.

Fixes: #3487
Signed-off-by: Marco Vedovati <mvedovati@suse.com>
2019-07-03 11:57:45 +02:00
Adel Mamin ac72229afd Added instruction to enable the user namespaces permanenty in Manjaro
Signed-off-by: Adel Mamin <adel.mamin@exafore.com>
2019-07-03 12:38:35 +03:00
Adel Mamin 229c5d6bb2 Addressed code review comments
Signed-off-by: Adel Mamin <adel.mamin@exafore.com>
2019-07-03 12:38:35 +03:00
Adel Mamin 08bd05cf5c Updated install.md for Manjaro Linux
Signed-off-by: Adel Mamin <adel.mamin@exafore.com>
2019-07-03 12:38:35 +03:00
Sascha Grunert 143ed8b826
Vendor latest OCICNI version
This is needed for dual stack IPv6 support within CRI-O. Because the API
changed within OCICNI, we have to adapt the internal linux networking as
well.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
2019-07-03 11:35:44 +02:00
Matthew Heon 241c643e77 Bump current version in README
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-07-02 19:55:06 -04:00
OpenShift Merge Robot 23711589f0
Merge pull request #3479 from mheon/bump-1.4.4
Bump to v1.4.4
2019-07-03 01:46:09 +02:00
Matthew Heon 38c6199b80 Wipe PID and ConmonPID in state after container stops
Matches the behavior of Docker.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-07-02 19:10:51 -04:00
Matthew Heon a1bb1987cc Store Conmon's PID in our state and display in inspect
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-07-02 18:52:55 -04:00
OpenShift Merge Robot 93560ab6de
Merge pull request #3477 from ashley-cui/pauserootless
Fix rootless detection error for pause & unpause
2019-07-03 00:47:34 +02:00
OpenShift Merge Robot 3fa818a036
Merge pull request #3465 from baude/nostore
configure runtime without store
2019-07-03 00:37:31 +02:00
Peter Hunt aeabc45cce Improve parsing of mounts
Specifically, we were needlessly doing a double lookup to find which config mounts were user volumes. Improve this by refactoring a bit of code from inspect

Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-07-02 15:18:44 -04:00
Peter Hunt 341f5e22e5 Add test for generate kube with volumes
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-07-02 15:18:44 -04:00
Matthew Heon 7b0cdd8c16 Bump gitvalidation epoch
Signed-off-by: Matthew Heon <mheon@redhat.com>
2019-07-02 14:58:54 -04:00
Matthew Heon 4ced285857 Bump to v1.4.5-dev
Signed-off-by: Matthew Heon <mheon@redhat.com>
2019-07-02 14:58:54 -04:00
Matthew Heon b3f10c8be2 Bump to v1.4.4
Signed-off-by: Matthew Heon <mheon@redhat.com>
2019-07-02 14:58:50 -04:00
OpenShift Merge Robot 55e028a12e
Merge pull request #3461 from mheon/free_locks_on_fail
Ensure locks are freed when ctr/pod creation fails
2019-07-02 20:41:31 +02:00
Ashley Cui a704be59e5 Fix rootless detection error for pause & unpause
Previously, when pause & unpause were run on rootless, the error message that pause was unsupported for rootless was not being thrown. When running remote, even if remote host was root, unsupported rootless error was being thrown.

Now, the error shows up when appropriate.

Signed-off-by: Ashley Cui <ashleycui16@gmail.com>
2019-07-02 14:33:03 -04:00
Peter Hunt db2cc36033 Deduplicate volumes
for containers that share volumes, so the pod section doesn't list copies

Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-07-02 14:08:09 -04:00
OpenShift Merge Robot 26d02e9739
Merge pull request #3471 from giuseppe/small-fixes-cgroups
cgroups v2: fix cpu time
2019-07-02 19:48:20 +02:00
Matthew Heon fdd98d58b8 Fix release notes
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-07-02 12:52:23 -04:00
Matthew Heon e92de11a69 Ensure locks are freed when ctr/pod creation fails
If we don't do this, we can leak locks on every failure, and that
is very, very bad - can render Podman unusable without a 'system
renumber' being run.

Signed-off-by: Matthew Heon <mheon@redhat.com>
2019-07-02 12:51:39 -04:00
OpenShift Merge Robot 4d45d8020e
Merge pull request #3473 from mheon/release_notes_1.4.4
Update release notes for 1.4.4
2019-07-02 18:50:58 +02:00
Giuseppe Scrivano 473d060454
cirrus: add test for compiling without cgo
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-07-02 16:41:11 +02:00
Giuseppe Scrivano 827ac0859f
lock: new lock type "file"
it is a wrapper around containers/storage file locking.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-07-02 16:41:10 +02:00
Giuseppe Scrivano 82164a2e9e
runtime: allow to specify the lock mechanism
preparation for the next patch.  It currently supports only "shm".

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-07-02 16:41:10 +02:00
Giuseppe Scrivano 2341eaa6c1
lock: disable without cgo
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-07-02 16:41:04 +02:00
Giuseppe Scrivano 825506d8f8
spec: move cgo stuff to their own file
so it can build without cgo since seccomp requires it.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-07-02 16:41:03 +02:00
Giuseppe Scrivano 35ab2184a3
rootless: allow to build without cgo
unfortunately rootless won't work without cgo, as most of the
implementation is in C, but at least allow to build libpod.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-07-02 16:41:02 +02:00
Giuseppe Scrivano c81a8f2b6d
attach: move cgo bits to a different file
move the cgo bits to a separate file to allow building without cgo.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-07-02 16:41:02 +02:00
Giuseppe Scrivano 1e0d632785
vendor: update containers/psgo
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-07-02 16:40:41 +02:00
Matthew Heon 6b4bedec41 Update release notes for 1.4.4
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-07-02 09:44:14 -04:00
OpenShift Merge Robot 695aeac481
Merge pull request #3469 from rhatdan/vendor
Update to containers/storage v1.12.13
2019-07-02 15:24:02 +02:00
Giuseppe Scrivano 856780f552
stats: use runtime.NumCPU when percpu counters are not available
in the cgroup v2 implementation we don't have yet percpu times.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-07-02 14:14:18 +02:00
Giuseppe Scrivano 7423426f73
cgroups: fix times conversion
convert the time we read in microseconds to nanoseconds.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-07-02 12:59:26 +02:00
Peter Hunt aa9de67452 Pass along volumes to pod yaml
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-07-01 16:58:53 -04:00
OpenShift Merge Robot 3b9ce8a3ac
Merge pull request #3468 from giuseppe/fix-sudo-rootless
rootless: do not join namespace if it has already euid == 0
2019-07-01 22:57:37 +02:00
Daniel J Walsh 1ba0b86250
Update to containers/storage v1.12.13
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2019-07-01 16:54:11 -04:00