Commit Graph

22203 Commits

Author SHA1 Message Date
Urvashi Mohnani 71f6f50ee1 [CI:DOCS] Update kube docs
Update kube docs stating the support of moving to and from
k8s in podman and explicitly stating that we are not replicating
the kubectl cli.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2024-04-04 09:28:21 -04:00
openshift-merge-bot[bot] 6b9b85e011
Merge pull request #22175 from edsantiago/skip_if_no_slirp
systests: conditionalize slirp4netns tests
2024-04-03 13:32:19 +00:00
openshift-merge-bot[bot] 976640474b
Merge pull request #22167 from edsantiago/systest_instrument
CI: systests: instrument flaky tests
2024-04-03 12:37:18 +00:00
Ed Santiago d27313ad10 systests: conditionalize slirp4netns tests
As of podman 5.0, slirp4netns is a soft dependency. It might
not be installed on a host (and, in gating tests, is not).
Deal with it.

Use podman itself, not 'which', to tell us if slirp4netns
is available. We don't want to duplicate podman's path-check
logic. Since this check is expensive, cache the result.

(Change the has_pasta check similarly)

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-04-03 05:49:21 -06:00
Ed Santiago e697631af9 CI: systests: instrument flaky tests
Three infrequent flakes. Add debug code to help track
down if/when they happen again.

And, one of them, fix a logic bug that will save us 8-10s
on system tests runs.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-04-03 05:26:51 -06:00
openshift-merge-bot[bot] d55ea0edfc
Merge pull request #22153 from lsm5/packit-fedora-latest
[skip-ci] Packit: specify fedora-latest in propose-downstream
2024-04-03 11:20:19 +00:00
openshift-merge-bot[bot] d2f639f61f
Merge pull request #21620 from WesselAtWork/docs/s3fs
[CI:DOCS] s3fs volume mount docs
2024-04-03 11:14:48 +00:00
WesselAtWork d2143fac59 s3fs docs
Signed-off-by: WesselAtWork <115667066+WesselAtWork@users.noreply.github.com>
2024-04-03 10:18:49 +00:00
openshift-merge-bot[bot] d470e7ee7d
Merge pull request #22178 from dcermak/makefile_extra_build_tags
Inject additional build tags from the environment
2024-04-03 09:30:19 +00:00
openshift-merge-bot[bot] 3ab859be68
Merge pull request #22242 from ehelms/update-publishport-kube-doc
[CI:DOCS] Add note about host networking to Kube PublishPort option
2024-04-02 15:51:34 +00:00
Eric D. Helms d3927f9076 Add note about host networking to Kube PublishPort option
Signed-off-by: Eric D. Helms <ericdhelms@gmail.com>
2024-04-02 10:44:45 -04:00
Dan Čermák 1a99d87746
Inject additional build tags from the environment
This allows distros to easily add buildtags without patching the Makefile or
duplicating it in their build recipes

[NO NEW TESTS NEEDED]

Signed-off-by: Dan Čermák <dcermak@suse.com>
2024-04-02 14:48:52 +02:00
openshift-merge-bot[bot] e1f49529fa
Merge pull request #22229 from giuseppe/fix-idmap-existing-volume
libpod: use original IDs if idmap is provided
2024-04-01 19:08:29 +00:00
Giuseppe Scrivano d81319eb71
libpod: use original IDs if idmap is provided
if the volume is mounted with "idmap", there should not be any mapping
using the user namespace mappings since this is done at runtime using
the "idmap" kernel feature.

Closes: https://github.com/containers/podman/issues/22228

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2024-03-31 23:46:17 +02:00
openshift-merge-bot[bot] 45b809c063
Merge pull request #22201 from cgwalters/doc-man
docs/podman-login: Give an example of writing the persistent path
2024-03-29 11:16:19 +00:00
openshift-merge-bot[bot] fb046fc24a
Merge pull request #22202 from edsantiago/new-vms-pasta-0326
CI: Bump VMs to 2024-03-28
2024-03-28 21:01:04 +00:00
openshift-merge-bot[bot] 07a03c453b
Merge pull request #22205 from n1hility/fix-action
[CI:DOCS] Switch back to checking out the same branch the action script runs in
2024-03-28 19:07:33 +00:00
Jason T. Greene f3434298df Switch back to checking out the same branch the action script runs in
Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2024-03-28 13:30:03 -05:00
Colin Walters f7b9168649 docs/podman-login: Give an example of writing the persistent path
The way `podman login` works by default is fundamentally different
from `docker login` and this causes a lot of confusion, and I
have seen multiple bad suggestions for ways to address this
such as setting `XDG_RUNTIME_DIR`.

Let's document up front how to write to the persistent path.

Signed-off-by: Colin Walters <walters@verbum.org>
2024-03-28 13:04:47 -04:00
Ed Santiago aab4674feb CI: Bump VMs to 2024-03-28
Emergency update to get pasta 03-26. Also gives us crun 1.14.4.

One unexplained difference: fc39 and rawhide now create:

    /run/log/journal/SOMETHING/system.journal

...and the SOMETHING is o-rwx. This triggers journalctl to spit out a warning:

    Hint: You are currently not seeing messages from the system.
          Users in groups 'adm', 'systemd-journal', 'wheel' can see all messages.
          Pass -q to turn off this notice.

...which in turn causes ExitCleanly() to fail.

It is not clear who/what is creating this journal directory, or
why it allofasudden started just now. Workaround is to add -q
to journalctl in one test.

One more difference, another test now requires SYSLOG capability.

VM package info:
    https://github.com/containers/automation_images/pull/342

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-03-28 08:35:29 -06:00
openshift-merge-bot[bot] 8ec8214525
Merge pull request #22189 from containers/renovate/github.com-openshift-imagebuilder-1.x
fix(deps): update module github.com/openshift/imagebuilder to v1.2.7
2024-03-27 23:21:23 +00:00
openshift-merge-bot[bot] a1a5bd3bd5
Merge pull request #21493 from mporrato/fix-21211
kube play: always pull when both imagePullPolicy and tag are missing
2024-03-27 21:58:45 +00:00
renovate[bot] fc18dbad70
fix(deps): update module github.com/openshift/imagebuilder to v1.2.7
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-27 21:17:03 +00:00
openshift-merge-bot[bot] 71eef631c8
Merge pull request #22163 from baude/docker26
Fix reference to deprecated types.Info
2024-03-27 21:14:29 +00:00
openshift-merge-bot[bot] a77f705dcb
Merge pull request #21991 from l0rd/logformatter-for-win
CI: Run logformatter for podman_machine_windows_task
2024-03-27 13:48:58 +00:00
openshift-merge-bot[bot] f84a22cf3d
Merge pull request #22181 from baude/addmario
[CI:DOCS]Add Mario to reviewers list
2024-03-27 13:32:28 +00:00
Brent Baude ffb8b2dc36 Fix reference to deprecated types.Info
upstream docker folks deprecated types.Info in favor of system.Info.

fixes #22132 and #22117

Signed-off-by: Brent Baude <bbaude@redhat.com>
2024-03-27 08:17:10 -05:00
openshift-merge-bot[bot] 5758376705
Merge pull request #22182 from cfergeau/vfkit-debug
applehv: Print vfkit logs in --log-level debug
2024-03-27 13:13:15 +00:00
openshift-merge-bot[bot] c25d114e1b
Merge pull request #22136 from lsm5/packit-c10s
[skip-ci] Packit: Enable CentOS Stream 10 update job
2024-03-27 12:26:29 +00:00
Mario Loriedo c0e32e93c0 Use logformatter for podman_machine_windows_task
https://github.com/containers/podman/issues/21760

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2024-03-27 12:59:49 +01:00
Christophe Fergeau d305e70af8
applehv: Print vfkit logs in --log-level debug
There has been various issues with vfkit exiting with
"Error: vfkit exited unexpectedly with exit code 1"

Among other reasons, this can be caused by vfkit being
built without the com.apple.security.virtualization
entitlement, and this can also happen when running
vfkit.x86_64 on Apple silicon hardware.

At the moment, the vfkit logs are not available, so there is no easy way
to know what's happening. This PR redirects vfkit stdout/stderr to
podman's log when --log-level debug is used.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
2024-03-27 09:59:31 +01:00
Brent Baude 23bf357fc3 [CI:DOCS]Add Mario to reviewers list
Signed-off-by: Brent Baude <bbaude@redhat.com>
2024-03-26 15:59:31 -05:00
openshift-merge-bot[bot] 52a64aa9dc
Merge pull request #22073 from cevich/add_golang121_warning
[CI:BUILD] Add golang 1.21 update warning
2024-03-26 19:58:10 +00:00
openshift-merge-bot[bot] 73fdbf2fcc
Merge pull request #22180 from cevich/maintenance_ci_note
[CI:DOCS] Document CI-maintenance job addition
2024-03-26 19:47:09 +00:00
Chris Evich c8e1e0034a
[CI:DOCS] Document CI-maintenance job addition
This process is easy/quick to do but critically important.  It ensures
that CI will always remain available in the event a CVE (or otherwise)
backport is required.  These jobs are all actively monitored daily, and
their execution ensures the CI VM images are forever preserved.

Signed-off-by: Chris Evich <cevich@redhat.com>
2024-03-26 15:16:28 -04:00
Chris Evich 48b8d7f8be
Add golang 1.21 update warning
This is needed on the off-chance that some tool or a human suggests
updating the minimum version to 1.21 or later. Since doing so would
cause Fedora and Debian to start behaving differently WRT builds.

Signed-off-by: Chris Evich <cevich@redhat.com>
2024-03-26 14:40:57 -04:00
openshift-merge-bot[bot] 25ebf10967
Merge pull request #22177 from mheon/fix_22172
Add rootless network command to `podman info`
2024-03-26 17:15:53 +00:00
openshift-merge-bot[bot] 5c39ddca5d
Merge pull request #22140 from baude/hypervrmf
hyperv: fix machine rm -r
2024-03-26 14:03:24 +00:00
Matt Heon b56331cd2f Add rootless network command to `podman info`
Useful to tell whether containers are being made with pasta or
slirp4netns by default. Info is bloated enough already that I
don't really have concerns about shoving more into it.

Fixes #22172

Signed-off-by: Matt Heon <mheon@redhat.com>
2024-03-26 09:56:48 -04:00
openshift-merge-bot[bot] 83903eb107
Merge pull request #22160 from ubergeek42/fix-stderr-parsing
Properly parse stderr when updating container status
2024-03-26 13:08:22 +00:00
openshift-merge-bot[bot] ecdc3d255b
Merge pull request #22161 from baude/hypervrequireadmin
hyperv: error if not admin
2024-03-26 12:27:09 +00:00
openshift-merge-bot[bot] fdc4901e7d
Merge pull request #22154 from dfr/cgroups-unsupported
libpod: don't warn about cgroupsv1 on FreeBSD
2024-03-26 12:10:54 +00:00
openshift-merge-bot[bot] e64d81481d
Merge pull request #22124 from diplane/annotations
Add support for annotations
2024-03-25 18:37:24 +00:00
openshift-merge-bot[bot] 5f5cd60a89
Merge pull request #22106 from containers/renovate/common-image-and-storage-deps
fix(deps): update github.com/containers/common digest to bc5f97c
2024-03-25 18:29:11 +00:00
openshift-merge-bot[bot] 099978ebca
Merge pull request #22150 from n1hility/pref-builtin-ssh
Use built-in ssh impl for all non-pty operations
2024-03-25 18:18:11 +00:00
Doug Rabson 80e2bc6966 libpod: don't warn about cgroupsv1 on FreeBSD
This factors out the check for cgroupsv2 unified mode into a
platform-specific file and stops podman from generating a (harmless)
warning every time it is run on FreeBSD.

[NO NEW TESTS NEEDED]

Signed-off-by: Doug Rabson <dfr@rabson.org>
2024-03-25 17:02:03 +00:00
Brent Baude c62c74970f hyperv: error if not admin
creating vsocks in windows requires admin privileges.  there could be
some workarounds made in the future,but the general deal has
always been, you need to be admin.  lets enforce this with an error
until those work-arounds can be implemented.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2024-03-25 10:47:57 -05:00
Keith Johnson 83671f95d8 Properly parse stderr when updating container status
I believe the previous code meant to use cmd.Run instead of cmd.Start.
The issue is that cmd.Start returns before the command has finished
executing, so the conditional body checking for the stderr of the
command never gets executed.

Raise the cmd.Start up into it's own conditional, which is checking for
whether the process could be started. Then we consume stderr, check for
some specific strings in the output, and then finally continue on with
the rest of the code.

Signed-off-by: Keith Johnson <kj@ubergeek42.com>
2024-03-25 10:15:23 -04:00
Lokesh Mandvekar 492f0b7c5f
[skip-ci] Packit: specify fedora-latest in propose-downstream
The packit alias `fedora-latest` points to the latest branched version
(regardless if released or not).

So, this configuration should work without issues through Fedora 40
release and should account for all branches until Fedora 41 release.

Ref: https://packit.dev/docs/configuration#aliases

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2024-03-25 15:50:06 +05:30
Jason T. Greene 11415b3e74 Use built-in ssh impl for all non-pty operations
Windows is not guaranteed to have the SSH feature installed, so prefer the use
of the built-in ssh client for all operations other than podman machine ssh,
which requires terminal pty logic. This restores previous behavior in 4.x.

Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2024-03-24 21:25:22 -05:00