Commit Graph

1460 Commits

Author SHA1 Message Date
OpenShift Merge Robot d3b6dbe9c6 Merge pull request #839 from nalind/mediaType
manifests: set MediaType in OCI indexes
2021-11-30 09:50:21 +01:00
Nalin Dahyabhai 00d7471ea0 manifests: set MediaType in OCI manifests and indexes
In image-spec 1.0.2, the MediaType field is now available in OCI
manifest types, so set it.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2021-11-29 17:46:47 -05:00
OpenShift Merge Robot a0e946930f Merge pull request #838 from vrothberg/search-registry
libimage: search custom registries
2021-11-25 17:00:15 +01:00
Valentin Rothberg a5a6620b33 libimage: search custom registries
Add a new search option to specify custom search registries.
The search tests live in Podman and I currently do not have
enough cycles to add completely new ones to libimage.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-11-25 14:28:45 +01:00
OpenShift Merge Robot 3797867068 Merge pull request #837 from containers/dependabot/go_modules/github.com/containers/image/v5-5.17.0
build(deps): bump github.com/containers/image/v5 from 5.16.1 to 5.17.0
2021-11-23 13:33:32 +01:00
dependabot[bot] 88b90f03e9 build(deps): bump github.com/containers/image/v5 from 5.16.1 to 5.17.0
Bumps [github.com/containers/image/v5](https://github.com/containers/image) from 5.16.1 to 5.17.0.
- [Release notes](https://github.com/containers/image/releases)
- [Commits](https://github.com/containers/image/compare/v5.16.1...v5.17.0)

---
updated-dependencies:
- dependency-name: github.com/containers/image/v5
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-23 04:32:19 +00:00
OpenShift Merge Robot ebb58ce908 Merge pull request #836 from vrothberg/fix-podman-11964
libimage: enforce "latest" tag when looking up images
2021-11-22 22:33:30 +01:00
OpenShift Merge Robot a17d7ed71f Merge pull request #833 from vrothberg/compat-registry
containers.conf: add option to enforce docker.io for compat API
2021-11-22 21:40:31 +01:00
OpenShift Merge Robot 364d64a9e5 Merge pull request #835 from containers/dependabot/go_modules/github.com/opencontainers/selinux-1.10.0
build(deps): bump github.com/opencontainers/selinux from 1.9.1 to 1.10.0
2021-11-22 16:31:13 +01:00
Valentin Rothberg a5f253cddf libimage: enforce "latest" tag when looking up images
Make sure to enforce the "latest" tag when looking up images in the
local storage.  Also make sure that digested short-names are subject
to the extended digest lookups.

Context: containers/podman/issues/11964
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-11-22 15:19:38 +01:00
dependabot[bot] 9e25ba6639 build(deps): bump github.com/opencontainers/selinux from 1.9.1 to 1.10.0
Bumps [github.com/opencontainers/selinux](https://github.com/opencontainers/selinux) from 1.9.1 to 1.10.0.
- [Release notes](https://github.com/opencontainers/selinux/releases)
- [Commits](https://github.com/opencontainers/selinux/compare/v1.9.1...v1.10.0)

---
updated-dependencies:
- dependency-name: github.com/opencontainers/selinux
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-22 04:41:27 +00:00
OpenShift Merge Robot cb029bfcfd Merge pull request #834 from rhatdan/VENDOR
UPdate vendor of container/storage
2021-11-19 20:13:14 +01:00
Daniel J Walsh d22e5dc9b8 UPdate vendor of container/storage
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-11-19 14:00:52 -05:00
OpenShift Merge Robot 66978af931 Merge pull request #831 from jwhonce/issues/10974
Refactor report package to be more compatible
2021-11-19 19:39:14 +01:00
Jhon Honce 42e2188028 Refactor report package to be more compatible
* Add additional replacer for ('\', 'n') -> "\n"
* New type Formatter embeds Template and writer/tabwriter handling
* tabwriter.Init() is exposed to allow updating the tabwriter settings

Note: If template origin is OriginPodman or has "table" keyword prefix
output will be filtered through tabwriter. Otherwise, output will be
rendered using given writer.

Note: Once all podman commands have been updated a follow on PR will
remove the old report.Template and report.Writer code.

See https://github.com/containers/podman/issues/10974

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2021-11-19 11:11:07 -07:00
OpenShift Merge Robot aeadc7f2af Merge pull request #830 from rhatdan/network
Set netns to default to private like other namespaces
2021-11-19 17:34:16 +01:00
Valentin Rothberg c9748ff5ad containers.conf: add option to enforce docker.io for compat API
Add an option to containers.conf as a knob to enforce short-name
resolution to Docker Hub in Podman's compatibility REST API.

By popular request, turn it on by default.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-11-19 16:44:56 +01:00
OpenShift Merge Robot f414f13422 Merge pull request #832 from vrothberg/machine-vm-size
increase default machine vm size to 100GiB
2021-11-19 15:07:16 +01:00
Valentin Rothberg 1d98659f5a increase default machine vm size to 100GiB
Context: containers/podman/issues/11712
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-11-19 07:49:53 +01:00
Daniel J Walsh 4249000f56 Set netns to default to private like other namespaces
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-11-18 10:42:47 -05:00
OpenShift Merge Robot a382484ea2 Merge pull request #829 from containers/dependabot/go_modules/github.com/docker/docker-20.10.11incompatible
build(deps): bump github.com/docker/docker from 20.10.10+incompatible to 20.10.11+incompatible
2021-11-18 15:04:21 +01:00
dependabot[bot] 8731eab6db build(deps): bump github.com/docker/docker
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.10+incompatible to 20.10.11+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Changelog](https://github.com/moby/moby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/docker/docker/compare/v20.10.10...v20.10.11)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-18 04:38:04 +00:00
OpenShift Merge Robot 470e278dc7 Merge pull request #828 from rhatdan/tmpdir
Set the environment variables for the engine
2021-11-15 20:09:36 +01:00
Daniel J Walsh 6d6fe11781 Set the environment variables for the engine
The Engine.Env needs to be set very early in the setup process
to make sure no one attempts to use the environment.

Fixes: https://github.com/containers/podman/issues/12296

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-11-15 12:03:40 -05:00
OpenShift Merge Robot 8cc306d5df Merge pull request #827 from giuseppe/mount-add-idmap
parse: accept idmap
2021-11-15 16:27:40 +01:00
Giuseppe Scrivano 3d21449ece parse: accept idmap
needed by https://github.com/containers/podman/pull/12298

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2021-11-15 15:29:12 +01:00
OpenShift Merge Robot 9d88db151f Merge pull request #823 from edsantiago/helper_override
FindHelperBinary(): allow override via envariable
2021-11-11 22:39:42 +01:00
Ed Santiago c55ef5b984 FindHelperBinary(): allow override via envariable
When searching for helpers, check $CONTAINERS_HELPER_BINARY_DIR.
If it points at an existing directory, prepend it to the
search path for binaries.

Intention is to use this for developer testing: a way to run make
(e.g. in podman) then use the locally-built rootlessport and pause
images

Signed-off-by: Ed Santiago <santiago@redhat.com>
2021-11-11 12:26:38 -07:00
OpenShift Merge Robot 0cffd00486 Merge pull request #818 from nalind/manifest-variant
libimage/manifests.list.Add(): pull variant info from configs
2021-11-11 01:39:35 +01:00
OpenShift Merge Robot 01a7c761db Merge pull request #825 from vrothberg/download
pkg/download: for downloading files into tmp
2021-11-10 15:37:43 +01:00
Valentin Rothberg 8eb373cb0a pkg/download: for downloading files into tmp
cmd/podman needs that functionality as well, so I figured it makes sense
to break it into a separate package to reduce code clones.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-11-10 14:41:42 +01:00
OpenShift Merge Robot 10193d75ea Merge pull request #824 from mheon/add_backend_field
Add network_backend field for switching to netavark
2021-11-09 21:28:30 +01:00
Matthew Heon 8b1b879924 Add network_backend field for switching to netavark
This field determines whether CNI or netavark will be used to
create container networks. Default presently set to "cni".

Signed-off-by: Matthew Heon <mheon@redhat.com>
2021-11-09 13:45:56 -05:00
OpenShift Merge Robot 6a3445612b Merge pull request #821 from giuseppe/seccomp-errno-string
seccomp: accept strings for errno values
2021-11-09 19:29:30 +01:00
OpenShift Merge Robot 3c042d5cec Merge pull request #822 from vrothberg/healthcheck
libimage: inspect: extract healthchecks from configs
2021-11-09 14:19:27 +01:00
Valentin Rothberg 1b87e6d155 libimage: inspect: extract healthchecks from configs
buildkit is setting the health check in the image's config while Docker
and Podman set it in the image's container config.  Hence, if the
container config's healthcheck is nil, have a look at the config.

Fixes: #containers/podman/issues/12226
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-11-09 13:02:54 +01:00
Giuseppe Scrivano c0d068931f seccomp: accept strings for errno values
simplify maintainance of the seccomp.json file and accept errno as
strings.

It also fixes a portability problem since errno values are arch
dependent.

The existing `DefaultErrnoRet` and `ErrnoRet` are maintained for
backward compatibility but they are obsoleted and will be removed in a
future release.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2021-11-09 11:41:03 +01:00
Giuseppe Scrivano c2495428c7 seccomp: refactor code out
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2021-11-09 11:40:58 +01:00
OpenShift Merge Robot 86fc3c565d Merge pull request #819 from containers/dependabot/go_modules/github.com/onsi/gomega-1.17.0
build(deps): bump github.com/onsi/gomega from 1.16.0 to 1.17.0
2021-11-08 14:12:56 +01:00
dependabot[bot] f326557a68 build(deps): bump github.com/onsi/gomega from 1.16.0 to 1.17.0
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.16.0 to 1.17.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/gomega/compare/v1.16.0...v1.17.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-08 04:30:39 +00:00
Nalin Dahyabhai a248c4faa6 libimage/manifests.list.Add(): pull variant info from configs
When we're given an image reference to add to a manifest list, if we're
setting the instance info's architecture using information from the
image, set its variant field, too.  Likewise, if we're setting the OS
using information from the image, set the OS version and features
fields.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2021-11-04 14:51:14 -04:00
OpenShift Merge Robot b3d3d3aa60 Merge pull request #813 from jre21/helper_binaries_hint
Add a hint to resolve a misconfigured helper_binaries_dir
2021-10-30 15:33:43 +00:00
OpenShift Merge Robot 9861b3b61f Merge pull request #814 from vrothberg/flag-set
add pkg/flag from Skopeo
2021-10-26 13:08:26 +00:00
Valentin Rothberg 3fe70a8c82 add pkg/flag from Skopeo
Add pkg/flag to properly parse optional bools.  Skopeo is using this
code in `cmd/skopeo` for parsing the `--tls-verify` flag.  Moving the
code into a new package here allows for code share.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-10-26 14:36:11 +02:00
OpenShift Merge Robot 1ba0e2b653 Merge pull request #817 from containers/dependabot/go_modules/github.com/docker/docker-20.10.10incompatible
build(deps): bump github.com/docker/docker from 20.10.9+incompatible to 20.10.10+incompatible
2021-10-26 10:05:27 +00:00
dependabot[bot] ed4a258e9e build(deps): bump github.com/docker/docker
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.9+incompatible to 20.10.10+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Changelog](https://github.com/moby/moby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/docker/docker/compare/v20.10.9...v20.10.10)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-10-26 04:35:16 +00:00
Daniel J Walsh 9680fe7bf6 Update pkg/config/config.go
Co-authored-by: Valentin Rothberg <rothberg@redhat.com>
2021-10-25 12:36:34 -04:00
Jacob Emmert-Aronson 8d0bbae800 Add a hint for misconfigured helper_binaries_dir
Signed-off-by: Jacob Emmert-Aronson <jacob@roadnottaken2718.com>
2021-10-23 14:50:57 -07:00
OpenShift Merge Robot 39ced1efa2 Merge pull request #811 from vrothberg/fix-podman-11997
libimage: speed up image filters
2021-10-19 19:07:39 +00:00
Valentin Rothberg 7cd4a8a161 libimage: speed up image filters
With commit e983ccadc6 the dangling checks have been changed to be
compatible with Docker.  Since then, the dangling also need to compute
children.

Speed up the dangling and intermediate checks by computing the layer
tree *once* instead of for each filter invocation.

**Before:**
real    0m10.837s
user    0m11.308s
sys     0m4.231s

**After:**
real    0m0.476s
user    0m0.478s
sys     0m0.151s

Context: github.com/containers/podman/issues/11997
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-10-19 15:30:06 +02:00