Commit Graph

19097 Commits

Author SHA1 Message Date
OpenShift Merge Robot dd753c6f9a
Merge pull request #18795 from rhatdan/quadlet
Add support for SecurityLabelNested flag in quadlet
2023-06-07 07:16:09 -04:00
OpenShift Merge Robot 15fc6ec729
Merge pull request #18815 from containers/renovate/github.com-onsi-gomega-1.x
fix(deps): update module github.com/onsi/gomega to v1.27.8
2023-06-07 05:58:12 -04:00
OpenShift Merge Robot 82111af49a
Merge pull request #18801 from containers/renovate/github.com-burntsushi-toml-1.x
fix(deps): update module github.com/burntsushi/toml to v1.3.1
2023-06-07 04:53:16 -04:00
renovate[bot] 7bdbbd0cec
fix(deps): update module github.com/onsi/gomega to v1.27.8
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-06-07 07:49:45 +00:00
OpenShift Merge Robot 8e3ecc8936
Merge pull request #18772 from esendjer/main
fix ignition config creation (propagation of proxy settings)
2023-06-06 10:45:55 -04:00
Daniel J Walsh 3b79f241b1
Add support for SecurityLabelNested flag in quadlet
This flag will allow us to run nested containers within
a quadlet service.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-06-06 10:30:48 -04:00
OpenShift Merge Robot 6f38a72c2a
Merge pull request #18764 from containers/renovate/github.com-crc-org-vfkit-digest
fix(deps): update github.com/crc-org/vfkit digest to 3d57f09
2023-06-06 06:46:23 -04:00
renovate[bot] a1c1d8d0a7
fix(deps): update module github.com/burntsushi/toml to v1.3.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-06-06 10:45:12 +00:00
OpenShift Merge Robot 953eaffbf8
Merge pull request #18766 from containers/renovate/github.com-mattn-go-sqlite3-1.x
fix(deps): update module github.com/mattn/go-sqlite3 to v1.14.17
2023-06-06 06:43:46 -04:00
renovate[bot] 92309d917b
fix(deps): update module github.com/mattn/go-sqlite3 to v1.14.17
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-06-05 21:17:26 +00:00
OpenShift Merge Robot f84a2ff9f7
Merge pull request #18725 from fatelei/docs
[CI:DOCS] feat: add insecure registry troubleshooting solution
2023-06-05 16:03:18 -04:00
OpenShift Merge Robot eec15a108a
Merge pull request #18657 from arizvisa/GH-18120
Added the "--out" parameter and fixed an issue with "--noout" which prevented stdout from being written to.
2023-06-05 14:34:21 -04:00
OpenShift Merge Robot d669d948a3
Merge pull request #18788 from ygalblum/quadlet-pull
Quadlet - add support for Pull key in .container
2023-06-05 11:27:21 -04:00
esendjer 1ce53677aa fix ignition config creation
* the sequence of Ignition config creation was broken,
so that the part responsible for propagation of proxy
settings has been out of the final ignConfig

* e2e test for proxy settings propagation

Signed-off-by: esendjer <esendjer@gmail.com>
2023-06-05 18:03:14 +03:00
esendjer 4584350f6e Makefile binaries target adopted for Mac and Win
Signed-off-by: esendjer <esendjer@gmail.com>
2023-06-05 17:59:47 +03:00
OpenShift Merge Robot e143a0ff8e
Merge pull request #18774 from dgibson/bad-default-protocol
pasta: Correct handling of unknown protocols
2023-06-05 10:40:00 -04:00
OpenShift Merge Robot 18eb74fd4e
Merge pull request #18789 from edsantiago/logformatter_fix_h2
logformatter: proper status color for failed tests
2023-06-05 10:32:16 -04:00
OpenShift Merge Robot 99a8e9450f
Merge pull request #18733 from umohnani8/ulimit
Add default ulimit test for gen kube
2023-06-05 08:59:16 -04:00
renovate[bot] e93b1f9974
fix(deps): update github.com/crc-org/vfkit digest to 3d57f09
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-06-05 12:53:57 +00:00
Ed Santiago c51c6675ee logformatter: proper status color for failed tests
Fix an oops in my ginkgo-v2 handling: subtest-status was
getting re-reset back to "passed", resulting in incorrect
and misleading green titles on failed tests.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-06-05 05:59:11 -06:00
Stefano Brivio cf9bc25bbc pasta: Test handling of unknown protocols
Test that pasta generates a sensible error message if asked to forward a
protocol it doesn't understand.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2023-06-05 19:32:54 +10:00
OpenShift Merge Robot 6eb8157602
Merge pull request #18787 from containers/renovate/github.com-sirupsen-logrus-1.x
fix(deps): update module github.com/sirupsen/logrus to v1.9.3
2023-06-05 05:01:32 -04:00
David Gibson b2c0006706 pasta: Correct handling of unknown protocols
setupPasta() has logic to handle forwarding of TCP or UDP ports.  It has
what looks like logic to give an error if trying to forward ports of any
other protocol.  However, there's a straightforward error in this that it
will in fact only give the error if you try to use a protocol called
"default".  Other unknown protocols will fall through and result in a
nonsensical pasta command line which will almost certainly cause a cryptic
error later on.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2023-06-05 12:21:08 +10:00
Ygal Blum 6611735aeb Quadlet - add support for Pull key in .container
Update code, doc and test
Remove doc comment on pull policy

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2023-06-04 09:06:30 +03:00
renovate[bot] 5b629e9c4a
fix(deps): update module github.com/sirupsen/logrus to v1.9.3
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-06-03 22:41:38 +00:00
OpenShift Merge Robot aee7a3c16a
Merge pull request #18769 from edsantiago/getport_rewrite
e2e: GetPort(): safer allocation of random ports
2023-06-02 15:39:43 -04:00
Urvashi Mohnani d68121a609 Add default ulimit test for gen kube
Add a test for generate kube to verify that the ulimit
annotation is not set for the default case when the user
doesn't set any ulimits.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2023-06-02 11:19:59 +00:00
OpenShift Merge Robot 57797d8559
Merge pull request #18771 from containers/renovate/golang.org-x-tools-0.x
fix(deps): update module golang.org/x/tools to v0.9.3
2023-06-02 07:08:02 -04:00
OpenShift Merge Robot 1b7df2e99e
Merge pull request #18770 from containers/renovate/github.com-coreos-stream-metadata-go-0.x
fix(deps): update module github.com/coreos/stream-metadata-go to v0.4.2
2023-06-02 06:22:57 -04:00
fatelei 81d64547f1 feat: add insecure registry troubleshooting solution
Signed-off-by: fatelei <fatelei@gmail.com>
2023-06-02 14:50:13 +08:00
renovate[bot] 1768bf1509
fix(deps): update module golang.org/x/tools to v0.9.3
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-06-01 23:40:32 +00:00
renovate[bot] 7e550f78e1
fix(deps): update module github.com/coreos/stream-metadata-go to v0.4.2
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-06-01 22:09:12 +00:00
Ed Santiago 28934897e3 e2e: GetPort(): safer allocation of random ports
Intented to fix an obscure, unlikely race condition in which (I
think) two parallel jobs called GetPort() and were assigned the
same port.

Also, add actual proper testing to two HTTP-registry tests, and
Skip a third that's a waste of cycles (filed #18768)

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-06-01 16:04:34 -06:00
OpenShift Merge Robot a7e23d341d
Merge pull request #18756 from Luap99/tz
libpod: fix timezone handling
2023-06-01 14:16:20 -04:00
OpenShift Merge Robot e91f6f16bf
Merge pull request #15867 from boaz0/closes_15754
Fix: display online_cpus in compat REST API
2023-06-01 11:03:14 -04:00
OpenShift Merge Robot 50f934587f
Merge pull request #18758 from Luap99/systemd-restart
test/system: quadlet use correct systemd restart policy
2023-06-01 07:52:02 -04:00
OpenShift Merge Robot 511d668a33
Merge pull request #18765 from containers/renovate/github.com-godbus-dbus-v5-digest
fix(deps): update github.com/godbus/dbus/v5 digest to 7623695
2023-06-01 06:46:40 -04:00
OpenShift Merge Robot 2e2e009b1d
Merge pull request #18763 from containers/renovate/golang.org-x-tools-0.x
fix(deps): update module golang.org/x/tools to v0.9.2
2023-06-01 05:11:09 -04:00
Ed Santiago 543b809495
systests: fixes for coping with extra systemd image
We _usually_ have only one image in store, $IMAGE, but it's
perfectly fine to also have $SYSTEMD_IMAGE also. Fix a few
tests so they can handle that condition.

And, cleanup:
 - remove a no-longer-useful test ("podman load NEWNAME",
   functionality that was removed 2+ years ago in #8877)
 - reorder some tests in the image-mount test, to make
   them safer and easier to understand
 - use no-such-image, not no-such-container, in image-mount test.
   Computer don't care, but this human felt confused for a sec.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-06-01 11:04:31 +02:00
Paul Holzinger 34c258b419
libpod: fix timezone handling
The current way of bind mounting the host timezone file has problems.
Because /etc/localtime in the image may exist and is a symlink under
/usr/share/zoneinfo it will overwrite the targetfile. That confuses
timezone parses especially java where this approach does not work at
all. So we end up with an link which does not reflect the actual truth.

The better way is to just change the symlink in the image like it is
done on the host. However because not all images ship tzdata we cannot
rely on that either. So now we do both, when tzdata is installed then
use the symlink and if not we keep the current way of copying the host
timezone file in the container to /etc/localtime.

Also note that we need to rebuild the systemd image to include tzdata in
order to test this as our images do not contain the tzdata by default.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2149876

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-06-01 11:04:13 +02:00
renovate[bot] 22424eb5d7
fix(deps): update github.com/godbus/dbus/v5 digest to 7623695
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-06-01 03:15:04 +00:00
renovate[bot] 7987d2ee0a
fix(deps): update module golang.org/x/tools to v0.9.2
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-05-31 23:41:38 +00:00
OpenShift Merge Robot 249f0463eb
Merge pull request #18721 from Cydox/fix-ulimit-pr
fix ulimit issue
2023-05-31 16:53:49 -04:00
OpenShift Merge Robot 5543de25d5
Merge pull request #18747 from containers/renovate/github.com-onsi-ginkgo-v2-2.x
fix(deps): update module github.com/onsi/ginkgo/v2 to v2.9.6
2023-05-31 12:53:51 -04:00
Paul Holzinger 4173f942f1
test/system: quadlet use correct systemd restart policy
Systemd doesn't support `never` and logs a warning, systemd uses no as
default so we do not have to specify it at all.

Check systemd.service(5) for the systemd docs.

Fixes #18743

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-05-31 18:50:16 +02:00
OpenShift Merge Robot af5b1d6e80
Merge pull request #18643 from eriksjolund/use-imperative-form
man pages and command help: unify verb forms
2023-05-31 11:16:23 -04:00
OpenShift Merge Robot b9bdfea8e7
Merge pull request #18752 from edsantiago/log_k8s_race
systests: minimize race-condition window
2023-05-31 10:23:30 -04:00
OpenShift Merge Robot 0d7702bd93
Merge pull request #18744 from edsantiago/quadlet_race
systests: fix race in quadlet tests
2023-05-31 10:20:52 -04:00
OpenShift Merge Robot 19d39091b3
Merge pull request #18755 from edsantiago/dont_bg_run_podman
systests: fix improper backgrounding of run_podman
2023-05-31 10:13:08 -04:00
OpenShift Merge Robot 45e93014c5
Merge pull request #18730 from tmds/authfilepath_non_linux
[CI:DOCS] authfile.md: add default path of file for Windows/macOS.
2023-05-31 09:01:52 -04:00