Commit Graph

24441 Commits

Author SHA1 Message Date
Lokesh Mandvekar 1d220b99da
[skip-ci] RPM: cleanup macro defs
The default `gobuild` macro on CentOS Stream 9 now includes support for
`BUILDTAGS`.

CentOS Stream envs now also define `_user_tmpfilesdir` macro by default.
Both these definitions are no longer needed here.

`libtrust_openssl` buildtag is also set in spec wherever relevant.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2025-02-07 16:31:19 +05:30
openshift-merge-bot[bot] 2d42b13d55
Merge pull request #25221 from containers/renovate/golang.org-x-sync-0.x
fix(deps): update module golang.org/x/sync to v0.11.0
2025-02-05 12:21:29 +00:00
openshift-merge-bot[bot] 9cac0355f0
Merge pull request #25178 from lsm5/main-550-bump
Bump version to 5.5.0-dev
2025-02-05 11:54:08 +00:00
openshift-merge-bot[bot] 4bd6bc9f3c
Merge pull request #25191 from containers/renovate/github.com-shirou-gopsutil-v4-4.x
fix(deps): update module github.com/shirou/gopsutil/v4 to v4.25.1
2025-02-04 23:34:10 +00:00
openshift-merge-bot[bot] c05b82a52d
Merge pull request #25226 from containers/renovate/golang.org-x-term-0.x
fix(deps): update module golang.org/x/term to v0.29.0
2025-02-04 23:23:11 +00:00
renovate[bot] 165d5c3062
fix(deps): update module golang.org/x/sync to v0.11.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-02-04 23:03:27 +00:00
openshift-merge-bot[bot] 39becc2f05
Merge pull request #24781 from ashley-cui/builtfor
Add BuildOrigin field to podman info
2025-02-04 20:13:27 +00:00
renovate[bot] 03b9f87c7d
fix(deps): update module golang.org/x/term to v0.29.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-02-04 19:01:57 +00:00
openshift-merge-bot[bot] dc6fc24818
Merge pull request #25222 from containers/renovate/golang.org-x-sys-0.x
fix(deps): update module golang.org/x/sys to v0.30.0
2025-02-04 18:59:14 +00:00
renovate[bot] e7a0032ec3
fix(deps): update module golang.org/x/sys to v0.30.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-02-04 16:34:58 +00:00
openshift-merge-bot[bot] 16a72c839d
Merge pull request #25200 from Luap99/artifact-single-manifest
artifact: only allow single manifest
2025-02-04 16:33:21 +00:00
openshift-merge-bot[bot] 538a6a3560
Merge pull request #25216 from Honny1/fix-hc-pause-flake
Fix flake test: `podman pause/unpause with HealthCheck interval`
2025-02-04 15:21:54 +00:00
openshift-merge-bot[bot] 81431977e6
Merge pull request #25043 from jakecorrenti/machine-copy-files
Add `machine init --playbook`
2025-02-04 15:19:23 +00:00
Jan Rodák 52febf6a0a
Fix flake test: podman pause/unpause with HealthCheck interval
Checking of service and timer caused unexpected exit code `3` of `systemctl status`. Since the status check can be executed when HealthCheck was exited, this caused a termination error code `3` for `systemctl status`. Because service was in dead state because HealthCheck exited.

Fixes: https://github.com/containers/podman/issues/25204

Signed-off-by: Jan Rodák <hony.com@seznam.cz>
2025-02-04 15:46:52 +01:00
Lokesh Mandvekar ad0c092616
Bump version to 5.5.0-dev
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2025-02-04 19:36:39 +05:30
renovate[bot] 6f9fb4392c
fix(deps): update module github.com/shirou/gopsutil/v4 to v4.25.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-02-04 13:24:36 +00:00
openshift-merge-bot[bot] 1273a418b8
Merge pull request #25205 from baude/artifactnoheading
Add --noheading to artifact ls
2025-02-04 11:42:56 +00:00
Paul Holzinger 6c06577455
artifact: only allow single manifest
Allowing for multiple manifest per artifact just makes the code and cli
design harder to work with it. It is not clear how mounting, extracting
or edit on a multi manifest artifact should have worked.

A single manifest should make the code much easier to work with.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-02-04 12:17:24 +01:00
openshift-merge-bot[bot] 4b68b0f2a3
Merge pull request #25209 from Luap99/e2e-conf
test/e2e: improve write/removeConf()
2025-02-03 21:44:12 +00:00
Jake Correnti 297e8a3476 Add `machine init --playbook`
Allow the user to provide an Ansible playbook file on init which will
then be run on boot.

Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Signed-off-by: Brent Baude <bbaude@redhat.com>
2025-02-03 16:43:04 -05:00
openshift-merge-bot[bot] cd333458a8
Merge pull request #25190 from containers/renovate/golang.org-x-exp-digest
fix(deps): update golang.org/x/exp digest to e0ece0d
2025-02-03 21:33:15 +00:00
openshift-merge-bot[bot] c81625fd87
Merge pull request #25202 from l0rd/wsl-hardcode-network-config
Force use of iptables on Windows WSL
2025-02-03 20:40:56 +00:00
Paul Holzinger dcdf82e943
test/e2e: improve write/removeConf()
First use proper ginkgo error handling to ensure errors are actually
reported and fail the test. Mark it as helper function to have better
stack traces.

Then use a atomic write function to prevent issues with partial written
files. I think this is causing CI flakes[1].

Lastly fix the file permissions, do not make it world writable and do
not set the executable bit on the file.

[1] https://api.cirrus-ci.com/v1/artifact/task/5985244932734976/html/int-podman-fedora-41-root-host-sqlite.log.html#t--Podman-network-podman-network-ID-test--1

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-02-03 20:16:07 +01:00
openshift-merge-bot[bot] 61e36a3754
Merge pull request #25206 from Luap99/rpm-attr
rpm: add attr as dependency for podman-tests
2025-02-03 18:56:27 +00:00
openshift-merge-bot[bot] 3819dfb535
Merge pull request #25203 from Luap99/gvproxy-bump
update gvproxy version
2025-02-03 18:50:57 +00:00
openshift-merge-bot[bot] bd614324f9
Merge pull request #25207 from TomSweeneyRedHat/dev/tsweeney/buildah_1_39_0
Bump to Buildah v1.39.0
2025-02-03 18:45:27 +00:00
Brent Baude bc2763eac8 Add --noheading to artifact ls
like images and containers, it could be handy to have a --noheading
option that removes the headings on the output.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2025-02-03 10:50:46 -06:00
tomsweeneyredhat 35c72bb18e Bump to Buildah v1.39.0
Bump Buildah to v1.39.0 in the main branch.

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
2025-02-03 11:46:57 -05:00
Paul Holzinger 26b5864648
rpm: add attr as dependency for podman-tests
Since commit 06c103469d we are using getfattr in system tests, that
caused failures in gating tests[1] as getfattr was not installed. So add
attr as dependency.

[1] https://artifacts.dev.testing-farm.io/d93b6849-e526-46e9-a7c3-874bad4217a9/work-tests.yml8_p4nfkf/tests-n75vnz0u/test.podman-root.bats.log

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-02-03 17:41:35 +01:00
Paul Holzinger 89283c6fcc
update gvproxy version
The current macos installer gvproxy version has a number of issues
around dns handling[1,2]. They should be fixed now in 0.8.3 as they
reverted the dns changes back to the 0.7.5 code. This should make it
work like it used to be. Our 5.3.2 installer ships the 0.7.5 version so
users of the podman installer never noticed that but we got plenty of
reports from brew users. This needs to be backported into v5.4 to make
sure we do not ship the broken version as part of the installer.

[1] https://github.com/containers/gvisor-tap-vsock/issues/462
[2] https://github.com/containers/gvisor-tap-vsock/issues/466

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-02-03 15:54:34 +01:00
Mario Loriedo dae1541529 Force use of iptables on Windows WSL
This is a workaround for #25201 and helps with
upgrading the WSL image to Fedora 41.

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2025-02-03 14:39:47 +01:00
openshift-merge-bot[bot] e300f5caa1
Merge pull request #25188 from containers/renovate/github.com-vishvananda-netlink-digest
fix(deps): update github.com/vishvananda/netlink digest to 7c2350b
2025-02-03 12:07:43 +00:00
openshift-merge-bot[bot] e6a35234ce
Merge pull request #25186 from TomSweeneyRedHat/dev/tsweeney/common_0_62_0
Bump c/storage to v1.57.1, c/image v5.34.0, c/common v0.62.0
2025-02-03 10:19:43 +00:00
openshift-merge-bot[bot] 54fd9bcc51
Merge pull request #25181 from Luap99/new-images
new images 2025-01-31
2025-02-03 01:52:43 +00:00
openshift-merge-bot[bot] 7afb601bd8
Merge pull request #25180 from Luap99/local-exec-detach
podman exec: correctly support detaching
2025-02-03 01:49:58 +00:00
renovate[bot] 509c80d5bd
fix(deps): update golang.org/x/exp digest to e0ece0d
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-02-01 05:07:10 +00:00
renovate[bot] 400645bf10
fix(deps): update github.com/vishvananda/netlink digest to 7c2350b
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-02-01 01:21:28 +00:00
tomsweeneyredhat 211d3ea3cf Bump c/storage to v1.57.1, c/image v5.34.0, c/common v0.62.0
If not already bumped, this will bump:

c/storage v1.57.1
c/image v5.34.0
c/common v0.62.0

in preparation for Podman v5.4 and beyond.

Buildah will be vendored in a separate PR.

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
2025-01-31 18:30:53 -05:00
openshift-merge-bot[bot] b06d78651a
Merge pull request #25182 from baude/artifactnotrunc
Add --no-trunc to artifact ls
2025-01-31 23:30:30 +00:00
Brent Baude d575ae12f8 Add --no-trunc to artifact ls
added a --no-trunc flag to artifact ls, which follows what images has
done.  by default now, the ls output will have the shortened 12
character digest.  the --no-trunc will output the full digest.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2025-01-31 16:19:18 -06:00
openshift-merge-bot[bot] c131c9d038
Merge pull request #25170 from baude/artifactoptions
Add type and annotations to artifact add
2025-01-31 17:19:18 +00:00
openshift-merge-bot[bot] e83c0c4de1
Merge pull request #24748 from lsm5/no-qemu-centos
[skip-ci] RPM: no qemu on RHEL
2025-01-31 17:08:18 +00:00
Brent Baude bd061aa2d5 Add type and annotations to artifact add
podman artifact add now supports two new command line switches.

--type string that describes the type of artifact
--annotation string slice in the form of key=val

These new options allow users to "tag" information in on their artifacts
for any number of purposes down the line

RUN-2446

Signed-off-by: Brent Baude <bbaude@redhat.com>
2025-01-31 09:53:03 -06:00
openshift-merge-bot[bot] a92340956c
Merge pull request #25171 from giuseppe/pass-device-requests-to-cli
pkg/api: honor cdi devices from the hostconfig
2025-01-31 15:21:00 +00:00
Paul Holzinger 4a0006db33
cirrus: ensure HOME is set in postbuild.sh
go 1.24 on rawhide starts to fail with:
go: could not parse netrc (GOAUTH=netrc): $HOME is not defined

GOAUTH is a new go 1.24 feature, and someone this started to require a
$HOME set. We should have $HOME set already in many places but because
the lib.sh script was not loaded here it was not set.

We have GOPATH set AFAICT otherwise go would never have worked without
$HOME.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-01-31 16:05:39 +01:00
Giuseppe Scrivano 18e29076f7
pkg/api: honor cdi devices from the hostconfig
pass down the devices specifies in the resources block so that CDI
devices in the compose file are honored.

Tested manually with the following compose file:

services:
  testgpupodman_count:
    image: ubuntu:latest
    command: ["nvidia-smi"]
    profiles: [gpu]
    deploy:
      resources:
        reservations:
          devices:
          - driver: nvidia
            count: 1
            capabilities: [gpu]
  testgpupodman_deviceid:
      image: docker.io/ubuntu:latest
      command: ["nvidia-smi"]
      deploy:
        resources:
          reservations:
            devices:
            - driver: cdi
              device_ids: ['nvidia.com/gpu=all']
              capabilities: [gpu]

Closes: https://github.com/containers/podman/issues/19338

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2025-01-31 15:26:09 +01:00
Paul Holzinger 1c0f5b0475
new images 2025-01-31
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-01-31 14:51:27 +01:00
Paul Holzinger f0ef791808
podman exec: correctly support detaching
podman exec support detaching early via the detach key sequence. In that
case the podman process should exit successfully but the container exec
process keeps running.

Now I wrote automated test for both podman run and exec detach but this
uncovered several larger issues:
 - detach sequence parsing is broken[1]
 - podman-remote exec detach is broken[2]
 - detach in general seems to be buggy/racy, seeing lot of flakes that
   fail to restore the terminal and get an EIO instead, i.e.
   "Unable to restore terminal: input/output error"

Thus I cannot add tests for now but this commit should at least fix the
obvoius case as reported by the user so I like to get this in regardless
and I will work through the other issues once I have more time.

Fixes #24895

[1] https://github.com/containers/common/pull/2302
[2] https://github.com/containers/podman/issues/25089

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-01-31 13:29:04 +01:00
Paul Holzinger 3eb0e1e8ac
libpod: remove unused ExecStartAndAttach()
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-01-31 13:28:01 +01:00
Lokesh Mandvekar be6fa68296
[skip-ci] RPM: include empty check to silence rpmlint
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2025-01-31 17:15:17 +05:30