Commit Graph

19944 Commits

Author SHA1 Message Date
Aditya R 82bd56be74
manifest-push: add support for --force-compression
Adds support for --force-compression which allows end-users to force
push blobs with the selected compresison in --compression option, in
order to make sure that blobs of other compression on registry are not
reused.

Signed-off-by: Aditya R <arajan@redhat.com>
2023-08-24 13:36:04 +05:30
Aditya R 469ace0910
push: add support for --force-compression
Adds support for --force-compression which allows end-users to force
push blobs with the selected compresison in --compression option, in
order to make sure that blobs of other compression on registry are not
reused.

Is equivalent to: force-compression here: https://docs.docker.com/build/exporters/#compression

Closes: https://github.com/containers/podman/issues/18660

Signed-off-by: Aditya R <arajan@redhat.com>
2023-08-24 13:35:58 +05:30
OpenShift Merge Robot 7c0e926820
Merge pull request #19719 from cevich/stop_building_hello
[CI:DOCS] Remove `hello` multi-arch image build
2023-08-23 16:13:23 -02:30
OpenShift Merge Robot c07f46e15c
Merge pull request #19630 from rhatdan/kube
Expand env variables for cmds/entrypoint with format $(ENV)
2023-08-23 13:56:38 -02:30
Chris Evich 7e0130f75c
Remove `hello` multi-arch image build
Moved to https://github.com/containers/PodmanHello

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-08-23 12:10:22 -04:00
OpenShift Merge Robot f29986178e
Merge pull request #19710 from vrothberg/df-benchmarks
[CI:DOCS] hack/perf/system-df.sh: add `df` benchmarks
2023-08-23 10:53:23 -02:30
Valentin Rothberg 1b0e64a103 hack/perf/system-df.sh: add `df` benchmarks
The performance issue in #19467 drove me to add a benchmark for
system-df to avoid regressing on it in the future.

Comparing current HEAD to v4.6.0 yields

```
/home/vrothberg/containers/podman/bin/podman system df ran
201.47 times faster than /usr/bin/podman system df
```

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-08-23 14:17:27 +02:00
OpenShift Merge Robot 7f6bcbba81
Merge pull request #19709 from vrothberg/vendor-storage
vendor c/storage@6902c2d
2023-08-23 09:29:32 -02:30
OpenShift Merge Robot d22c336287
Merge pull request #19707 from sstosh/cgroupv1-limit-ignore
Ignore the resource limits on cgroups V1 rootless systems
2023-08-23 09:26:55 -02:30
Daniel J Walsh 148d95d8df
Expand env variables for cmds/entrypoint with format $(ENV)
Kubernetes supports expanding $(FOOBAR) as environment variables within
the kube.YAML. When using podman kube play, we need to do the same, for
supporting these YAML files.

Fixes: #15983

Signed-off-by: Chee Hau Lim <ch33hau@gmail.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-08-23 07:56:17 -04:00
OpenShift Merge Robot a9c98770e6
Merge pull request #19557 from n1hility/automatic-ports
Implement automatic port reassignment on Windows
2023-08-23 06:49:11 -02:30
OpenShift Merge Robot 2978addf78
Merge pull request #19703 from baude/stopgvproxyfixups
Fixups for stopping gvproxy
2023-08-23 06:18:14 -02:30
Valentin Rothberg e092f887fe vendor c/storage@6902c2d
Mainly to merge fixes for #19467 into the main branch.

Fixes: #19467
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-08-23 10:47:41 +02:00
Toshiki Sonoda c416e45766 Ignore the resource limits on cgroups V1 rootless systems
This is a regression for #18052.
When podman ignores the resource limits, s.ResourceLimits needs to be
nil.

[NO NEW TESTS NEEDED]

Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
2023-08-23 13:58:13 +09:00
Brent Baude 9e680cbc63 Fixups for stopping gvproxy
Paul found logic errors in my earlier code for finding processes and
sending signals.  Some of the logic errors are associated with how
methods behave on different operating systems.  Created a darwin and
linux approach and a windows approach.

Signed-off-by: Brent Baude <bbaude@redhat.com>

[NO NEW TESTS NEEDED]
2023-08-22 16:00:15 -05:00
OpenShift Merge Robot 7bd60867de
Merge pull request #19700 from cevich/remove_lock_test
[CI:DOCS] Revert "GHA: Closed issue/PR comment-lock test"
2023-08-22 17:37:04 -02:30
Chris Evich 21c9517b5e
Revert "GHA: Closed issue/PR comment-lock test"
This reverts commit f0e8e79c97.
This is intentional, it was needed for testing. See

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-08-22 14:51:24 -04:00
OpenShift Merge Robot 5e295a940d
Merge pull request #19691 from cevich/lock_closed_issues
[skip-ci] Lock closed issues and PRs
2023-08-22 16:05:21 -02:30
OpenShift Merge Robot 260adf567a
Merge pull request #19695 from vrothberg/auto-update-docs
[CI:DOCS] update auto-update docs
2023-08-22 15:59:43 -02:30
Chris Evich f0e8e79c97
GHA: Closed issue/PR comment-lock test
This commit limits the blast-radius should the workflow fail
catastrophically.  It also instruments the workflow with a job-level
test-failure to trigger a notification mail.  This commit should be
reverted once the workflow is deemed functional.

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-08-22 13:30:04 -04:00
Chris Evich 5477fd38a9
GHA: Add workflow to lock closed issues/PRs
Ref: https://github.com/containers/podman/discussions/19012

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-08-22 13:30:03 -04:00
Valentin Rothberg 75ce47347c [CI:DOCS] update auto-update docs
Rewrite the auto-update man page.  It was quite dusty and out-dated as
it was not mentioning Quadlet at all.  At times it was too verbose about
internal implementation details that users shouldn't need to worry
about.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-08-22 16:19:06 +02:00
OpenShift Merge Robot f38668e322
Merge pull request #19622 from jakecorrenti/umask-on-play
Set default Umask for `podman kube play`
2023-08-22 06:39:58 -02:30
OpenShift Merge Robot 8354be9cf6
Merge pull request #19683 from lsm5/main-spdx-license
[CI:BUILD] rpm: spdx compatible license field
2023-08-22 06:06:19 -02:30
OpenShift Merge Robot 960b3960f3
Merge pull request #19689 from containers/renovate/github.com-google-uuid-1.x
fix(deps): update module github.com/google/uuid to v1.3.1
2023-08-21 19:52:55 -02:30
OpenShift Merge Robot 1bb96a87c9
Merge pull request #19687 from dfr/freebsd-netstat
libpod: sum per-interface network stats for FreeBSD
2023-08-21 19:49:56 -02:30
OpenShift Merge Robot 8295bbced8
Merge pull request #19690 from containers/renovate/major-ci-vm-image
chore(deps): update dependency containers/automation_images to v20230816
2023-08-21 19:47:22 -02:30
OpenShift Merge Robot f727428b52
Merge pull request #19663 from rhatdan/ramfs
Add support for ramfs as well as tmpfs in volume mounts
2023-08-21 16:51:06 -02:30
OpenShift Merge Robot 5a6515c6eb
Merge pull request #19684 from containers/renovate/golangci-golangci-lint-1.x
chore(deps): update dependency golangci/golangci-lint to v1.54.2
2023-08-21 16:48:34 -02:30
renovate[bot] 85d0df330f
chore(deps): update dependency containers/automation_images to v20230816
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-08-21 17:52:10 +00:00
renovate[bot] bc35e28c03
fix(deps): update module github.com/google/uuid to v1.3.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-08-21 17:27:05 +00:00
Doug Rabson 3d00744d29 libpod: sum per-interface network stats for FreeBSD
This sums the metric values from all interfaces similar to the Linux
version.

[NO NEW TESTS NEEDED]

Signed-off-by: Doug Rabson <dfr@rabson.org>
2023-08-21 16:00:41 +01:00
Jake Correnti 5eee8825e8 Set default Umask for `podman kube play`
Fixes a bug where `podman kube play` fails to set a container's Umask
to the default 0022, and sets it to 0000 instead.

Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2023-08-21 10:56:53 -04:00
OpenShift Merge Robot 375eb045ca
Merge pull request #19661 from dfr/freebsd-var-run
libpod: use /var/run instead of /run on FreeBSD
2023-08-21 12:24:50 -02:30
OpenShift Merge Robot 30ec94fea4
Merge pull request #19670 from lsm5/rpm-dep-man
[CI:BUILD] rpm: depend on man-db
2023-08-21 11:46:54 -02:30
Lokesh Mandvekar ef8f4db81c
[CI:BUILD] rpm: spdx compatible license field
The lowercase `and` in the License field isn't compatible with spdx
license format.

This commit replaces all `and` with `AND` in the License field in spec.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2023-08-21 09:52:27 -04:00
renovate[bot] e9539768ca
chore(deps): update dependency golangci/golangci-lint to v1.54.2
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-08-21 13:49:46 +00:00
Jason T. Greene 63a8926e96 Implement automatic port reassignment on Windows
While only leveraged by the WSL backend, this commit also adds core
infrastructure for all other backends for future enhancement.

- Adds a common port cross backend allocation registry to prevent duplicate
  assignment across multiple machine instances
- Introduces logic in Start() that detects OS port conflicts and scans for a
  viable replacement port
- Updates connection definitions and server configuration accordingly
- Utilizes a coordinated file lock strategy to prevent racing overwrites of port
  and connection registries
- WSL backend coordinates locking for containers.conf until a future common
  enhancement exists to replace it

[NO NEW TESTS NEEDED]

Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2023-08-21 07:23:31 -05:00
Daniel J Walsh 45ce4834af
Add support for ramfs as well as tmpfs in volume mounts
Users want to mount a tmpfs file system with secrets, and make
sure the secret is never saved into swap. They can do this either
by using a ramfs tmpfs mount or by passing `noswap` option to
a tmpfs mount.

Fixes: https://github.com/containers/podman/issues/19659

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-08-21 07:14:57 -04:00
OpenShift Merge Robot 93f194cfb5
Merge pull request #19676 from rhatdan/pod
use container restart policy if user specifies one
2023-08-21 08:34:39 -02:30
OpenShift Merge Robot 84447c0855
Merge pull request #19677 from n1hility/detect-old-wsl
Validate current generation of WSL2 with user-mode-networking
2023-08-21 04:57:09 -02:30
Jason T. Greene bdc3040586 Validate current generation of WSL2 with user-mode-networking
Fail with a helpful message when older version is present.

[NO NEW TESTS NEEDED]

Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2023-08-18 23:33:30 -05:00
Daniel J Walsh 67756ac604
use container restart policy if user specifies one
Fixes: https://github.com/containers/podman/issues/19671

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-08-18 06:19:49 -04:00
OpenShift Merge Robot 20f28e538d
Merge pull request #19516 from baude/stopgvproxy
Stop gvproxy on hyperv machine stop
2023-08-18 06:45:39 -02:30
OpenShift Merge Robot 884e5f6934
Merge pull request #19668 from ashley-cui/teststart
Update machine start tests
2023-08-18 06:40:32 -02:30
OpenShift Merge Robot a161e8b7d8
Merge pull request #19667 from ashley-cui/testrm
Update machine rm tests
2023-08-18 06:37:55 -02:30
OpenShift Merge Robot 062511df99
Merge pull request #19669 from ashley-cui/testlist
Update machine list test
2023-08-18 06:35:22 -02:30
Brent Baude 0772d8ddb0 Stop gvproxy on hyperv machine stop
when we stop a machine, we need to also stop the gvproxy process that is
running.

JIRA: RUN-1828

also, remove unused applehv function for ssh

Signed-off-by: Brent Baude <bbaude@redhat.com>

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <bbaude@redhat.com>
2023-08-17 15:21:06 -05:00
Lokesh Mandvekar 50136ea866
[CI:BUILD] rpm: depend on man-db
Include dependencies in rpm/podman.spec to make it easy for end users to
build podman from source. This way users can install all build
dependencies by running `dnf -y builddep rpm/podman.spec`.

This is not usually noticeable except on container environments where
man-db often isn't installed by default.

Refs:
https://github.com/containers/podman.io/issues/157
https://github.com/containers/podman.io/pull/174

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2023-08-17 15:31:54 -04:00
Ashley Cui 36e09f18bb Update machine list test
check if --format json returns valid json

Signed-off-by: Ashley Cui <acui@redhat.com>
2023-08-17 15:05:48 -04:00