Commit Graph

22247 Commits

Author SHA1 Message Date
Ed Santiago 847ca1f9ea e2e tests: remove requirement for fuse-overlayfs
As of April 2024, it's no longer included in rawhide by default.
We could force-install it, but it's 2024 and it seems likely
that all systems on which Podman 5 will run will have kernels
that support native overlay.

I also added two debugging printfs to the 'podman info' test
that initially failed on an (unpublished) rawhide VM. Without
these printfs it was impossible to diagnose the failure.

Updating docs is left as a future exercise.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-04-09 05:25:20 -06:00
openshift-merge-bot[bot] 5989f99d44
Merge pull request #22308 from containers/renovate/golang.org-x-sync-0.x
fix(deps): update module golang.org/x/sync to v0.7.0
2024-04-09 10:26:24 +00:00
openshift-merge-bot[bot] 37b1edc5f3
Merge pull request #22300 from Luap99/make-docs
Makefile: fix annoying errors in docs generation
2024-04-09 10:12:39 +00:00
renovate[bot] b8670a3834
fix(deps): update module golang.org/x/sync to v0.7.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-04-08 19:46:19 +00:00
openshift-merge-bot[bot] 6487940534
Merge pull request #22301 from containers/renovate/golang.org-x-net-0.x
fix(deps): update module golang.org/x/net to v0.24.0
2024-04-08 19:43:35 +00:00
renovate[bot] f8533c71c4
fix(deps): update module golang.org/x/net to v0.24.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-04-08 12:28:28 +00:00
openshift-merge-bot[bot] 076a8157e5
Merge pull request #22281 from containers/renovate/golang.org-x-crypto-0.x
fix(deps): update module golang.org/x/crypto to v0.22.0
2024-04-08 12:26:42 +00:00
Paul Holzinger b9a8a2c61c
Makefile: fix annoying errors in docs generation
Currently when we run make docs we will see 100+ lines of
`grep: docs/build/man/links: Is a directory` printed.
This makes no sense as we should only try to validate the man page.

The manpage target is structured in a way that it runs the generation
for each file individually. As such the current way of grep'ing the
entire directory for each page is wrong. It should only validate the on
page that was created by the command above.

To fix this first define a OUTFILE var for the target to not have to
call the substitution every time we use the path and then only grep this
one file and not everything in the dir.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-04-08 14:13:17 +02:00
openshift-merge-bot[bot] 939bf63165
Merge pull request #22280 from elezar/bump-container-device-interface-v0.7.1
Bump tags.cncf.io/container-device-interface to v0.7.1
2024-04-08 09:56:10 +00:00
openshift-merge-bot[bot] 447d3e2a44
Merge pull request #22277 from Luap99/runroot
podman --runroot: remove 50 char length restriction
2024-04-06 11:12:07 +00:00
Evan Lezar a40cf3195a Bump tags.cncf.io/container-device-interface to v0.7.1
This includes migrating from cdi.GetRegistry() to cdi.Configure() and
cdi.GetDefaultCache() as applicable.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
2024-04-06 12:25:26 +02:00
renovate[bot] 3f83164526
fix(deps): update module golang.org/x/crypto to v0.22.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-04-05 16:30:43 +00:00
openshift-merge-bot[bot] 19600fa5e3
Merge pull request #22265 from containers/renovate/requests-mock-1.x
Update dependency requests-mock to ~=1.12.1
2024-04-05 16:27:27 +00:00
openshift-merge-bot[bot] 8ac7d9d492
Merge pull request #22262 from Luap99/rootlesskit-v2
update github.com/rootless-containers/rootlesskit to v2
2024-04-05 15:43:28 +00:00
openshift-merge-bot[bot] 41a710b0ca
Merge pull request #22278 from mheon/error_on_unhandled_reboot
Detect unhandled reboots and require user intervention
2024-04-05 15:40:42 +00:00
Matt Heon 3560ccd5df Detect unhandled reboots and require user intervention
Podman needs to be able to detect when a system reboot occurs to
do certain types of cleanup operation (for example, reset
container states, clean up IPAM allocations, etc). our current
method for this is a sentinel file on a tmpfs filesystem. The
problem emerges that there is no directory that is guaranteed to
be a tmpfs and is also guaranteed to be accessible to rootless
users in the FHS. If the user has a systemd user session, we can
depend on /run/user/$UID, but we can't reliably say that they do.

This code will detect the no-tmpfs-but-reboot-occurred case by
writing the current system boot ID to our tmpfs sentinel file
when it is created, and checking that file every time Podman
starts to make sure that the current boot ID matches the cached
one in the sentinel file. If they don't match, a reboot occurred
and the sentinel file was not on a tmpfs and thus survived. In
that case, throw an error telling the user to remove certain
directories (the ones that are supposed to be tmpfs), so we can
proceed as expected.

Signed-off-by: Matt Heon <mheon@redhat.com>
2024-04-05 10:07:42 -04:00
Paul Holzinger fcf9327773
podman --runroot: remove 50 char length restriction
This was added ages ago in commit c65b3599cc, however in the meantime
both podman and conmon can support longer socket paths as they use a
workaround to open the path via /proc/self/fd, see openUnixSocket() in
libpod/oci_conmon_attach_linux.go

Thus this restriction is not needed anymore and we can drop a workaround
in the tests.

Fixes #22272

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-04-05 14:41:50 +02:00
Paul Holzinger 10995192f8
update github.com/rootless-containers/rootlesskit to v2
Contains a breaking change but also besides this renovate is not able to
update the import paths so this needs to be done by hand.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-04-05 12:25:02 +02:00
openshift-merge-bot[bot] adbedb1464
Merge pull request #22257 from containers/renovate/github.com-shirou-gopsutil-v3-3.x
fix(deps): update module github.com/shirou/gopsutil/v3 to v3.24.3
2024-04-04 19:42:09 +00:00
openshift-merge-bot[bot] 036fb1849b
Merge pull request #22259 from Luap99/rm-force
rm --force work for more than one arg
2024-04-04 18:41:34 +00:00
renovate[bot] beb4fd1b4a
Update dependency requests-mock to ~=1.12.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-04-04 18:37:25 +00:00
openshift-merge-bot[bot] ef904c5b19
Merge pull request #22251 from umohnani8/kube-docs
[CI:DOCS] Update kube docs
2024-04-04 18:35:49 +00:00
openshift-merge-bot[bot] c5426247d7
Merge pull request #22236 from edsantiago/golangci-lint-update-options
[CI:DOCS] golangci-lint: update deprecated flags
2024-04-04 17:54:34 +00:00
openshift-merge-bot[bot] dda10fca30
Merge pull request #22254 from containers/renovate/golangci-golangci-lint-1.x
[CI:DOCS] Update dependency golangci/golangci-lint to v1.57.2
2024-04-04 16:59:36 +00:00
Paul Holzinger f2c365c6f6
rm --force work for more than one arg
When we remove with --force we do not return a error if the input does
not exists, however if we get more than on input we must try to remove
all and not just NOP out and not remove anything just because one arg
did not exists.

Also make the code simpler for commands that do have the --ignore option
and just make --force imply --ignore which reduces the ugly error
handling.

Fixes #21529

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-04-04 17:47:28 +02:00
Urvashi Mohnani 71f6f50ee1 [CI:DOCS] Update kube docs
Update kube docs stating the support of moving to and from
k8s in podman and explicitly stating that we are not replicating
the kubectl cli.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2024-04-04 09:28:21 -04:00
openshift-merge-bot[bot] 394be0b448
Merge pull request #22253 from ashley-cui/sitevers
[CI:DOCS] Add GitHub action to update version on Podman.io
2024-04-04 11:43:18 +00:00
openshift-merge-bot[bot] 8ab4bc9250
Merge pull request #22243 from Luap99/rootless-netns
vendor latest c/common to fix rootless-netns issues
2024-04-04 11:40:35 +00:00
openshift-merge-bot[bot] 3c7147110e
Merge pull request #22248 from edsantiago/windows-perl-is-in-vms
Windows: clean up temporary perl install
2024-04-04 09:14:48 +00:00
renovate[bot] 81d2ef889b
fix(deps): update module github.com/shirou/gopsutil/v3 to v3.24.3
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-04-03 19:58:21 +00:00
Daniel J Walsh ff7a3dc355
Merge pull request #22191 from containers/renovate/dawidd6-action-send-mail-3.x
[skip-ci] Update dawidd6/action-send-mail action to v3.12.0
2024-04-03 15:55:32 -04:00
openshift-merge-bot[bot] 1dcb3c7104
Merge pull request #22252 from Luap99/fix-walk-race
pkg/util: FindDeviceNodes() ignore ENOENT errors
2024-04-03 17:26:04 +00:00
Ashley Cui 0f949d884c [CI:DOCS] Add GitHub action to update version on Podman.io
Introduce a new GitHub action that will update Podman.io to the newest version of Podman. This action will run on a release being published to GitHub, or by clicking the run workflow button on GitHub. The action will check if the release version is higher than the current version on the website, and open a PR to update the version if a PR does not already exist. The commit will be signed off by the user who triggered the action, so whoever creates the release or presses the run workflow button. The PR will be opened by the podmanbot GitHub account.

Signed-off-by: Ashley Cui <acui@redhat.com>
2024-04-03 12:15:35 -04:00
renovate[bot] ccb71f9ffa
[CI:DOCS] Update dependency golangci/golangci-lint to v1.57.2
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-04-03 15:34:21 +00:00
openshift-merge-bot[bot] 0106e5929d
Merge pull request #22245 from giuseppe/do-not-chown-again-with-U
container: do not chown to dest target with U
2024-04-03 15:33:34 +00:00
openshift-merge-bot[bot] 33b60f1e0a
Merge pull request #22250 from edsantiago/validate-needs-docs
[CI:DOCS] build deps: make-validate needs docs
2024-04-03 15:27:50 +00:00
Ed Santiago ff133a544d Windows: clean up temporary perl install
Followup to #21991. Strawberry Perl is now installed by default
in CI VMs[1], so we no longer need the temporary install-perl code.

 [1] https://github.com/containers/automation_images/pull/337

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-04-03 08:53:55 -06:00
Paul Holzinger 498445871c
pkg/util: FindDeviceNodes() ignore ENOENT errors
This is racy by design, if you walk a tree and the directory was removed
between listing and then opening we get an ENOENT error. Simply ignore
that case and do not log it.

Fixes #21782

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-04-03 16:44:14 +02:00
Ed Santiago 549dbf8327 [CI:DOCS] build deps: make-validate needs docs
The man-page-check target requires up-to-date man pages.

Closes: #22025

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-04-03 08:26:17 -06:00
openshift-merge-bot[bot] 6b9b85e011
Merge pull request #22175 from edsantiago/skip_if_no_slirp
systests: conditionalize slirp4netns tests
2024-04-03 13:32:19 +00:00
Paul Holzinger a61ae8c0a9
test/system: add rootless-netns test for setup errors
This is a test for #22168.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-04-03 15:01:51 +02:00
Paul Holzinger ce04fbc16a
vendor latest c/common main
Includes several rootless-netns fixes.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-04-03 15:01:21 +02:00
Giuseppe Scrivano 519a66c6a9
container: do not chown to dest target with U
if the 'U' option is provided, do not chown the destination target to
the existing target in the image.

Closes: https://github.com/containers/podman/issues/22224

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2024-04-03 14:41:33 +02:00
openshift-merge-bot[bot] 976640474b
Merge pull request #22167 from edsantiago/systest_instrument
CI: systests: instrument flaky tests
2024-04-03 12:37:18 +00:00
Ed Santiago fbd6df92d4 [CI:DOCS] golangci-lint: update deprecated flags
Per https://golangci-lint.run/product/changelog/#v1570
  - Replace run.skip-xxx options by issues.exclude-xxx options

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-04-03 05:57:41 -06:00
Ed Santiago d27313ad10 systests: conditionalize slirp4netns tests
As of podman 5.0, slirp4netns is a soft dependency. It might
not be installed on a host (and, in gating tests, is not).
Deal with it.

Use podman itself, not 'which', to tell us if slirp4netns
is available. We don't want to duplicate podman's path-check
logic. Since this check is expensive, cache the result.

(Change the has_pasta check similarly)

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-04-03 05:49:21 -06:00
Ed Santiago e697631af9 CI: systests: instrument flaky tests
Three infrequent flakes. Add debug code to help track
down if/when they happen again.

And, one of them, fix a logic bug that will save us 8-10s
on system tests runs.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-04-03 05:26:51 -06:00
openshift-merge-bot[bot] d55ea0edfc
Merge pull request #22153 from lsm5/packit-fedora-latest
[skip-ci] Packit: specify fedora-latest in propose-downstream
2024-04-03 11:20:19 +00:00
openshift-merge-bot[bot] d2f639f61f
Merge pull request #21620 from WesselAtWork/docs/s3fs
[CI:DOCS] s3fs volume mount docs
2024-04-03 11:14:48 +00:00
WesselAtWork d2143fac59 s3fs docs
Signed-off-by: WesselAtWork <115667066+WesselAtWork@users.noreply.github.com>
2024-04-03 10:18:49 +00:00