Commit Graph

21692 Commits

Author SHA1 Message Date
openshift-merge-bot[bot] 89926c8af9
Merge pull request #21732 from rhatdan/docs1
[CI:DOCS] Fix up example description of podman-image commands
2024-02-19 09:07:22 +00:00
openshift-merge-bot[bot] 7b6f22e358
Merge pull request #21703 from rhatdan/docs30
[CI:DOCS] Fix up example description of podman-pause.1.md.in
2024-02-19 09:04:40 +00:00
openshift-merge-bot[bot] 6c7f987ab3
Merge pull request #21499 from tnk4on/fix-remove-dockersock-symlink
Fixed `podman-mac-helper uninstall` to remove docker.sock symlink
2024-02-18 23:29:49 +00:00
openshift-merge-bot[bot] 630bfbfdbd
Merge pull request #21686 from arixmkii/qemu-machine-5-bugfixes
Improve cross platform support in QEMU machine sources
2024-02-18 23:27:12 +00:00
openshift-merge-bot[bot] 7dd8fc50b9
Merge pull request #21684 from baude/machinereset
Introduce Podman machine reset
2024-02-18 17:46:06 +00:00
openshift-merge-bot[bot] e191f03938
Merge pull request #21706 from rhatdan/docs27
[CI:DOCS]  Fix up example description of podman-start.1.md.in
2024-02-18 17:43:20 +00:00
Daniel J Walsh 66ed469879
Apply suggestions from code review
Co-authored-by: Valentin Rothberg <vrothberg@redhat.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-02-18 12:42:07 -05:00
openshift-merge-bot[bot] 4c18bfa21b
Merge pull request #21716 from rhatdan/docs15
[CI:DOCS] Fix up example description of podman-exec.1.md.in
2024-02-18 17:26:49 +00:00
openshift-merge-bot[bot] 36dd18d42b
Merge pull request #21715 from rhatdan/docs20
[CI:DOCS] Fix up example description of podman-info.1.md
2024-02-18 17:24:16 +00:00
Brent Baude 10d748f584 Introduce Podman machine reset
Podman machine reset is a new command that will "reset" your podman
machine environment.  Reset is defined as:

* Stop and Remove all VMs
* Remove the following directories:
    - configuration dir i.e. ~/.config/containers/podman/machine/qemu
    - data dir i.e. ~/.local/.share/containers/podman/machine/qemu

When deleting, if errors are encountered, they will be batched and spit
out at the end.  Podman will try to proceed even in error in doing what
it was told.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2024-02-18 08:43:12 -06:00
Daniel J Walsh 777b258a7a
Fix up example description of podman-image commands
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-02-18 07:41:47 -05:00
Daniel J Walsh 63d9bf1280
Fix up example description of podman-pause.1.md.in
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-02-17 13:54:28 -05:00
Daniel J Walsh 4b6ca1687a
Fix up example description of podman-start.1.md.in
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-02-17 13:54:25 -05:00
Daniel J Walsh 6c8123325a
Fix up example description of podman-info.1.md
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-02-17 13:54:19 -05:00
Daniel J Walsh 10af448548
Fix up example description of podman-exec.1.md.in
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-02-17 13:54:14 -05:00
openshift-merge-bot[bot] fbb4d5dca6
Merge pull request #21692 from Luap99/machine-cleanup
machine init: validate machine name and username
2024-02-17 12:33:23 +00:00
openshift-merge-bot[bot] 3b3423230c
Merge pull request #21666 from n1hility/reenable-wsl-tests
Reenable wsl tests
2024-02-17 12:27:52 +00:00
openshift-merge-bot[bot] 335750d99b
Merge pull request #21689 from mheon/bump_500_rc2
Bump to v5.0.0-RC2
2024-02-16 16:42:58 +00:00
Jason T. Greene f036476cfa fix usermode test
Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2024-02-16 09:17:29 -06:00
openshift-merge-bot[bot] a8d20e466b
Merge pull request #21690 from containers/renovate/golangci-golangci-lint-1.x
[CI:DOCS] Update dependency golangci/golangci-lint to v1.56.2
2024-02-16 15:09:30 +00:00
Paul Holzinger 2846027dc6
machine init: validate machine name and username
Validate the names with our name regex that we also use for
containers/pods. While we technically do not need to be that strict, I
think it makes sense to match containers. The most important bit of this
validation is that we exclude the use of / and \ which breaks all our
file paths as we just use this in the name an when machine write the
file it ends up being in a subdir which breaks the reading side. Also
other special characters could cause trouble for the URL parsing in the
machine connection URL.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-02-16 15:58:39 +01:00
openshift-merge-bot[bot] fa0937affe
Merge pull request #21682 from edsantiago/manpages-nested-structs
[CI:DOCS] man-page xref: make nested-structure warnings fatal
2024-02-16 14:48:34 +00:00
renovate[bot] 8be1c0b042
[CI:DOCS] Update dependency golangci/golangci-lint to v1.56.2
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-02-16 14:08:05 +00:00
openshift-merge-bot[bot] abb5300532
Merge pull request #21643 from baude/fcospruning
Prune FCOS related code
2024-02-16 14:06:29 +00:00
Paul Holzinger 30a18fc02d
pkg/machine: make only one AddConnection() call
This function has to read/write the connections file as such it should
only ever be called once otherwise we read/write the same file twice
which makes no sense. Also cleanup the fucntion a bit and make it
private as there are no external callers.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-02-16 14:58:17 +01:00
openshift-merge-bot[bot] 9bc94dd99c
Merge pull request #21651 from containers/renovate/docker.io-library-golang-1.x
chore(deps): update docker.io/library/golang docker tag to v1.22
2024-02-16 13:55:17 +00:00
Matt Heon 7f2a6c735f Bump to v5.0.0-dev
Signed-off-by: Matt Heon <mheon@redhat.com>
2024-02-16 08:43:28 -05:00
Matt Heon f620aa0fbd Bump to v5.0.0-rc2
Signed-off-by: Matt Heon <mheon@redhat.com>
2024-02-16 08:43:11 -05:00
Paul Holzinger d60757cca6
pkg/machine: cleanup MakeSSHURL
Remove unnecessary type redirection and just make it a normal function.
Also unexport it and move the test as it does not need to be public and
remove the default value assignments from the struct.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-02-16 14:41:14 +01:00
Arthur Sengileyev e0a7668547 Improve cross platform support in QEMU machine sources
Signed-off-by: Arthur Sengileyev <arthur.sengileyev@gmail.com>
2024-02-16 12:49:54 +02:00
Shion Tanaka bd0a9e9031 Fix remove docker.sock symlink
Signed-off-by: Shion Tanaka <shtanaka@redhat.com>
2024-02-16 12:35:38 +09:00
Brent Baude 1f64ae10f6 Prune FCOS related code
Given the switch to pulling oci artifacts for podman, we no longer need
a fair bit of fedora coreos code for automatically downloading images.

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <bbaude@redhat.com>
2024-02-15 21:05:17 -06:00
Jason T. Greene 4fffa78eec Manually discover wsl.exe location
Works around a problem where recent Windows updates do not always redirect the
system wsl to the app store wsl version correctly.

Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2024-02-15 16:31:10 -06:00
Brent Baude 889454104e Turn WSL machine tests back on
[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <bbaude@redhat.com>
2024-02-15 16:31:10 -06:00
openshift-merge-bot[bot] 5fc351a67a
Merge pull request #21668 from Luap99/machine-pull-interrupt
machine: ocipull do not error if downloaddir exists
2024-02-15 21:35:54 +00:00
openshift-merge-bot[bot] bed619ca3d
Merge pull request #21664 from n1hility/wsl-fix-conflict
Fixes VM name conflict checking with WSL
2024-02-15 20:24:22 +00:00
Ed Santiago c7537d1939 man-page xref: make nested-structure warnings fatal
Followup to:
  - #21060, where I added new struct checks (but did not make them fatal)

  - #21534, which added per-interface stats and a .Network field,
    but its documentation was slightly off

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-02-15 13:22:31 -07:00
openshift-merge-bot[bot] 1141946e67
Merge pull request #21673 from Luap99/qemu-netdev-socket
machine/qemu: use extra gvproxy socket
2024-02-15 18:06:40 +00:00
openshift-merge-bot[bot] c84bb81f4d
Merge pull request #21671 from mheon/e2e_stop_helper
Add a helper for stopping pods and containers in E2E
2024-02-15 18:03:56 +00:00
Jason T. Greene d221e0b00a Remove log-level from runSystemCommand since wsl does not support it
Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2024-02-15 11:54:46 -06:00
Paul Holzinger 9ee17d4222
machine/qemu: use extra gvproxy socket
Right now the code used the same socket for gvproxy and the qemu qmp
socket, this was racy and no correct as the later overwrote the former.
The correct thing is to use to separate socket paths, just use the
GVProxySocket() helper like applehv does.

[NO NEW TESTS NEEDED]

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-02-15 16:25:38 +01:00
Matt Heon 3ca2213607 Add a helper for stopping pods and containers in E2E
This removes a lot of boilerplate, but also ensures that every
stop test that is not directly testing podman stop or podman pod
stop uses `-t0` for quick, error-free stopping.

Signed-off-by: Matt Heon <mheon@redhat.com>
2024-02-15 09:35:55 -05:00
Paul Holzinger bcec7e6279
machine: ocipull do not error if downloaddir exists
If users cancel the image download with CTRL-C for example then the
blob dir will stay around. The next time we run the download we should
just start the download again and not complain about the existing
directory.

[NO NEW TESTS NEEDED]

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-02-15 15:08:52 +01:00
openshift-merge-bot[bot] bbd4476d31
Merge pull request #21661 from edsantiago/stopsignal
More test tweaks to avoid "StopSignal ... 10 seconds" warning
2024-02-15 13:56:02 +00:00
openshift-merge-bot[bot] 13d1e8bd61
Merge pull request #21658 from cevich/test_pr
Test PR, add a inconsequential period to docs
2024-02-15 13:53:18 +00:00
openshift-merge-bot[bot] a946e8707d
Merge pull request #21519 from cevich/fix_cleanup_permissions
Allow CI user to cleanup own files
2024-02-15 13:09:16 +00:00
Ed Santiago e5f86f8628 More test tweaks to avoid "StopSignal ... 10 seconds" warning
Continuing to see CI failures of the form "StopSignal SIGTERM
failed to stop container in 10 seconds". Work around those,
either by adding "-t0" to podman stop, or by using Expect(Exit(0))
instead of ExitCleanly().

Addresses, but does not close, #20196

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-02-14 18:27:26 -07:00
openshift-merge-bot[bot] e595441891
Merge pull request #21657 from baude/fixocipull
Fix small bug in ocipull
2024-02-14 21:55:28 +00:00
Brent Baude 144e420bb9 Add testcase for WSL dist conflicts
Signed-off-by: Brent Baude <bbaude@redhat.com>
2024-02-14 15:36:08 -06:00
Jason T. Greene d23dd35dc1 Correct VM existance check on WSL
Replaces GetHyperVisorVMs() with Exists() to better abstract the underlying
use-case and slightly imrpove efficiency.

Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2024-02-14 15:27:56 -06:00