Commit Graph

23566 Commits

Author SHA1 Message Date
Ed Santiago bcffa9ce30 clean_setup: create pause image
Workaround for #23292, where simultaneous 'pod create' commands
will all start a podman-build of the pause image, but only
one of them will be tagged, and the others will leak <none>
images.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-09-17 11:19:36 -06:00
Ed Santiago d571ca6536 system test parallelization: enable two-pass approach
For the past two months we've been splitting system tests
into two categories: those that CAN be run in parallel,
and those that CANNOT. Much work has been done to replace
hardcoded names (mycontainer, mypod) with safename().
Hundreds of test runs, in CI and on Ed's laptop, have
proven this approach viable.

make {local,remote}system now runs in two steps: first
the serial ones, then the parallel ones. hack/bats will
now recognize the 'ci:parallel' tag and add --jobs (nprocs).

This requires some tweaking of leak_check, because there
can be umpteen tests running (affecting image/container/pod/etc
state) when any given test completes.

Rules for enabling parallelization in tests:

   * use unique container/pod/volume/network names (safename)
   * do not run 'podman rm -a' or 'rmi -a'
   * never use the -l (--latest) option
   * do not run 'podman ps/images' and expect precise output

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-09-17 09:25:02 -06:00
openshift-merge-bot[bot] f4a08f46b7
Merge pull request #23959 from auyer/hide-secrets-from-container-inspect
Hide secrets from container inspect command
2024-09-17 13:00:18 +00:00
openshift-merge-bot[bot] 9781a268a2
Merge pull request #23978 from Luap99/golangci-lint-1.61
update golangci-lint to 1.61.0
2024-09-17 12:57:32 +00:00
openshift-merge-bot[bot] 3f0483f880
Merge pull request #23802 from jerome59/main
Podman CLI --add-host with multiple host for a single IP
2024-09-17 12:54:46 +00:00
openshift-merge-bot[bot] 214e64e287
Merge pull request #23979 from edsantiago/workaround-remote-events-flake
CI: e2e: workaround for events out-of-sequence flake
2024-09-17 12:49:19 +00:00
openshift-merge-bot[bot] a4794bc9c6
Merge pull request #23977 from giuseppe/fix-permissions-copyup-volume-userns
libpod: convert owner IDs only with :idmap
2024-09-17 12:46:32 +00:00
Rafael Passos a5e9b4d126 libpod: hides env secrets from container inspect
Replaces env values supplied from podman secrets,
returns ******* instead

Fixes: #23788

Signed-off-by: Rafael Passos <rafael@rcpassos.me>
2024-09-17 09:12:39 -03:00
Ed Santiago 111a4bbe71 CI: e2e: workaround for events out-of-sequence flake
podman-remote events are not flushed, so order is not guaranteed.
This results in CI flakes. Only on Debian, for reasons unknown.

Make the network-connection events test more lenient when remote.

Closes: #23634 (but does not actually fix it)

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-09-17 06:12:26 -06:00
Paul Holzinger 49a07fce49
update golangci-lint to 1.61.0
Silence some new warnings that should not matter here.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-09-17 13:30:59 +02:00
Giuseppe Scrivano 432325236b
libpod: convert owner IDs only with :idmap
convert the owner UID and GID into the user namespace only when
":idmap" mount is used.

This changes the behaviour of :idmap with an empty volume.  Now the
existing directory ownership is copied up as in the other case.

Closes: https://github.com/containers/podman/issues/23347

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2024-09-17 12:38:53 +02:00
openshift-merge-bot[bot] bd93e1a7ce
Merge pull request #23968 from containers/renovate/github.com-cpuguy83-go-md2man-v2-2.x
fix(deps): update module github.com/cpuguy83/go-md2man/v2 to v2.0.5
2024-09-17 09:15:00 +00:00
Jerome Degroote f4d0e124d6 Podman CLI --add-host with multiple host for a single IP
Signed-off-by: Jerome degroote <jeromedu59230@gmx.fr>
2024-09-17 09:35:38 +02:00
openshift-merge-bot[bot] 9da233678e
Merge pull request #23961 from Luap99/pasta-userns
pkg/specgen: allow pasta when running inside userns
2024-09-17 06:43:28 +00:00
openshift-merge-bot[bot] e05568cf12
Merge pull request #23970 from ygalblum/simplify-get-units-dir
Quadlet - Split getUnitDirs to small functions
2024-09-17 06:40:41 +00:00
openshift-merge-bot[bot] 47b85af635
Merge pull request #23948 from l0rd/build-with-volumes-on-windows
Convert windows paths in volume arg of the build command
2024-09-16 19:16:13 +00:00
Ygal Blum a664708f35 Quadlet - Split getUnitDirs to small functions
Adjust the unittest

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2024-09-16 15:03:52 -04:00
renovate[bot] 1a1001d824
fix(deps): update module github.com/cpuguy83/go-md2man/v2 to v2.0.5
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-16 18:26:51 +00:00
openshift-merge-bot[bot] 156efe5ded
Merge pull request #23927 from lsm5/packit-sidetag
[skip-ci] Packit: Enable sidetags for bodhi updates
2024-09-16 17:23:15 +00:00
openshift-merge-bot[bot] e315697ed3
Merge pull request #23966 from containers/renovate/setuptools-75.x
chore(deps): update dependency setuptools to ~=75.1.0
2024-09-16 17:12:23 +00:00
openshift-merge-bot[bot] 683f68acc7
Merge pull request #23914 from edsantiago/safename-260
CI: make 260-sdnotify parallel-safe
2024-09-16 15:41:34 +00:00
openshift-merge-bot[bot] fbce6dc106
Merge pull request #23949 from l0rd/wsl-disk-oci-pull
Get WSL disk as an OCI artifact
2024-09-16 15:21:53 +00:00
openshift-merge-bot[bot] 22142c239e
Merge pull request #23965 from yeoldegrove/main
Fix typo in `docs/source/markdown/options/cache-ttl.md`
2024-09-16 14:10:22 +00:00
renovate[bot] c436a9b658
chore(deps): update dependency setuptools to ~=75.1.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-16 13:17:21 +00:00
openshift-merge-bot[bot] 94fed9f69c
Merge pull request #23962 from Luap99/quadlet-ENOENT
quadlet: do not log ENOENT errors
2024-09-16 13:16:43 +00:00
Eike Waldt fdb2edf46a
Fxi typo in cache-ttl.md
Signed-off-by: Eike Waldt <waldt@b1-systems.de>
2024-09-16 14:58:38 +02:00
Mario Loriedo b2e6d53265 Get WSL disk as an OCI artifact
[Since a few days][1] WSL disk releases are also pushed
to [quay.io/podman/machine-os-wsl][2]. This PR updates
`podman machine init` mechanism to download WSL disk
images. The WSL disk images are now pulled from quay.io
as for the rest of the providers.

Fixes [#22927][3] and [RUN-2177][4]

[1]: https://github.com/containers/podman-machine-wsl-os/pull/6
[2]: https://quay.io/repository/podman/machine-os-wsl?tab=tags
[3]: https://github.com/containers/podman/issues/22927
[4]: https://issues.redhat.com/browse/RUN-2177

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2024-09-16 14:36:50 +02:00
Ed Santiago c6616004f1 CI: make 260-sdnotify parallel-safe
Use safename. Add ci:parallel tags. Do not remove pause image
nor kube network.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-09-16 05:04:24 -06:00
Paul Holzinger 42a1f5e87c
quadlet: do not log ENOENT errors
There is no point in logging them, the directories not existing is fine
and expected and logging these by default when useing -dryrun just
causes confusion.

Fixes #23620

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-09-16 11:51:17 +02:00
Paul Holzinger 91dbd6dc33
pkg/specgen: allow pasta when running inside userns
pasta doesn't switch to nobody when we already run in a userns so we can
use it there. The unshare package checks the same condition and returns
true even if uid 0 in this case so we can directly call this.

ref https://github.com/containers/podman/issues/17840#issuecomment-2343251014

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-09-16 11:43:18 +02:00
openshift-merge-bot[bot] 24c911841c
Merge pull request #23960 from eriksjolund/troubleshooting-user-containers
troubleshooting: add tip about the user containers
2024-09-16 09:02:53 +00:00
openshift-merge-bot[bot] 2584473929
Merge pull request #23958 from containers/renovate/setuptools-75.x
chore(deps): update dependency setuptools to v75
2024-09-16 08:02:20 +00:00
Erik Sjölund 9a8e17816a troubleshooting: add tip about the user containers
Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2024-09-16 08:18:21 +02:00
renovate[bot] 95833a6207
chore(deps): update dependency setuptools to v75
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-15 16:55:11 +00:00
openshift-merge-bot[bot] fdb8b1c6d3
Merge pull request #23863 from inknos/issue-23436
Add help message when starting multiple machines
2024-09-13 17:38:52 +00:00
Mario Loriedo 1857d7e50f Convert windows paths in volume arg of the build command
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2024-09-13 17:24:06 +02:00
openshift-merge-bot[bot] 4d9ce3309a
Merge pull request #23951 from containers/renovate/github.com-cyphar-filepath-securejoin-0.x
fix(deps): update module github.com/cyphar/filepath-securejoin to v0.3.2
2024-09-13 13:59:08 +00:00
Nicola Sella d124d90e18 Improve error when starting multiple machines
Instead of ErrVMAlreadyRunning use a more appropriate error.
Also improve the message a little bit.

Fixes: https://github.com/containers/podman/issues/23436

Signed-off-by: Nicola Sella <nsella@redhat.com>
2024-09-13 15:51:27 +02:00
openshift-merge-bot[bot] 07397de1eb
Merge pull request #23936 from l0rd/win-setup-radio-button
Add radio buttons to select WSL or Hyper-V in windows setup.exe
2024-09-13 12:44:40 +00:00
openshift-merge-bot[bot] d4cda112f1
Merge pull request #23921 from edsantiago/safename-710
CI: make 710-kube parallel-safe
2024-09-13 12:41:54 +00:00
openshift-merge-bot[bot] 421a80bcb7
Merge pull request #23908 from edsantiago/safename-505
CI: make 505-pasta parallel safe
2024-09-13 12:39:11 +00:00
openshift-merge-bot[bot] 03bae4a33f
Merge pull request #23902 from containers/renovate/github.com-docker-docker-27.x
fix(deps): update module github.com/docker/docker to v27.2.1+incompatible
2024-09-13 12:36:38 +00:00
openshift-merge-bot[bot] 29f75000dd
Merge pull request #23916 from edsantiago/safename-320
CI: mark 320-system-df *NOT* parallel safe
2024-09-13 12:33:41 +00:00
renovate[bot] fe08440ec3
fix(deps): update module github.com/cyphar/filepath-securejoin to v0.3.2
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-13 12:32:47 +00:00
openshift-merge-bot[bot] 4a757d4c36
Merge pull request #23950 from ericcurtin/minor-man-page-typo
Minor typo noticed when reading podman man page
2024-09-13 12:30:52 +00:00
Eric Curtin 01a1761fd9 Minor typo noticed when reading podman man page
It reads "ashort-name" when it should read "a short-name" when viewing
via man. It's missing a space. Also removed some duplicate spaces.

Signed-off-by: Eric Curtin <ecurtin@redhat.com>
2024-09-13 13:04:57 +01:00
openshift-merge-bot[bot] 40ca23077d
Merge pull request #23649 from pwright/patch-1
typo
2024-09-12 14:53:13 +00:00
Paul Wright ac4a31cc4a rewrite typo osascript
Signed-off-by: Paul Wright <pwright@redhat.com>
2024-09-12 14:57:55 +01:00
Paul Wright 089d2513d8 typo
Signed-off-by: Paul Wright <pwright@redhat.com>
2024-09-12 14:57:41 +01:00
renovate[bot] 31a1fd8f33
fix(deps): update module github.com/docker/docker to v27.2.1+incompatible
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-12 09:27:12 +00:00