Commit Graph

14432 Commits

Author SHA1 Message Date
OpenShift Merge Robot db08bc096e
Merge pull request #13477 from containers/dependabot/go_modules/github.com/containernetworking/plugins-1.1.1
Bump github.com/containernetworking/plugins from 1.1.0 to 1.1.1
2022-03-10 09:04:06 -05:00
OpenShift Merge Robot e10394da7e
Merge pull request #13476 from containers/dependabot/go_modules/github.com/vbauerster/mpb/v7-7.4.1
Bump github.com/vbauerster/mpb/v7 from 7.3.2 to 7.4.1
2022-03-10 09:02:06 -05:00
dependabot[bot] e6b64703fe
Bump github.com/containernetworking/plugins from 1.1.0 to 1.1.1
Bumps [github.com/containernetworking/plugins](https://github.com/containernetworking/plugins) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/containernetworking/plugins/releases)
- [Commits](https://github.com/containernetworking/plugins/compare/v1.1.0...v1.1.1)

---
updated-dependencies:
- dependency-name: github.com/containernetworking/plugins
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-10 12:10:53 +00:00
dependabot[bot] a5353207c7
Bump github.com/vbauerster/mpb/v7 from 7.3.2 to 7.4.1
Bumps [github.com/vbauerster/mpb/v7](https://github.com/vbauerster/mpb) from 7.3.2 to 7.4.1.
- [Release notes](https://github.com/vbauerster/mpb/releases)
- [Commits](https://github.com/vbauerster/mpb/compare/v7.3.2...v7.4.1)

---
updated-dependencies:
- dependency-name: github.com/vbauerster/mpb/v7
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-10 12:10:45 +00:00
OpenShift Merge Robot acfcecf2ae
Merge pull request #12913 from rhatdan/kube
Add --context-dir option to podman play kube
2022-03-09 16:19:59 -05:00
OpenShift Merge Robot 4e21acd7b8
Merge pull request #13455 from rhatdan/docker
Fix handling of tmpfs-mode for tmpfs creation in compat mode
2022-03-09 15:53:58 -05:00
OpenShift Merge Robot d3e6c2a7ab
Merge pull request #13471 from Luap99/bump-mpbv7
Use github.com/vbauerster/mpb/v7 in pkg/machine
2022-03-09 15:51:57 -05:00
Paul Holzinger 30bf065c3f
Use github.com/vbauerster/mpb/v7 in pkg/machine
We already use v7 in c/image so podman should use the same version to
prevent duplication.

This saves 170 KB binary size.

[NO NEW TESTS NEEDED]

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-03-09 20:02:10 +01:00
OpenShift Merge Robot f960ac7ec3
Merge pull request #13470 from Luap99/yamlv2
use gopkg.in/yaml.v2 instead of v3
2022-03-09 12:50:01 -05:00
OpenShift Merge Robot 418ab2e5e1
Merge pull request #13421 from hshiina/device-rule
Set default rule at the head of device configuration
2022-03-09 10:28:24 -05:00
OpenShift Merge Robot ea4248dc26
Merge pull request #13469 from containers/dependabot/go_modules/github.com/docker/distribution-2.8.1incompatible
Bump github.com/docker/distribution from 2.8.0+incompatible to 2.8.1+incompatible
2022-03-09 09:53:57 -05:00
Paul Holzinger 8f2f8d4cad
use gopkg.in/yaml.v2 instead of v3
Many dependencies already import gopkg.in/yaml.v2, podman is the only
user of the v3 version except  github.com/stretchr/testify but this is
only a testing dependency so it will not end up in the binary.

This change reduces the podman binary size from 54740 to 54260 KB on my
system.

[NO NEW TESTS NEEDED]

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-03-09 15:44:05 +01:00
OpenShift Merge Robot 41e2c9943e
Merge pull request #13465 from n1hility/improve-install-msg
Improve agent install message to add restart instructions
2022-03-09 09:25:57 -05:00
Daniel J Walsh 166edf00a1
Fix handling of tmpfs-mode for tmpfs creation in compat mode
The permissions on disk were wrong since we were not converting to
octal.

Fixes: https://github.com/containers/podman/issues/13108

[NO NEW TESTS NEEDED] Since we don't currently test using the docker
client

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-03-09 08:03:42 -05:00
dependabot[bot] e56150264c
Bump github.com/docker/distribution
Bumps [github.com/docker/distribution](https://github.com/docker/distribution) from 2.8.0+incompatible to 2.8.1+incompatible.
- [Release notes](https://github.com/docker/distribution/releases)
- [Commits](https://github.com/docker/distribution/compare/v2.8.0...v2.8.1)

---
updated-dependencies:
- dependency-name: github.com/docker/distribution
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-09 12:07:43 +00:00
OpenShift Merge Robot 3e870f8c8e
Merge pull request #13466 from baude/machinermf
machine rm -f stops and removes machine
2022-03-09 03:51:55 -05:00
OpenShift Merge Robot 951c681efa
Merge pull request #13447 from eriksjolund/add_chown_tip_to_troubleshooting.md
[CI:DOCS] troubleshooting.md: mention "podman unshare chown 0:0 path"
2022-03-09 03:11:56 -05:00
Erik Sjölund db30102793 [CI:DOCS] troubleshooting.md: mention "podman unshare chown 0:0 path"
* Mention the command "podman unshare chown 0:0 dir1/a"
  that changes file ownership to the regular user's UID and GID on
  the host.

Co-authored-by: Tom Sweeney <tsweeney@redhat.com>
Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2022-03-09 08:55:36 +01:00
Jason T. Greene a7c4691bff Improve agent install message to add restart instructions
Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2022-03-08 21:54:48 -06:00
OpenShift Merge Robot 694737e7bb
Merge pull request #13460 from edsantiago/skip_flaky_pprof_test
Skip flaky pprof tests
2022-03-08 17:25:55 -05:00
Brent Baude 5b51b42cc8 machine rm -f stops and removes machine
If you want to remove a running machine, you can now pass the --force/-f
to podman machine rm and the machine will be stopped and removed without
confirmations.

Fixes: #13448

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <bbaude@redhat.com>
2022-03-08 15:47:32 -06:00
Ed Santiago e66c46441a Skip flaky pprof tests
pprof tests are way too flaky, and are causing problems for
community contributors who don't have privs to press Re-run.

There has been no activity or interest in fixing the bug,
and it's not something I can fix. So, just disable the test.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2022-03-08 11:26:43 -07:00
OpenShift Merge Robot a08e4e5b46
Merge pull request #13457 from ashley-cui/flake
Move secret-verify-leak containerfile into its own Directory
2022-03-08 13:18:11 -05:00
Ashley Cui 9ce3c0a87a Move secret-verify-leak containerfile into its own Directory
Secret-verify-leak is causing flakes, when running in parallel tests.
This is because remote secrets are copied into the context directory to
send to the API server, and secret-verify-leak is doing a COPY * and
then checking if the temporary secret file ends up in the container or
not. Since all the temporary files are prefixed with
"podman-build-secret", this test checks if podman-build-secret is in the
image. However, when run in parallel with other tests, other temporary
podman-build-secrets might be in the context dir. Moving
secret-verify-leak into its own directory makes sure that the context
dir is used only by this one test.

Also renamed Dockerfile -> Containerfile and cleaned up unused
Containerfiles.

Signed-off-by: Ashley Cui <acui@redhat.com>
2022-03-08 10:05:42 -05:00
OpenShift Merge Robot f33b64d8b7
Merge pull request #13366 from idleroamer/inspect-joined-network-ns-main
Inspect network info of a joined network namespace
2022-03-08 08:30:03 -05:00
😎 Mostafa Emami 611b45c517 Inspect network info of a joined network namespace
Closes: https://github.com/containers/podman/issues/13150
Signed-off-by: 😎 Mostafa Emami <mustafaemami@gmail.com>
2022-03-08 11:00:36 +01:00
Hironori Shiina d2f77c2568 Set default rule at the head of device configuration
The default rule should be set at the head of device configuration.
Otherwise, rules for user devices are overridden by the default rule so
that any access to the user devices are denied.

Signed-off-by: Hironori Shiina <shiina.hironori@jp.fujitsu.com>
2022-03-07 18:12:17 -05:00
OpenShift Merge Robot 4a242b1327
Merge pull request #13409 from baude/virtfsdarwin
MacOS improvements
2022-03-07 17:28:01 -05:00
Brent Baude cdb6deb148 MacOS improvements
* Enable support of virtfs in Podman and darwin.  At the time of this writing, it requires a special patch not yet included in upstream qemu.
* Prefer to use a specially built qemu to support virtfs.  The qemu is installed under libexec/podman.

[NO NEW TESTS NEEDED]
Signed-off-by: Brent Baude <bbaude@redhat.com>
2022-03-07 14:05:06 -06:00
OpenShift Merge Robot 2873f089f7
Merge pull request #13414 from rvandernoort/exec_delay
Add ExitCommandDelay configuration use in API exec handler
2022-03-07 13:32:52 -05:00
OpenShift Merge Robot 861d16921b
Merge pull request #13431 from eriksjolund/fix_some_typos
[CI:DOCS] troubleshooting.md: Improve language and fix typos
2022-03-07 11:55:02 -05:00
OpenShift Merge Robot 5bba71c112
Merge pull request #13310 from lsm5/packaging
[CI:DOCS] DISTRO_PACKAGE.md: List the packaging changes for v4
2022-03-07 11:50:52 -05:00
Lokesh Mandvekar 6dfe63463b
[CI:DOCS] DISTRO_PACKAGE.md: List the packaging changes for v4
[NO NEW TESTS NEEDED]

Co-authored-by: Ashley Cui <ashleycui16@gmail.com>
Co-authored-by: Valentin Rothberg <vrothberg@redhat.com>
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2022-03-07 11:34:05 -05:00
OpenShift Merge Robot 118b8fe986
Merge pull request #13418 from lsm5/release-artifacts-process-2
[CI:DOCS] RELEASE_PROCESS.md: cosmetic fix
2022-03-07 10:49:06 -05:00
Lokesh Mandvekar 639e6899b0
[CI:DOCS] RELEASE_PROCESS.md: cosmetic fix
Follow up to pr#13416

Insert line breaks to get rid of the horizontal scroll bar.

Resolves: https://github.com/containers/podman/pull/13416#discussion_r818991807

Co-authored-by: Ashley Cui <acui@redhat.com>
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2022-03-07 10:25:21 -05:00
OpenShift Merge Robot e1f00b4512
Merge pull request #13442 from tricktron/rm-mounted-host-socket-on-macos
`podman machine rm` removes the mounted socket file on macOS
2022-03-07 08:36:52 -05:00
OpenShift Merge Robot be3858bcf1
Merge pull request #13406 from jwhonce/wip/docker-py
Move all python tests to pytest
2022-03-07 06:30:57 -05:00
OpenShift Merge Robot 87d911aca9
Merge pull request #13423 from umohnani8/kube
Throw an error if kube yaml has duplicate ctr names
2022-03-07 06:29:00 -05:00
Thibault Gagnaux 01514f33ba
Fixes: #13301 ("machine rm removes the mounted socket file on macos")
[NO NEW TESTS NEEDED]
Signed-off-by: Thibault Gagnaux <tgagnaux@gmail.com>
2022-03-06 16:24:56 +01:00
Erik Sjölund b209933930 [CI:DOCS] troubleshooting.md: Improve language and fix typos
Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2022-03-05 18:06:36 +01:00
Urvashi Mohnani d302c08cff Throw an error if kube yaml has duplicate ctr names
Error out if the kube yaml passed to play kube has more
than one container or init container with the same name.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2022-03-04 15:08:52 -05:00
Jhon Honce dca2e7924b Move all python tests to pytest
* Add configuration to add report header for python client used in tests
* Move report headers into the individual test runners vs runner.sh

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2022-03-04 10:35:29 -07:00
OpenShift Merge Robot f4d6e87772
Merge pull request #13413 from giuseppe/pod-no-use-cgroups-if-disabled
libpod: pods do not use cgroups if --cgroups=disabled
2022-03-04 04:26:22 -05:00
Rover van der Noort 2fb6a8daf6 Add ExitCommandDelay configuration use in API exec handler
[NO NEW TESTS NEEDED]

Signed-off-by: Rover van der Noort <s.r.vandernoort@student.tudelft.nl>
2022-03-04 00:57:35 +01:00
OpenShift Merge Robot 5fc8c9b24a
Merge pull request #13416 from lsm5/release-artifacts-process
RELEASE_PROCESS.md: build artifacts locally
2022-03-03 14:24:51 -05:00
OpenShift Merge Robot 3cfb70f953
Merge pull request #13404 from flouthoc/bump-to-race-free-deps
deps: bump to race-free `c/image` and `c/storage` along with test to verify `concurrent/parallel` builds
2022-03-03 12:15:19 -05:00
Aditya R 63f92d0a66
test: add a test to verify race free concurrent/parallel builds
Invoking parallel/concurrent builds from podman race against each other
following behviour was fixed in
https://github.com/containers/storage/pull/1153 and https://github.com/containers/image/pull/1480

Test verifies if following bug is fixed in new race-free API or not.
Read more about this issue, see bz 2055487 for more details.

More details here: https://github.com/containers/buildah/pull/3794 and https://github.com/containers/podman/pull/13339

Co-authored-by: Ed Santiago <santiago@redhat.com>
Signed-off-by: Aditya R <arajan@redhat.com>
2022-03-03 21:03:35 +05:30
Lokesh Mandvekar a3497cee99
RELEASE_PROCESS.md: build artifacts locally
The current PR process for release bump has the HEAD commit which bumps
version/version.go to the form `release+1-dev`. This makes Cirrus
publish release artifacts with `release+1-dev` and not `release`.

For example, the msi generated at https://cirrus-ci.com/task/5403901196238848
says podman-v4.0.3-dev.msi .

Building locally by checking out the released tag would generate the
correct artifacts and would also be faster and more convenient.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2022-03-03 10:08:05 -05:00
Giuseppe Scrivano a901c919ab
libpod: pods do not use cgroups if --cgroups=disabled
do not attempt to use cgroups with pods if the cgroups are disabled.
A similar check is already in place for containers.

Closes: https://github.com/containers/podman/issues/13411

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2022-03-03 13:23:07 +01:00
OpenShift Merge Robot ed59b89a43
Merge pull request #13399 from flouthoc/resolve-workdir-symlink
container: workdir resolution must consider `symlink` if explicitly configured
2022-03-02 10:56:26 -05:00