3cf4567e1d
Merge pull request #3753 from baude/varlinkrequiresroot
...
varlink endpoint for containerstats requires root
2019-08-12 21:09:26 +02:00
d36c62d88d
Revert "Cirrus: Temp. workaround missing imgprune image"
...
This reverts commit 9b2e98f1e8
2019-08-12 15:04:30 -04:00
99494b55bc
Homebrew installation in install.md
...
Add brew installation instructions to docs & small fix to brew makefile
Signed-off-by: Ashley Cui <ashleycui16@gmail.com>
2019-08-12 15:03:20 -04:00
d27e71374e
Use GetRuntimeDir to setup auth.json for login
...
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2019-08-12 14:11:53 -04:00
55cc80d3c9
varlink endpoint for containerstats requires root
...
obtaining containerstats requires the use of cgroups. at present,
rootless users do not have privileges to create cgroups. add an error
message that catches this for the varlink endpoint and return a proper
error.
Fixes : #3749
Signed-off-by: baude <bbaude@redhat.com>
2019-08-12 13:08:57 -05:00
9bee6907a5
Merge pull request #3751 from TomSweeneyRedHat/dev/tsweeney/squishnits
...
Squish a few tpyo nits in container.go doc
2019-08-12 19:51:19 +02:00
ca7bae7f89
Merge pull request #3789 from giuseppe/cirrus-add-crun
...
cirrus: run tests with crun
2019-08-12 19:14:20 +02:00
341f0bf664
Merge pull request #3793 from stefanb2/topic-pr-3788
...
image: add user agent to Docker registry options
2019-08-12 19:02:20 +02:00
b843804d51
Adjust get_ci_vm.sh for substitution
...
Signed-off-by: Chris Evich <cevich@redhat.com>
2019-08-12 12:01:55 -04:00
5f99703594
Cirrus: Add verification for cgroupv2 image
...
Signed-off-by: Chris Evich <cevich@redhat.com>
2019-08-12 12:01:55 -04:00
7508179ed9
Cirrus: Add experimental fedora VM image & test
...
Signed-off-by: Chris Evich <cevich@redhat.com>
2019-08-12 12:01:55 -04:00
e7fdaf48db
image: add user agent to Docker registry options
...
Set the string to "libpod/VERSION" so that we don't use the unspecific
default of "Go-http-client/xxx".
Fixes #3788
Signed-off-by: Stefan Becker <chemobejk@gmail.com>
2019-08-12 18:28:36 +03:00
fd312ae30a
Cirrus: Minor, use newer Ubuntu base image
...
Signed-off-by: Chris Evich <cevich@redhat.com>
2019-08-12 11:02:02 -04:00
ec93c9d875
Merge pull request #3786 from giuseppe/fix-rootless-checks
...
rootless: drop some superflous checks
2019-08-12 16:53:46 +02:00
9f67cde9f8
tests: disable some tests currently failing when not using runc
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-12 16:09:34 +02:00
f18cfa4768
Merge pull request #3787 from giuseppe/rootless-cherry-pick-oci-runtime
...
rootless: cherry-pick runtime from the system configuration
2019-08-12 16:06:47 +02:00
efa26eedee
containers: look also for 'file not found' in the error message
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-12 15:47:26 +02:00
2f8451468c
cirrus: add tests with crun on Fedora 30
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-12 15:01:51 +02:00
79aeed9681
rootless: cherry-pick runtime from the system configuration
...
when creating the default libpod.conf file, be sure the default OCI
runtime is cherry picked from the system configuration.
Closes: https://github.com/containers/libpod/issues/3781
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-12 14:19:59 +02:00
0798fc5fc4
cirrus: install crun
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-12 14:11:59 +02:00
9e2f9c8b78
cmd: drop check for euid==0
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-12 12:33:28 +02:00
0ecf0aa1b8
storage: drop unused geteuid check
...
it is always running with euid==0 at this point.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-12 12:30:20 +02:00
dcf2037744
cmd, stats: fix check for rootless mode
...
and enable rootless stats when running on cgroups v2.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-12 12:03:53 +02:00
1ef5c4ea8f
oci: drop check for euid==0
...
we are always running with euid==0 at this point.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-12 11:58:18 +02:00
2348c2873f
Merge pull request #3785 from giuseppe/podman-build-use-configured-runtime
...
build: use the configured runtime
2019-08-12 01:55:59 +02:00
2aa35d25b3
build: use the configured runtime
...
Now buildah honors the runtime configured with podman.
Closes: https://github.com/giuseppe/crun/issues/69
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-11 23:25:51 +02:00
146719718e
Merge pull request #3782 from eriksjolund/fix_realloc_in_rootless_linux.c
...
Fix incorrect use of realloc()
2019-08-11 19:44:58 +02:00
7bbaa36a13
Merge pull request #3783 from eriksjolund/fix_read_count
...
Adjust read count so that a newline can be added afterwards
2019-08-11 19:22:59 +02:00
39ce3626e0
Adjust read count so that a newline can be added afterwards
...
Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2019-08-11 16:44:26 +02:00
4d3cf9b576
Fix incorrect use of realloc()
...
Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2019-08-11 15:58:20 +02:00
3bc861cb11
Merge pull request #3748 from rhatdan/covscan
...
Fix a couple of errors descovered by coverity
2019-08-10 20:11:43 +02:00
926901d78d
Merge pull request #3594 from cevich/second_partition
...
Add Second partition for storage-drive testing
2019-08-10 12:10:43 +02:00
3a554a0fda
Merge pull request #3746 from baude/enablewindowsremote
...
enable windows remote client
2019-08-10 12:01:57 +02:00
8c77dd77af
Merge pull request #3742 from adrianreber/ConmonPidFile
...
Conmon pid file
2019-08-10 12:01:45 +02:00
d65cb66437
Merge pull request #3758 from edsantiago/bats
...
implement 'make remotesystem'
2019-08-10 11:52:44 +02:00
b6e2bc3cc9
Merge pull request #3770 from cevich/updates_testing
...
Cirrus: Enable updates-testing repo for Fedora
2019-08-10 11:43:44 +02:00
2018faaf78
Merge pull request #3776 from mheon/bump-1.5.0
...
Bump to v1.5.0
2019-08-09 23:04:45 +02:00
580795077e
Bump gitvalidation epoch
...
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-08-09 16:00:38 -04:00
10834c525f
Bump to v1.5.1-dev
...
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-08-09 16:00:38 -04:00
54b394bd3e
Bump to v1.5.0
...
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-08-09 16:00:35 -04:00
bb80586e27
Merge pull request #3775 from vrothberg/update-storage
...
vendor github.com/containers/storage@v1.13.2
2019-08-09 21:58:53 +02:00
44126969f1
Fix a couple of errors descovered by coverity
...
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2019-08-09 15:33:16 -04:00
decfea65be
add --pull flag for podman create&run
...
Requirement from https://github.com/containers/libpod/issues/3575#issuecomment-512238393
Added --pull for podman create and pull to match the newly added flag in docker CLI.
`missing`: default value, podman will pull the image if it does not exist in the local.
`always`: podman will always pull the image.
`never`: podman will never pull the image.
Signed-off-by: Qi Wang <qiwan@redhat.com>
2019-08-09 15:21:34 -04:00
d05798e5e8
Merge pull request #3771 from TomSweeneyRedHat/dev/tsweeney/manpagetouches
...
Touch up build man page
2019-08-09 21:10:04 +02:00
492b4f65f6
Merge pull request #3737 from QiWang19/create_auth
...
fix create&run getting --authfile from cli
2019-08-09 21:09:50 +02:00
2e80400683
vendor github.com/containers/storage@v1.13.2
...
* Ignore ro mount options in btrfs and windows drivers
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2019-08-09 20:44:40 +02:00
4b91f60e89
Merge pull request #3762 from jwhonce/issue/3426
...
Improve dns-search validation, empty domains now return an error
2019-08-09 20:09:12 +02:00
0c9a941d01
Test that restored container does not depend on the original container
...
In the restore from external checkpoint archive test, the second restore
using a new name and ID is now done first to ensure that nothing in the
restored container depends on the original container.
Test has been adapted to catch errors like the one fixed with the
previous commit to adapt ConmonPidFile for restored containers.
Signed-off-by: Adrian Reber <areber@redhat.com>
2019-08-09 19:26:57 +02:00
a891b84528
Fix up ConmonPidFile after restore
...
After restoring a container with a different name (ID) the ConmonPidFile
was still pointing to the path of the original container.
This means that the last restored container will overwrite the
ConmonPidFile of the original container. It was also not possible to
restore a container with a new name (ID) if the original container was
not running.
The ConmonPidFile is only changed if the ConmonPidFile starts with the
value of RunRoot. This assumes that if RunRoot is part of ConmonPidFile
the user did not specify --conmon-pidfile' during run or create.
Signed-off-by: Adrian Reber <areber@redhat.com>
2019-08-09 19:26:56 +02:00
f070913c6a
Improve dns-search validation, empty domains now return an error
...
Fixes #3426
Signed-off-by: Jhon Honce <jhonce@redhat.com>
2019-08-09 09:58:39 -07:00
OpenShift Merge Robot
Chris Evich
Ashley Cui
Daniel J Walsh
baude
Stefan Becker
Giuseppe Scrivano
Erik Sjölund
Matthew Heon
Qi Wang
Valentin Rothberg
Adrian Reber
Jhon Honce