Fixes: #411
The bug was actually addressed in PR #453 - this change adds a test that
verifies that we actually fixed it.
Co-authored-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
Fixes: #444
ActorId doesn't define a default constructor, and so it's not
deserializable via System.Text.Json.
This change implements a converter so that ActorId's API shape can work
with the serializer properly.
I added an integration test for ActorReference as well, but no library
changes we needed for that, ActorId was the blocker.
Fixes: #446
`async void` is almost always a bug in server-side programming. If these
tests were doing any networking then they would encounter concurrency
bugs or crash in the event of an exception.
Co-authored-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
Makes sure we exclude the generated `coverage.json` files from git. We
don't want these to get accidentally committed if someone is running
coverage on their own machine.
Contributes to: #416
This change removes a mutable static instance - this is low-hanging
fruit design improvement and helps us make these features more flexible
in the future.
- remove references to specific VS versions (these will quickly become
stale and can be confusing because VS wants you to live on the latest
version).
- include mac/linux instructions
This is a hint to tools (and the CLI) about what version of the SDK is
required to work with the repo. This is set up to be as flexible as
possible. 3.1.100 is what's in our instructions already and is the
minimum version usable (since we target .NET Core 3.1).
This spooky XML boilerplate was needed on early versions of .NET Core,
but isn't required in modern versions (we require 3.1.1XX of the SDK
because we target .NET Core 3.1).
Removes generation of documentation files for samples and tests. This is
a vestige from using the older Stylecop tool in this repo, which needs
the doc files to inspect.
The deleterious effect of this is getting warnings about missing
documentation on samples, and forcing contributors and maintainers to
write nonsense comments to workaround the warning.
Also removed references to stylecop, since we no longer use it.
This is a workaround for https://github.com/dotnet/sdk/issues/14019
which prevents the current prerelease dotnet SDK
`5.0.100-rc.1.20452.10` from successfully building the repo.
Users attempting to build with the bugged release will see a compiler
error related to the `System.IO.Pipelines` assembly.
The explicit reference to `System.IO.Pipelines` is harmless long term,
but can be removed when the underlying bug is fixed and shipped in a GA
release (likely 5.0.100 GA).
* Prepping for multi pubsub
* Add pubsub name, some cleanup
* multi pubsub changes
Co-authored-by: Aman Bhardwaj <amanbha@microsoft.com>
Co-authored-by: LM <lemai>
* Add bulk get to client
* change params, return type, class to struct
* change IList to IReadOnlyList, make parallelism nullable
* change GetBulkItem to BulkStateItem
* Use protobuf packaging for the Any type
This pull request implements two converters which help with the type conversion between arbitrary types and the protobuf `Any` type. The C# protobuf library provides a mechanism to pack or unpack protobuf messages to `Any`. It provides the methods `Any.Pack` and `Any.Unpack` to serialize/deserialize messages based on `Google.Protobuf.IMessage`. For types that are not based on `Google.Protobuf.IMessage`, the existing JSON serialization/deserialization will be used.
I've also cleaned the existing codebase a little bit.
Fixes#268
* Fix suggested changes
* added missing dapr port parameter
added version number to 'add package' calls
* Calculator Sample
* Revert "Calculator Sample"
This reverts commit ec4b7af03b.
* add missing hyphen on port param
Co-authored-by: Garret Magin <garretm@microsoft.com>
* removed dll from `dotnet run` call
* updated version to `0.9.0-preview01`
* added note to use latest nuget version
Co-authored-by: Nico Meisenzahl <nico@meisenzahl.org>
Co-authored-by: André Ratzenberger <andre.ratzenberger@whiteduck.de>
Co-authored-by: Garret Magin <garretm@microsoft.com>
vinayada1
Dasith Wijesiriwardena
Ryan Nowak
Carlos Mendible
Aaron Crawfis
Charlie Stanley
Artur Souza
Nghia Tran
Young Bu Park
Edwin van Wijk
Mark Fussell
Sander Molenkamp
Leon Mai
Yaron Schneider
Gokhan Altinoren
Aman Bhardwaj
Christian Kaps
wdjhu