* Add `NewServiceWithGrpcServer` to gRPC service
Signed-off-by: pimmerks <pimmerks@users.noreply.github.com>
* Apply suggestion of not creating new variable
Signed-off-by: pimmerks <pimmerks@users.noreply.github.com>
---------
Signed-off-by: pimmerks <pimmerks@users.noreply.github.com>
* Adds context to rest of funcs, so context can always be propagated.
Signed-off-by: joshvanl <me@joshvanl.dev>
* Use separate interface for structs with context funcs
Signed-off-by: joshvanl <me@joshvanl.dev>
* Update proto to include actor state transaction metadata
Signed-off-by: joshvanl <me@joshvanl.dev>
* Adds `SetWithTTL` to actor state store manager
Signed-off-by: joshvanl <me@joshvanl.dev>
* Update actor client to support sending metadata. Supports `ttlInSeconds`
Signed-off-by: joshvanl <me@joshvanl.dev>
* Update actor example to use SetWithTTL with note that it should always
be used
Signed-off-by: joshvanl <me@joshvanl.dev>
* Update go modules
Signed-off-by: joshvanl <me@joshvanl.dev>
* Ignore deprecated use of `actor.Server` in `ActorContainer` interface
Signed-off-by: joshvanl <me@joshvanl.dev>
---------
Signed-off-by: joshvanl <me@joshvanl.dev>
* Adds context to rest of funcs, so context can always be propagated.
Signed-off-by: joshvanl <me@joshvanl.dev>
* Adds `//nolint:interfacebloat` to StateManager interface due to new
`xxxContext` methods.
Signed-off-by: joshvanl <me@joshvanl.dev>
* Use separate interface for structs with context funcs
Signed-off-by: joshvanl <me@joshvanl.dev>
* Adds more locks to actor functions
Signed-off-by: joshvanl <me@joshvanl.dev>
---------
Signed-off-by: joshvanl <me@joshvanl.dev>
* Various fixed and cleanups
1. Fixed SDK not compiling and tests failing
2. Increased minimum Go version to 1.18
3. Removed `github.com/pkg/errors` and `go.uber.org/atomic` - replaced with the standard library instead (the old packages have been added to the "depguard" linter)
4. Upgraded all dependencies
5. Upgraded golangci-lint to support Go 1.18+
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
* Do not wrap error if nil
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
* Run CI on Go 1.18 and 1.19
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
* Restore compatibility with Go 1.18
Looks like the newer methods were added in Go 1.19 only
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
* Should fix validate_examples CI
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
* Updated (most) deprecated Actions
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
* Fix helm repo
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
* Determine latest Dapr version in a better way
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
* Fix validate.sh
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
* return the specific error type of the actor state, caused by empty key or unmarshal fail
Signed-off-by: wangxw <996268132@qq.com>
* Update state_async_provider.go
change log level of state load
Signed-off-by: wXwcoder <996268132@qq.com>
Signed-off-by: wangxw <996268132@qq.com>
Signed-off-by: wXwcoder <996268132@qq.com>
* Add wait() method to block until Sidecar is up.
App might depend on sidecar right away. This PR adds a Wait() method to
enable app to wait for sidecar to be up before invoking the first call.
GRPC client creation on Dapr Go SDK is blocking, so waiting for client
readiness is less of a problem here than on SDKs where client
connection establishment is async.
Closes#287
Signed-off-by: Tiago Alves Macambira <tmacam@burocrata.org>
* Move Wait its own file.
If anything, this will make testing and the change more localized.
Signed-off-by: Tiago Alves Macambira <tmacam@burocrata.org>
* Adding unresponsive TCP and Unix servers and tests
Signed-off-by: Tiago Alves Macambira <tmacam@burocrata.org>
* Remove comments, clean code up
Signed-off-by: Tiago Alves Macambira <tmacam@burocrata.org>
* Remove a bit of code duplication on tests
Signed-off-by: Tiago Alves Macambira <tmacam@burocrata.org>
* Fix Wait and test server setup.
* Multiple state changes can happen for a single GRPC Connection.
previous code assume a single one and was failing miserably. Fixed.
* The logic for the test server's tear down was lacking. Fixed
Signed-off-by: Tiago Alves Macambira <tmacam@burocrata.org>
* Rename on aux. method
Signed-off-by: Tiago Alves Macambira <tmacam@burocrata.org>
* Add link to gRPC documentation about connectivity semantics
Signed-off-by: Tiago Alves Macambira <tmacam@burocrata.org>
* Fixing lint errors
Signed-off-by: Tiago Alves Macambira <tmacam@burocrata.org>
* Fixing more lint errors
Signed-off-by: Tiago Alves Macambira <tmacam@burocrata.org>
Signed-off-by: Tiago Alves Macambira <tmacam@burocrata.org>
In the state API there's an existing DeleteStateWithETag() convenience
function but there does not appear to be an equivalent
SaveStateWithETag(). This commit adds SetStateWithETag() so that
consumers of the SDK don't have to employ the more verbose
SaveBulkState() when they only need to update a singular item.
Client code updating a single item with an etag prior to this commit
looks like:
--
item := &dapr.SetStateItem{
Etag: &dapr.ETag{
Value: "deadbeef",
},
Key: "order_1",
Value: []byte(data),
}
err := client.SaveBulkState(ctx, store, item)
--
Client code after this commit can reduce to:
--
err := client.SaveStateWithEtag(ctx, store, "order_1", []byte(data), "deadbeef")
--
Signed-off-by: Mike Brown <github@torvosoft.com>
Signed-off-by: Mike Brown <github@torvosoft.com>
I was debugging a panic in a local application I was developing and noticed this issue. A validation failure isn't correctly handled as a failure, and we insert a nil value into the map. This value in this map is later dereferenced, resulting in the following panic:
```
http: panic serving 127.0.0.1:45598: runtime error: invalid memory address or nil pointer dereference
goroutine 248 [running]:
net/http.(*conn).serve.func1()
/home/linuxbrew/.linuxbrew/Cellar/go/1.19.1/libexec/src/net/http/server.go:1850 +0xbf
panic({0x9558a0, 0xe4d7c0})
/home/linuxbrew/.linuxbrew/Cellar/go/1.19.1/libexec/src/runtime/panic.go:890 +0x262
github.com/dapr/go-sdk/actor/manager.(*DefaultActorContainer).Invoke(0xc0000be810, {0xc000048126?, 0x9?}, {0xc0003fc000, 0x4, 0x200})
/home/cgillum/go/pkg/mod/github.com/dapr/go-sdk@v1.5.0/actor/manager/container.go:75 +0x299
github.com/dapr/go-sdk/actor/manager.(*DefaultActorManager).InvokeMethod(0xc000112300, {0xc000048115?, 0xc0000a3888?}, {0xc000048126, 0x4}, {0xc0003fc000, 0x4, 0x200})
/home/cgillum/go/pkg/mod/github.com/dapr/go-sdk@v1.5.0/actor/manager/manager.go:92 +0xb2
github.com/dapr/go-sdk/actor/runtime.(*ActorRunTime).InvokeActorMethod(0xa?, {0xc00004810c?, 0x7f71edd544a0?}, {0xc000048115, 0x9}, {0xc000048126, 0x4}, {0xc0003fc000, 0x4, 0x200})
/home/cgillum/go/pkg/mod/github.com/dapr/go-sdk@v1.5.0/actor/runtime/actor_runtime.go:75 +0xba
github.com/dapr/go-sdk/service/http.(*Server).registerBaseHandler.func4({0xad7298, 0xc0003b0000}, 0xc0004e4100)
/home/cgillum/go/pkg/mod/github.com/dapr/go-sdk@v1.5.0/service/http/topic.go:112 +0x1be
net/http.HandlerFunc.ServeHTTP(0xc0004e4000?, {0xad7298?, 0xc0003b0000?}, 0x800?)
/home/linuxbrew/.linuxbrew/Cellar/go/1.19.1/libexec/src/net/http/server.go:2109 +0x2f
github.com/gorilla/mux.(*Router).ServeHTTP(0xc000218240, {0xad7298, 0xc0003b0000}, 0xc0003b4600)
/home/cgillum/go/pkg/mod/github.com/gorilla/mux@v1.8.0/mux.go:210 +0x1cf
net/http.serverHandler.ServeHTTP({0xad62e8?}, {0xad7298, 0xc0003b0000}, 0xc0003b4600)
/home/linuxbrew/.linuxbrew/Cellar/go/1.19.1/libexec/src/net/http/server.go:2947 +0x30c
net/http.(*conn).serve(0xc0000001e0, {0xad7a00, 0xc00012b380})
/home/linuxbrew/.linuxbrew/Cellar/go/1.19.1/libexec/src/net/http/server.go:1991 +0x607
created by net/http.(*Server).Serve
/home/linuxbrew/.linuxbrew/Cellar/go/1.19.1/libexec/src/net/http/server.go:3102 +0x4db
```
The issue appears to be the error handling logic, which I've fixed in this PR.
Signed-off-by: Chris Gillum <cgillum@gmail.com>
Signed-off-by: Chris Gillum <cgillum@gmail.com>
* add distributed lock api support
Signed-off-by: yaron2 <schneider.yaron@live.com>
* go mod tidy for pub/sub
Signed-off-by: yaron2 <schneider.yaron@live.com>
* go mod tidy for state
Signed-off-by: yaron2 <schneider.yaron@live.com>
* go mod tidy for service invocation
Signed-off-by: yaron2 <schneider.yaron@live.com>
* linter
Signed-off-by: yaron2 <schneider.yaron@live.com>
* added unlock tests
Signed-off-by: yaron2 <schneider.yaron@live.com>
* Update golangci-lint-action
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
* Use the correct go version
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Yaron Schneider
hunter007
Hannah Hunter
Josh van Leeuwen
Alessandro (Ale) Segala
Pim Merks
dependabot[bot]
Taction
Shivam Kumar
Shubham Sharma
jackycsl
Roberto Rojas
Joni Collinge
longshine
Sam
wXwcoder
Tiago Alves Macambira
HaoTian
yellow chicks
mikeb26
Chris Gillum
Ceres Cartman
Josh
thielepaul