* okhttpclient is mocked
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* mock workflowRuntime to rm log: 'The sidecar at address localhost:4001 is unavailable. Will continue retrying.'
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* fix several NetworkUtilsTest orphaned channels
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* reset workflow changes since I still see the log output
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* Close daprClient on DaprClientGrpcTelemetryTest
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* try latest runtime rc
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* Update runtime to 1.12.4
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Mvn test is now verbose, temporatily.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* try fixing RetryPolicyTest
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* comment out RetryPolicyTest
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* add RetryPolicyTest back
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* trying to figure out which test func is the issue
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* try ubuntu-20.04
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* try rm-ing GrpcChannelFacadeTest
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* try rm-ing DaprClientHttpTest
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* try t.join just in case
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* is this the bad test?
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* are these other healthcheck tests the problem?
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* is it the ok test?
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* is it due to an invoke test?
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* is it the config/subscribeConfig tests
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* is it noHotMono?
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* is it a publish test?
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* is it the other noHotMono tests?
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* is it a state test?
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* is it a save state test?
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* is it a secret test?
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* is it a delete state test?
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* is it the rest -1 and - ending tests?
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* no client calls, only end of file remaining
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* add teardown - did it work?
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* is it just needing daprClientHttpXML to be closed?
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* Reuse mock and builder.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Try dedicated executor.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Comment out the remaining tests.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Remove before and after.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Remove sdk/src/test/java/io/dapr/client/DaprClientHttpTest.java
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Remove sdk/src/test/java/io/dapr/client/DaprHttpTest.java.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Delete a batch of tests.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* restore deleted test files
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* add back in RetryPolicyTest
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
---------
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Co-authored-by: Artur Souza <asouza.pro@gmail.com>
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
* add support for java17
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* upgrade spotbugs-maven-plugin version to support jdk17
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* add clean before install
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* add clean in mvn command
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* rollback spotbugs-maven-plugin version to 4.1.4
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* add jdk17 in build
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* update to support jdk17
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* remove jdk versions earlier than jdk17
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* remove springboot 2.3 and 2.4 because they don't support jdk17
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* update to jdk17
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* update maven plugin versions to support jdk17
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* temporarily ignoring checking after upgrade to new spotbugs version to support jdk17
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* use the same version of maven-failsafe-plugin
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* hard code maven-failsafe-plugin version to 3.2.2
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* set sourceDirectory of checkstyle plugin to only check the sources directory, not test source and generated source
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* set release to jdk17 in examples subproject
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* update to springboot 3.0
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* add springboot 3.0.13 in springboot version matrics
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* upgrade to springboot 3.0.13 in sdk-tests
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* remove Nullable annotation
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* force opentelemetry-sdk-metrics dependencies to be version 0.14.0
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* jakarta.servlet is needed for dapr compatibility for spring boot versions before 3.0
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* update code to run with jakarta.servlet and javax.servlet
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* update jakarta.annotation to latest version
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* add javax.annotation
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* trigger ci
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* revert back to using 3.0 version of the github action
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* revert back to use jdk11 for vallidate
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* jdk17 is required for vallidate
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* trigger ci
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* use jdk17 to validate
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* remove java8 support
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* use jdk11 to test springboot2.x and jdk17 to test springboot3.0
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* rollback to jdk17 to test for springboot2.x
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* rename springboot30 to springboot3
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* skip mvn test in mvn install
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* add more exclude for spotbugs
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* add more exclude for spotbugs
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* set java source and target to 17 in sdk-tests
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* rollback root pom.xml to remove sdk-tests module
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* exclude logback to avoid conflicts
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* replace ctx.getLogger() with sysout
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* update stdout line according to source code
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* rollback validate line, replace ctx.getLogger() with system out in wofklow
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* rollback example code for subworkflow
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* print ctx.getLogger() and instanceId for debug
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* rollback to not exclude logback
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* add slf4j as compile dependency and upgrade its version to 2.0.9
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* print the logger implementation class
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
* remove debug code
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
---------
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
* set upload-artifact to old version
Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com>
* use distinct artifact names
Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com>
---------
Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com>
* Update Dapr runtime to 1.12 RC.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Add socket wait for ToxiProxy client.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Changing ambiguity in service Id for TracingIT tests.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* More assertions to SDKResiliencyIT.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Add sidecar wait for TracingIT.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Wait for Zipkin endpoint.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Tacking flakiness on MethodInvokeIT and TracingIT.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Test again with 1.11.0 CLI.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Start bisect 1.12 regression.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Bisect step for runtime at 34c5102600b5a39704089b72db565ca95943269d
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* bisect step for runtime at ad5618711830510617e1b8fb2d0c6758f14ff6b9
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* bisect step for runtime at 4e5c51be62d8a7319ab25a401681ba82bd3ef7e7
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* git bisect step for runtime at 3143f2fcb679e585d978e9b9d706cce72088fecc
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* git bisect step for runtime at d243d1c6a17b019e0435ebbc10abb00810beb29a
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* git bisect step for runtime at 2ddb99be5ae61abd9f7f3616987fcfda0cedbc6e
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* git bisect step for runtime at 0fdab70eb32a63dd2630c39c4b1bc623212cd099
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* git bisect step for runtime at b42319279f21ee5c63d5cd04bfef6e94897cf34f
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Verify first bad commit at runtime: 0fdab70eb32a63dd2630c39c4b1bc623212cd099
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Trying artursouza/dapr at 37ca4c81041de11677ddea101298ca3c2ad8585d
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Add delay of 10s on MethodInvokeService for IT.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Trying dapr at artursouza's fork at 65e117433284388535f5a967456611a72773cf6b
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Change MethodInvokeService to use AppHealthCheck.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Change TracingIT to use AppHealthCheck.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Change to use artursouza's fork at f770694b3fbf7222c162a4ee4e13818a5afc3b01
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Remove use of artursouza's fork for runtime.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Fix MethodInvokeIT to actually use AppHealthCheck.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Try fix in runtime: artursouza/dapr at 72b6f7374a670c3054427aa2b01d2374e3bc3329
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Trying runtime as per artursouza at 64d19957059d134378603630165b3e473bdde388
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Increase delay to avoid race condition for app health checks.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Try runtime at artursouza at d2eb15d1707ff8539ff1561a1fd67750d205854b
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Update to 1.12.0-rc.5
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
---------
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
* Implement retry and timeout policy for gRPC client.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Fix invoke actor after aborted flow.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
---------
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Bump from spring boot 2.3.5.RELEASE to 2.7.8
Signed-off-by: Sergio <champel@gmail.com>
(cherry picked from commit 9152c91bc1f08ecf2dd3bccf8159fd5d0500e351)
* Ensure old versions of spring boot are still compatible
Signed-off-by: Sergio <champel@gmail.com>
---------
Signed-off-by: champel <champel@gmail.com>
Signed-off-by: Sergio <champel@gmail.com>
* Use app health check in ITs to minimize flakiness.
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
* Fix DaprRun and update Dapr runtime ref.
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
* Add retry logic to tracing example's validation
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
* Printing validation steps.
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
* Change retry logic for tracing it
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
* Updare Dapr ref.
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
* Revert secret.json
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
* Add gRPC HealthCheck.
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
* Change expectations for invoke tests.
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
* Fix typo causing compilation error.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Update Dapr ref to latest master.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Fix binding and method invoke ITs.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Add wait time to reduce flakiness of ApiIT.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Re-enable health-check.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Remove AppHealth as it breaks actor ITs.
Signed-off-by: Artur Souza <artur.barbalho@outlook.com>
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <artur.barbalho@outlook.com>
* Update Dapr and CLI to 1.9 RC1
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
* Fix HTTP service invocation without content-type.
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
* Update RCs.
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
* run IT test for long values
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* Fix the class name
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* assert for all messages and fix class name
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* test for Long.MAX_VALUE
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* revert back long number and print
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* fix the typo
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* update the latest dapr commit in workflow files
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* log some more data to debug
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* debug
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* get the value from messages
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* address feedback
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* change the assertion
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* Add hashcode and equals functione and create new obj while adding value to set
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* move iterator
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* log value before adding to hashset
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* log value before adding to hashset
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* log value before adding to hashset
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* change assertion
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* fix equals method
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* adding debugging for expected value
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* adding logs for expected value
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
* log value before adding to hashset
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
* Query State Preview API implementation.
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
* Use latest dapr ref and fix grpc query state api
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
* fix service invocation automatic unesacpe
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
* add more unit tests
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
* Add query state API docs
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
* Fix example to be user friendly
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
* Fix example in docs
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
* make pagination immutable
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
* Update CLI and runtime to 1.6.0-rc.x
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
* Upgrade the version to 1.5.0-SNAPSHOT
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
* Update LICENSE to Apache 2.0
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
* Update headers to Apache 2.
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
* Upgrade Mockito to latest version
* Run GitHub Actions on Java 11 and 16
* Run JUnit tests with `--add-opens java.base/java.util=ALL-UNNAMED`
* Move Surefire JVM arguments to Maven property
* Update build.yml
* Update validate.yml
* simplily build singleton dapr http (#590)
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
* Add Automerge workflow (#605)
* Add Automerge workflow
The automerge workflow will check for complete and approved pull requests and will merge them automatically.
Sources:
- For the python script to execute the merge: https://raw.githubusercontent.com/dapr/dapr/master/.github/scripts/automerge.py (only changed the label from "automerge" to "auto-merge")
- https://raw.githubusercontent.com/dapr/dapr/master/.github/workflows/dapr-bot-schedule.yml (only copied the automerge part, not the prune_stale part as that was not part of the issue.
Resolves https://github.com/dapr/java-sdk/issues/603
* Update automerge-bot.yml
* Update automerge-bot.yml
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
* Cleanup Maven POM files (#604)
Added fixed versions for maven-deploy-plugin & spring-boot-maven-plugin as this would otherwise break in a future maven version.
Also fixed some indenting and removed duplicate declarations.
Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com>
* Add support for @PostMapping("/path") to pub/sub topic subscriptions (#583)
* Remove duplicate dependency
* Transform into managed dependencies
* Remove old JUnit version from dependencies
* Add tests for DaprBeanPostProcessor
* Also register PostMappings that use value
* Modify existing pub/sub test to no use @PostMapping(path="...")
* Remove added dependencies on AssertJ, Spring Test and Servlet API
* Remove test in favour of the sdk-tests one
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
* Run JUnit tests in all modules with java.base/java.util and java.base/java.lang opened to all modules
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Co-authored-by: 浩 <inf2inf2@outlook.com>
Co-authored-by: Tom Cools <tom.cools@live.be>
Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com>
* Refactor order of params for State class.
* Example for unit testing.
* Change toString() for State class.
* Add unittesting example to main README.
* Fix cmd for unittesting example.
* Add sleep to http inputing binding example validation.
* Fix unittesting example check.
https://nvd.nist.gov/vuln/detail/CVE-2020-15228 advises that setenv
and add-path are not secure, so they will be disabled very shortly on
workflows. This changes set-env to the recommended upgrade.
Cassie Coyle