DEV: Resolve small TODOs; fix a typo (#296)

plugin.rb

@@ -37,14 +37,9 @@ after_initialize do
   require 'assigner'
   require 'pending_assigns_reminder'
 
-  # TODO: Drop when Discourse stable 2.8.0 is released
+  register_group_param(:assignable_level)
-  if respond_to?(:register_group_param)
+  register_groups_callback_for_users_search_controller_action(:assignable_groups) do |groups, user|
-    register_group_param(:assignable_level)
+    groups.assignable(user)
-  end
-  if respond_to?(:register_groups_callback_for_users_search_controller_action)
-    register_groups_callback_for_users_search_controller_action(:assignable_groups) do |groups, user|
-      groups.assignable(user)
-    end
   end
 
   reloadable_patch do |plugin|

spec/lib/assigner_spec.rb

@@ -9,16 +9,6 @@ RSpec.describe Assigner do
   let(:pm_post) { Fabricate(:private_message_post) }
   let(:pm) { pm_post.topic }
 
-  # TODO later remove that stuff
-  def assert_publish_topic_state(topic, user)
-    message = MessageBus.track_publish("/private-messages/assigned") do
-      yield
-    end.first
-
-    expect(message.data[:topic_id]).to eq(topic.id)
-    expect(message.user_ids).to eq([user.id])
-  end
-
   context "assigning and unassigning" do
     let(:post) { Fabricate(:post) }
     let(:topic) { post.topic }
@@ -118,8 +108,8 @@ RSpec.describe Assigner do
       expect(assigned_to?(another_mod)).to eq(true)
     end
 
-    def assigned_to?(asignee)
+    def assigned_to?(assignee)
-      assigner.assign(asignee).fetch(:success)
+      assigner.assign(assignee).fetch(:success)
     end
 
     it "doesn't assign if the user has too many assigned topics" do