discourse
/
discourse-assign
mirror of https://github.com/discourse/discourse-assign.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

UX: simplify markup to fix j/k highlighting (#516) 

This cleans up the markup a bit, so instead of a `div` as a table child we use the `td` and removes the internal wrapper. This fixes an issue with a double highlight while using j/k navigation highlighting caused by the nested `td`.
This commit is contained in:
Kris 2023-10-19 20:40:55 -04:00 committed by GitHub
parent 92b0dd530b
commit 7fe45c8eb5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
assets/javascripts/discourse/components/assigned-topic-list-column.gjs
View File

@ -5,7 +5,6 @@ import { action } from "@ember/object";
export default class AssignedTopicListColumn extends Component { export default class AssignedTopicListColumn extends Component {
<template> <template>
<td class="topic-list-data">
{{#if @topic.assigned_to_user}} {{#if @topic.assigned_to_user}}
<AssignActionsDropdown <AssignActionsDropdown
@topic={{@topic}} @topic={{@topic}}
@ -24,7 +23,6 @@ export default class AssignedTopicListColumn extends Component {
{{else}} {{else}}
<AssignActionsDropdown @topic={{@topic}} @unassign={{this.unassign}} /> <AssignActionsDropdown @topic={{@topic}} @unassign={{this.unassign}} />
{{/if}} {{/if}}
</td>
</template> </template>
@service taskActions; @service taskActions;

2
assets/javascripts/discourse/raw-views/assign-topic-buttons.gjs
View File

@ -12,7 +12,7 @@ export default class extends EmberObject {
if (ASSIGN_LIST_ROUTES.includes(this.router.currentRouteName)) { if (ASSIGN_LIST_ROUTES.includes(this.router.currentRouteName)) {
return rawRenderGlimmer( return rawRenderGlimmer(
this, this,
"div.assign-topic-buttons", "td.assign-topic-buttons",
<template><AssignedTopicListColumn @topic={{@data.topic}} /></template>, <template><AssignedTopicListColumn @topic={{@data.topic}} /></template>,
{ topic: this.topic } { topic: this.topic }
); );