DEV: Remove unused `assignUser` action (#483)

This commit is contained in:
Jarek Radosz 2023-06-30 19:18:15 +02:00 committed by GitHub
parent 2bff29e919
commit f89420d00e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 44 deletions

View File

@ -126,20 +126,7 @@ export default class AssignUser extends Controller.extend(ModalFunctionality) {
}
@action
assignUser(name) {
this.setGroupOrUser(name);
if (name) {
return this.assign();
}
}
@action
assignUsername(selected) {
this.setGroupOrUser(selected.firstObject);
}
setGroupOrUser(name) {
assignUsername([name]) {
this.set("assigneeError", false);
this.set("model.allowedGroups", this.taskActions.allowedGroups);

View File

@ -5,7 +5,7 @@
<AssigneeChooser
autocomplete="off"
@value={{this.assigneeName}}
@onChange={{action "assignUsername"}}
@onChange={{this.assignUsername}}
autofocus="autofocus"
@showUserStatus={{true}}
@options={{hash

View File

@ -7,35 +7,6 @@ import { getOwner } from "discourse-common/lib/get-owner";
module("Unit | Controller | assign-user", function (hooks) {
setupRenderingTest(hooks);
test("assigning a user via suggestions makes API call and closes the modal", async function (assert) {
pretender.get("/assign/suggestions", () =>
response({
suggestions: [],
assign_allowed_on_groups: ["nat"],
assign_allowed_for_groups: [],
})
);
pretender.put("/assign/assign", () => response({}));
let modalClosed = false;
const controller = getOwner(this).lookup("controller:assign-user");
controller.setProperties({
model: {
target: EmberObject.create({}),
},
allowedGroupsForAssignment: ["nat"],
taskActions: { allowedGroups: [] },
});
controller.set("actions.closeModal", () => {
modalClosed = true;
});
await controller.assignUser("nat");
assert.true(modalClosed);
});
test("assigning a user by selector does not close the modal", async function (assert) {
pretender.get("/assign/suggestions", () =>
response({