Commit Graph

901 Commits

Author SHA1 Message Date
Roman Rizzi b256d462bf
DEV: use group ids to allow assign on groups (#38)
* DEV: use group ids to allow assign on groups

* FIX: Dinamically sets the default value to support older versions
2019-07-16 11:33:04 -03:00
Neil Lalonde 439ebf44ec Update translations 2019-07-15 14:00:07 -04:00
Gerhard Schlager 6d44f4fe29 FIX: Send assignment message in the notified user's locale 2019-07-12 12:08:22 +02:00
Dan Ungureanu dea72e708b FIX: Skip enqueuing reminders if no groups are allowed. (#39)
* FIX: Skip enqueuing reminders if no groups are allowed.

With an empty SiteSetting.assign_allowed_on_groups, it used to generate
an invalid query containing "group_users.group_id IN ()".
2019-07-10 09:58:35 +02:00
Bianca Nenciu 22129d191f
UX: In mobile view show button only under topic controls. (#35) 2019-06-25 16:05:09 +03:00
Sam Saffron e4be0f02b7 Revert "Staff is always allowed to assign (#36)"
This reverts commit bb200f5fbd.
Unfortunately that commit broke assign
2019-06-18 16:00:10 +10:00
Neil Lalonde e1cc07adb1 Update translations 2019-06-17 13:56:40 -04:00
Roman Rizzi bb200f5fbd
Staff is always allowed to assign (#36) 2019-06-17 10:11:00 -03:00
Joffrey JAFFEUX 5bbca9b925 DEV: new API s/replaceCurrentUser/updateCurrentUser 2019-06-14 14:38:10 +02:00
Joffrey JAFFEUX fe80298ae5 FIX: prevents messageBus subscriptions to leak 2019-06-12 10:20:34 +02:00
Neil Lalonde 2aaa5a920f Update translations 2019-06-10 10:38:24 -04:00
Joffrey JAFFEUX d9178cf60c FIX: new select-kit test-helper 2019-06-06 09:34:42 +02:00
Sam Saffron fe746fefc0 PERF: remove N+1 query from assign
Also makes looking for allowed groups much more
efficient
2019-06-05 11:03:29 +10:00
Roman Rizzi f312ece4a9
Feature: Allow assign on groups (#31)
* Feature: Allow assign on groups

* Use type: group_list option

* Track group changes and update the setting accordingly. Restrict reminders frequency to assign allowed users instead of staff
2019-06-04 09:21:33 -03:00
Neil Lalonde 8536795da3 Update translations 2019-05-30 11:30:37 -04:00
romanrizzi deea8b59bc FIX: Only show override options to admins 2019-05-27 13:45:54 -03:00
Roman Rizzi abe8142038
FEATURE: Users can override reminders frequency (#30)
* FEATURE: Users can override reminders frequency

* Changes:
- Avoid creating a user custom field when the used didn't override the frequency
- Sanitize frequency value using coercion
- Minor fixes

* Sanitize query and user query single
2019-05-27 10:53:37 -03:00
romanrizzi a0031d596a Remove unused imports 2019-05-15 16:24:14 -03:00
romanrizzi 8ca446eeed Make rubocop happy and use defined? when checking for reviewable_api_enabled 2019-05-15 16:18:24 -03:00
romanrizzi c882b097f8 Remove 'Unassign All' feature 2019-05-15 15:57:28 -03:00
Régis Hanol 615ad7c5c3
FIX: don't 'return' in 'flag_reviewed' block 2019-05-15 12:50:52 +02:00
Roman Rizzi 4b7a99f017
Disable flagging behaviour in favor of the new reviewable API (#34) 2019-05-14 16:29:50 -03:00
romanrizzi b4148a8858 Fix template indentation 2019-05-13 17:18:36 -03:00
Guo Xiang Tan 8fca0f61e8 Add frozen string literal comment to files. 2019-05-13 10:30:21 +08:00
Roman Rizzi 2f5af6e2cb FIX: Add a custom mobile view for the assigned-topics-list (#33) 2019-05-09 10:53:45 +10:00
romanrizzi 1eaeb39749 DEV: Add simple acceptance smoke test for the assigned topics list 2019-05-08 18:09:36 -03:00
Roman Rizzi f330120f90
Assigned topics are now ordered by topics.bumped_at (#32) 2019-05-07 12:43:47 -03:00
Régis Hanol 578a7f7b70 UX: slightly more space right to the PM icon 2019-05-07 09:55:22 +02:00
Roman Rizzi e3b2e5bdb6 FEATURE: Display PMs in assigned activity and differentiate them. (#27)
* FEATURE: Display PMs in assigned activity and differentiate them.

* FEATURE: Unassign/Re-assign tasks from the activity view

* Remove bulkAssign. Reuse assign/unassign with a service. Change PM icon position

* Reuse ListItemDefaults instead of duplicating code.

* Conditionally show/hide feature if list items defaults is present in core
2019-05-07 16:30:47 +10:00
Sam Saffron f5a19501cc DEV: correct spec to meet new design
We now allow self assigns unlimited, but limit
other people once you reach limit
2019-05-03 13:48:43 +10:00
Sam Saffron 96f965ef89 FIX: correct translation key 2019-05-03 11:29:49 +10:00
Sam Saffron 6f031f5432 FIX: correctly count assigned topics for user
Previously we were looking at deleted topics
2019-05-03 11:24:16 +10:00
Roman Rizzi 8583287faf
FEATURE: Limit the amount of assigned topics an user can have. (#29)
* FEATURE: Limit the amount of assigned topics an user can have.

* Do not enfore the limit when self-assigning

* Avoid computing the query when self-assigning. Do not count self-assigns when enforcing the limit
2019-05-02 10:44:11 -03:00
Guo Xiang Tan fa5202049e Remind scheduled job only needs to run once a day. 2019-04-30 13:43:09 +08:00
Guo Xiang Tan 8b06b7cb4c FIX: Only send reminders to moderators and admins. 2019-04-30 12:00:59 +08:00
Guo Xiang Tan 760d331f42 Make remind assignment off by default. 2019-04-30 11:26:58 +08:00
Guo Xiang Tan 65c0b3c192 FIX: Don't count deleted topic in assignment count. 2019-04-30 11:23:13 +08:00
Guo Xiang Tan 1af202142b Fix incorrect link to assigned activity. 2019-04-30 11:08:28 +08:00
Guo Xiang Tan 00a9cb1752 Fix invalid arguments passed to `find_by`. 2019-04-30 09:56:06 +08:00
Roman Rizzi 7b7432990a FEATURE: Remind users of assigned tasks. (#28)
* FEATURE: Remind users of assigned tasks.

* User an user custom field instead of adding a new column

* Improve tests. fix assigns count and display oldest assigned topics correctly. Do not remind about recently assigned tasks
2019-04-30 10:02:26 +10:00
Kris 4625108888 FIX: class for wrapper changed 2019-04-19 13:57:09 -04:00
Neil Lalonde 3cba747919 Update translations 2019-04-05 10:10:20 -04:00
Joffrey JAFFEUX 046f1db466 FIX: adds auto-route to avoid losing queryParams on successive clicks 2019-03-28 11:34:31 +01:00
Joffrey JAFFEUX 0f6faa9fc3 FIX: ember 3 support (#23) 2019-03-15 18:49:41 +01:00
Bianca Nenciu 801b1cd48c FIX: Check if topic is assigned before assigning again. (#25) 2019-03-15 18:49:22 +01:00
Neil Lalonde f45a51fa4c Update translations 2019-03-04 10:13:42 -05:00
Neil Lalonde bd3225b54a Update translations 2019-01-31 16:32:52 -05:00
Joffrey JAFFEUX 5c48ec5925 DEV: prettier/eslint 2019-01-11 17:33:51 +01:00
Gerhard Schlager 5527457ce2 FIX: Do not unassign on topic open 2019-01-10 20:58:20 +01:00
Bianca Nenciu 89f794cf83 FEATURE: Add events for assigning and unassigning topics. (#24) 2019-01-09 16:59:26 +11:00