Commit Graph

75 Commits

Author SHA1 Message Date
Jarek Radosz 1c079b792b
DEV: Use the new component-based modal API (#489)
Co-authored-by: David Taylor <david@taylorhq.com>
2023-07-11 10:37:57 +02:00
Isaac Janzen 41f62d9ea9
DEV: Convert dismiss modal to component-based API (#481) 2023-07-06 12:14:36 -05:00
Jarek Radosz 47a1170ec5
DEV: Merge js dirs; prefix tests (#484) 2023-07-03 17:28:02 +02:00
Jarek Radosz f89420d00e
DEV: Remove unused `assignUser` action (#483) 2023-06-30 19:18:15 +02:00
Jarek Radosz 2bff29e919
DEV: Modernization/cleanup (#480)
* Component template colocation
* Native classes
* glimmer plugin connector
* `this.` in templates
* `?.` operator
* Merged `withPluginApi` calls
* Updated deps
2023-06-22 10:06:37 +02:00
Jarek Radosz c5e0c2c0b3
DEV: Don't use renderTemplate (#469)
See: https://github.com/discourse/discourse/pull/21517
2023-05-19 11:00:56 +02:00
Keegan George f75a6a8354
DEV: Remove `redesigned_user_menu_enabled: true` in tests (#470) 2023-05-17 13:47:30 -07:00
Keegan George 310fb80e54
DEV: Remove old user menu related code (#464) 2023-05-10 15:34:08 -07:00
Kris 9bbd1e8321
UX: clearer assign messages on first post (#452) 2023-03-14 10:19:39 -04:00
Alan Guo Xiang Tan 460223d7e6
DEV: Remove viewing personal messages test on old user navigation menu (#439)
Core is moving towards the redesigned user page navigation menu so the
old test is no longer required.
2023-02-02 15:44:57 +08:00
Bianca Nenciu a4ce90e855
UX: Improve assign modal design (#403)
Implements a new design that improves the user experience:

- add a clear cancel button
- add an indication the note is optional
- change the plus icon to a search icon
- show an error when the user tries to assign without choosing an assignee
- move suggestions to default search results
- focus search input when modal is displayed
2022-12-21 14:49:24 +02:00
Alan Guo Xiang Tan feca27b6bd
FEATURE: Make plugin compatible with redesigned user messages (#399) 2022-12-07 06:22:14 +08:00
Martin Brennan 7ec6c78aa2
DEV: Fix test for core change (#389)
This slight core change breaks this test

https://github.com/discourse/discourse/pull/18691
2022-10-21 14:16:41 +10:00
Jarek Radosz 5eee863d01
DEV: Clean up tests (#388) 2022-10-07 10:51:37 +02:00
Bianca Nenciu af146fea54
FIX: Show group icon for group notifications (#384)
The same "user-plus" icon was used for both user and group assigned
notifications.
2022-10-03 21:13:34 +03:00
Osama Sayegh cef3d23766
DEV: Make the assign tab in the user menu link to the assign page (#380)
As of 12ebdf0ff0, it's possible to make tabs in the experimental user menu link to a page when they're clicked on when they're active. This commit makes the assign tab links to `/my/activity/assigned` when it's active.
2022-09-19 17:11:37 +03:00
Krzysztof Kotlarek 0d586bb93c
FIX: use grouped_unread_notifications (#373)
Use `grouped_unread_notifications` instead of `grouped_unread_high_priority_notifications`

Related PR: https://github.com/discourse/discourse/pull/18132
2022-08-31 11:16:13 +10:00
Osama Sayegh 7b08ab425c
DEV: Apply model transformations for the assigns list in the experimental user menu (#372) 2022-08-26 13:33:25 +08:00
Osama Sayegh e6e222d8bc
FEATURE: Add assigns tab to the experimental user menu (#366)
This commit adds a tab for assignments in the experimental user menu. The assignments tab behaves very similarly to the bookmarks and messages tab in core: it displays the user's unread assign notifications first and then fills the rest of available space in the menu with assignments (same content that the current user menu displays).

More details of the experimental user menu can be found in https://github.com/discourse/discourse/pull/17379.
2022-08-17 11:57:15 +03:00
Rafael dos Santos Silva 7a2fde72c6
FEATURE: Assign Status (#363)
Adds a new plugin setting that when enabled adds a status field for every assignment. This setting defaults to off.

The possible status for an assignment are customizable via yet another new setting, and the first one on this list will be the default status for new assignments.

The status is not yet show anywhere except the assign modal and the small action posts in topics at the moment. Adding status to the assignment list for users and groups will be handled in the near future.


Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>
2022-08-04 14:50:18 -03:00
Rafael dos Santos Silva 9f514a50ca
DEV: Add acceptance tests for assignment notifications (#307)
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
2022-07-26 16:31:59 -03:00
Alan Guo Xiang Tan 148b4b0089
Revert "FEATURE: Register assigned link under sidebar topics section. (#341)" (#359)
This reverts commit 959525b079.

Product design to drop from Sidebar
2022-07-22 15:40:05 +08:00
Jarek Radosz 0adea550c0
DEV: Fix leaky tests (#358) 2022-07-21 03:41:32 +02:00
Alan Guo Xiang Tan 86141dfe3d
Revert "UX: Don't display assign user menu glyph when sidebar is enabled (#356)" (#357)
This reverts commit 479fcfb411.

Link in user menu dropdown is kept in favor of link in experimental
sidebar
2022-07-08 15:44:45 +08:00
Alan Guo Xiang Tan 479fcfb411
UX: Don't display assign user menu glyph when sidebar is enabled (#356)
Assignments can already be accessed via sidebar.
2022-07-05 15:50:46 +08:00
Isaac Janzen 507060b7f1
DEV: Remove isLegacyEmber (#355) 2022-06-23 11:06:16 -05:00
Natalie Tay 1ef8e70314
FIX: Don't reuse assign note when reassigning (#351) 2022-06-18 01:35:58 +08:00
Alan Guo Xiang Tan 959525b079
FEATURE: Register assigned link under sidebar topics section. (#341) 2022-05-26 09:13:40 +08:00
Natalie Tay 6db2e0991b
FIX: Only assign when suggestion is clicked (#334) 2022-05-12 20:55:37 +08:00
Natalie Tay 5503499514
FIX: Assigning a user without notes assigns and closes the modal (#329) 2022-05-11 16:17:33 +08:00
Natalie Tay b314882a6b
FEATURE: Show note in tooltip (#327) 2022-05-05 15:04:57 +08:00
Natalie Tay 21d89179ea
FIX: Hide footer action button when user cannot assign (#319) 2022-04-26 15:00:00 +08:00
Jarek Radosz 264620985e
DEV: Lose the es6 suffix (#298) 2022-03-05 17:19:50 +01:00
David Taylor ffe95da7ed DEV: Set user attributes earlier in test 2022-01-25 15:02:24 +00:00
Krzysztof Kotlarek 1a1dffc5e8
FEATURE: active flag for assignments (#264)
When topic is closed, we mark assignments as "inactive". Then when it is reopen and setting reassign_on_open is enabled, we bring back previous assignments.

We were already using custom fields for archive message and move to inbox. I changed custom fields solution to use active flag on Assignment model
2021-12-13 08:36:14 +01:00
Natalie Tay 3d2a9d1e87
Show custom topic tracking message when the user 'never' automatically tracks topics and gets assigned (#249)
* Show more precise topic tracking message when the user never tracks any topics and gets assigned
2021-11-18 09:44:53 +08:00
janzenisaac 98103586b2
FEATURE: Reassign workflow (#231)
Build a new workflow that adds a dropdown in place of the old assign button with the ability to

Re-assign a new user / group to an assigned topic
Re-assign yourself to an assigned topic
Unassign a user / group from an assigned topic
2021-11-12 10:09:47 -06:00
Krzysztof Kotlarek a4b1847eff
FEATURE: display indirect assignments in the first post (#227)
A link in the first post will allow going to a specific post assigned to a user or group.
2021-11-03 10:35:10 +11:00
Krzysztof Kotlarek c396605d2f
FEATURE: assign to post (#224)
Ability to assign an individual post to a user or group
2021-11-01 09:27:13 +11:00
discoursebot ac0f8a6ee3
DEV: Update CI workflows (#210)
* DEV: Update CI workflows
* DEV: Fix prettier errors in tests

Co-authored-by: CvX <CvX@users.noreply.github.com>
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
2021-09-20 15:52:26 +02:00
Robin Ward 7082e32122
FIX: Tests were broken on Ember CLI (#211)
The first issue is using `updateCurrentUser` when code was conditional
in an initializer. Instead we need to use `needs.user()`.

The second issue was trickier to track down but we were using an
observer in a syncrhnous way which is not allowed in newer Embers. This
removes the observer (and some dead code around it!) so that we can
execute that code synchronously.
2021-09-16 08:46:44 -04:00
Martin Brennan 5f7adcc786
FIX: Allow Never selection for frequency of assigned topic reminders (#204)
If the user selected Never for their frequency of assigned topic
reminder PMs, the option automatically set back to the default
value (Monthly) because of the user of the `or` computed helper,
which considered the 0 value of Never to be falsey.

This is the same problem that occurred in core which was fixed by
d3779d4cf7

We need to be careful around using the `or` helper if any of the
options could be considered falsey.
2021-09-15 08:31:59 +10:00
Krzysztof Kotlarek 62d87f0084
FEATURE: better UI for group assignments (#197)
On the group assignment page, we should be able to display
- all topics assigned to that group + to user belonging to that group
- all topics assigned directly to group
- all topics assigned to individual user
2021-09-09 12:18:18 +10:00
Krzysztof Kotlarek b42ec9f779
FIX: correct group icons and notification message (#193)
* New group icon
* Group assignment notification displays group name instead of who assigned
2021-08-31 08:17:43 +10:00
Jarek Radosz d807491df2
FEATURE: Assign to group (#182)
Ability to assign groups.

To assign group, user must have a right to send a message to that group.

In addition, 2 jobs were introduced, - AssignNotification and UnassignNotification to inform interested users in the background about the new assignment.
2021-08-27 09:25:38 +10:00
Andrei Prigorshnev 29d4b8fd5c
FEATURE: improve blank page syndrome (#187) 2021-08-25 19:51:45 +04:00
Jarek Radosz ad95725987
FIX: Hide Unassigned if user doesn't have access (#179)
There's no need to display the "Unassigned" button for regular users when `assigns_public` is `false`.
2021-07-30 20:58:39 +02:00
Andrei Prigorshnev bdff555968
DEV: add a prefix with the plugin name to spec names (#180) 2021-07-30 22:39:38 +04:00
Jarek Radosz 53d3bda543
DEV: Update tests (#177)
Included:

* DEV: Add "assigned topic" test
* DEV: Update and re-enable disabled test
* DEV: Add missing imports
* DEV: Fix typos
* DEV: Don't use find()
* DEV: Use the hbs helper
2021-07-23 17:02:21 +02:00
Martin Brennan 8b0596fc87
FIX: Assign topic button not working (#164)
Since this commit
195dcc92cb
the updateUsername function was missing an @action decorator. This adds
it back and extends the assign acceptance tests to click the
mobile/desktop assign buttons and open the modal and click the
suggestion to save the assignment.
2021-06-29 10:12:19 +10:00