Commit Graph

575 Commits

Author SHA1 Message Date
Krzysztof Kotlarek 5124ba0f67
FIX: assignment table migration when SKIP_POST_DEPLOYMENT_MIGRATIONS (#217)
We need two branches of that migration. One when `assigned_to_type` is missing and another when `assigned_to_type` exists.

https://meta.discourse.org/t/db-migration-version-20210714173022-fails-when-having-skipped-post-deployment-migrations-before/204660
2021-09-29 18:33:45 +10:00
Krzysztof Kotlarek 3a58df219c
FIX: n+1 query on list of private messages assigned (#216)
When getting a list of private messages assigned to groups/users, we should include :allowed_users to avoid n+1
2021-09-29 09:01:15 +08:00
Penar Musaraj dd37f66f5d
DEV: Fix dev plugin reloading issue (#215) 2021-09-23 12:56:35 -04:00
Penar Musaraj dd2eae8f9c
DEV: Update bulk select in group topics list (#214) 2021-09-23 10:50:36 -04:00
Penar Musaraj 74b9f3d22c
UX: Fix input styling in group assignments page (#213) 2021-09-21 14:25:01 -04:00
discoursebot ac0f8a6ee3
DEV: Update CI workflows (#210)
* DEV: Update CI workflows
* DEV: Fix prettier errors in tests

Co-authored-by: CvX <CvX@users.noreply.github.com>
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
2021-09-20 15:52:26 +02:00
Bianca Nenciu 85fa1f90aa
FIX: Refresh first post after assign and unassign (#212)
The first post showed the assign status when it was loaded and did not
update if it changed. The page had to be refreshed for the text to be
updated.
2021-09-17 10:37:36 +10:00
Robin Ward 7082e32122
FIX: Tests were broken on Ember CLI (#211)
The first issue is using `updateCurrentUser` when code was conditional
in an initializer. Instead we need to use `needs.user()`.

The second issue was trickier to track down but we were using an
observer in a syncrhnous way which is not allowed in newer Embers. This
removes the observer (and some dead code around it!) so that we can
execute that code synchronously.
2021-09-16 08:46:44 -04:00
Penar Musaraj 83635ced6f
DEV: Remove displayNewPosts (deprecated in core) (#208) 2021-09-15 08:29:48 -04:00
Alan Guo Xiang Tan 5f97e1603d
FIX: Properly fabricate data for topic query specs. (#209)
We were creating PM topics that did not have any posts.
2021-09-15 13:00:28 +08:00
Martin Brennan 5f7adcc786
FIX: Allow Never selection for frequency of assigned topic reminders (#204)
If the user selected Never for their frequency of assigned topic
reminder PMs, the option automatically set back to the default
value (Monthly) because of the user of the `or` computed helper,
which considered the 0 value of Never to be falsey.

This is the same problem that occurred in core which was fixed by
d3779d4cf7

We need to be careful around using the `or` helper if any of the
options could be considered falsey.
2021-09-15 08:31:59 +10:00
Krzysztof Kotlarek b172ca604c
FIX: n+1 assignment (#205)
We are preloading assigned_to for topic list https://github.com/discourse/discourse-assign/blob/main/plugin.rb#L214

Therefore instead of checking assignment, we should use assigned_to directly on topics for serializers
2021-09-15 08:24:37 +10:00
Penar Musaraj 463b1c2cf0
DEV: Add `pluginId` in one last `modifyClass` call (#207) 2021-09-14 15:50:15 -04:00
Discourse Translator Bot 7738124007
Update translations (#206) 2021-09-14 16:20:24 +02:00
Penar Musaraj 86a2b1d574
UX: Fix input alignment following core changes (#200) 2021-09-14 09:41:08 -04:00
Krzysztof Kotlarek f58b78e027
FIX: add assigned fields to suggested topic serializer (#199)
With hard refresh, information about assigned user disappeared from suggested topics.
2021-09-09 16:59:06 +10:00
Krzysztof Kotlarek ab9e6f0684
FIX: unassign/assign when group pm is archived (#192)
Send correct messages and correctly unassign/assign to user/group if group PM is archived or moved back to inbox.
2021-09-09 14:22:04 +10:00
Krzysztof Kotlarek 62d87f0084
FEATURE: better UI for group assignments (#197)
On the group assignment page, we should be able to display
- all topics assigned to that group + to user belonging to that group
- all topics assigned directly to group
- all topics assigned to individual user
2021-09-09 12:18:18 +10:00
Joffrey JAFFEUX da0a6ce219
DEV: adds log warning if assign is not enabled (#202) 2021-09-08 16:46:41 +02:00
Joffrey JAFFEUX 0881b638bd
DEV: adds an option to check for working hours (#201) 2021-09-08 16:46:33 +02:00
Joffrey JAFFEUX cfc25d9ac2
DEV: removes default for minimum time (#203) 2021-09-08 16:46:17 +02:00
Krzysztof Kotlarek 5954c625ef
FEATURE: advance search groups (#198)
Allow advance search filter to select topics assigned to specific group
2021-09-08 11:39:15 +10:00
Krzysztof Kotlarek 375f7ba78d
FEATURE: new assignable group option instead of messageable (#195)
V1 of group assign was using "who can message" to determine if group can be assigned.

This PR is introducing new separate setting "who can assign"
2021-09-08 10:30:13 +10:00
Robin Ward f541158b64
DEV: Add `pluginId` for more stable tests (#196) 2021-09-02 15:46:32 -04:00
Discourse Translator Bot 43b587dc44
Update translations (#194) 2021-08-31 16:08:49 +02:00
Krzysztof Kotlarek b42ec9f779
FIX: correct group icons and notification message (#193)
* New group icon
* Group assignment notification displays group name instead of who assigned
2021-08-31 08:17:43 +10:00
David Taylor 978f3d74a1
FIX: Ensure move_to_inbox does not raise error when unassigned (#190) 2021-08-27 15:22:24 +01:00
Krzysztof Kotlarek 9d7d39705e
FIX: broken suggestions (#189)
We need to pass name to assignUser because it is used in 2 places.
One is multiselect and another are suggestions.
2021-08-27 12:57:17 +10:00
Krzysztof Kotlarek 1306a69b06
FIX: whisper small actions are blank (#188)
assigned_group and unassigned_group has to be added to decorator to properly display whispers
2021-08-27 11:34:44 +10:00
Jarek Radosz d807491df2
FEATURE: Assign to group (#182)
Ability to assign groups.

To assign group, user must have a right to send a message to that group.

In addition, 2 jobs were introduced, - AssignNotification and UnassignNotification to inform interested users in the background about the new assignment.
2021-08-27 09:25:38 +10:00
Andrei Prigorshnev 29d4b8fd5c
FEATURE: improve blank page syndrome (#187) 2021-08-25 19:51:45 +04:00
Discourse Translator Bot 489dfafb32
Update translations (#186) 2021-08-24 15:16:38 +02:00
Joffrey JAFFEUX 0046041e9e
FEATURE: improves random assign automation (#166)
- Makes a best attempt at being random and assigning people who haven’t been assigned for a long time
- Uses timezones and holidays
- Allows to define a minimum delay between assignments
- Creates a post if no one is available
2021-08-20 12:22:37 +02:00
Joffrey JAFFEUX a8495e9d7a
FIX: makes dropdown use absolute positioning (#185) 2021-08-16 12:19:48 +02:00
Joffrey JAFFEUX 92a1167a68
FIX: explicit assign on user selection (#184)
Also drops autofocus as it's the first item in the form
2021-08-16 10:56:01 +02:00
dependabot[bot] 39fa568593
Build(deps): Bump path-parse from 1.0.6 to 1.0.7 (#183)
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-13 00:49:20 +02:00
Discourse Translator Bot 4c26cef99d
Update translations (#181) 2021-08-04 14:13:41 +02:00
Jarek Radosz ad95725987
FIX: Hide Unassigned if user doesn't have access (#179)
There's no need to display the "Unassigned" button for regular users when `assigns_public` is `false`.
2021-07-30 20:58:39 +02:00
Andrei Prigorshnev bdff555968
DEV: add a prefix with the plugin name to spec names (#180) 2021-07-30 22:39:38 +04:00
Jarek Radosz 9ecc1581fd
DEV: Remove old review queue code (#178)
I think it should have been deleted with https://github.com/discourse/discourse-assign/pull/47? That's where e.g. `assign_locks_flags` site setting was removed.
2021-07-30 14:43:28 +02:00
Jarek Radosz 53d3bda543
DEV: Update tests (#177)
Included:

* DEV: Add "assigned topic" test
* DEV: Update and re-enable disabled test
* DEV: Add missing imports
* DEV: Fix typos
* DEV: Don't use find()
* DEV: Use the hbs helper
2021-07-23 17:02:21 +02:00
Arpit Jalan 4024eb078c
FIX: filter by "nobody" was broken (#176)
Meta ref: https://meta.discourse.org/t/filter-by-nobody-seems-broken/197770/
2021-07-22 15:00:27 +05:30
Penar Musaraj c572e21493
UX: Add quick search suggestion entries (#175) 2021-07-21 14:00:43 -04:00
Jarek Radosz dfb30fc104
FIX: TagsHtmlCallback params can be undefined (#174) 2021-07-20 13:53:17 +02:00
Jarek Radosz 4e657b97df
FIX: Make tagsHtml callback respect tagName option (#173)
Makes the assigned icon and label non-interactive in search results dropdown.
2021-07-20 12:37:33 +02:00
Jarek Radosz 09b7655206
FIX: Handle invalid source data in CF migration (#172) 2021-07-14 22:02:27 +02:00
Jarek Radosz b0a480fd35
FIX: CF to table migration was incorrect (#171)
The order of values in the `INSERT` query was invalid (`assigned_to_id` and `topic_id` were swapped)

Co-authored-by: David Taylor <david@taylorhq.com>
2021-07-14 20:45:31 +02:00
Jarek Radosz 470dd939aa
DEV: Move assignments from custom fields to a table (#169) 2021-07-14 10:48:19 +02:00
Joffrey JAFFEUX f559fc9557
FIX: automation fields now all use the same value property (#170) 2021-07-12 18:34:13 +02:00
Discourse Translator Bot 6de1f9821e
Update translations (#168) 2021-07-09 12:22:32 +02:00