gjs, helper invocation case, typos, latest license template, unnecessary tracking, concatClass, unnecessary service injection, new imports, whitespace, pure function helper, htmlSafe calling convention, this. in template, unused vars in ruby, update linting, qunit-dom
This pin means that sites will not show an update available for docker_manager, and will then hit a pnpm/yarn error when updating core.
docker_manager is compatible with the 3.3.x series, so we can remove this pin.
Git repositories will be initialized less often and then copied for each
spec. This reduces the calls to 'git' and the total execution time of
the specs.
Requesting /admin/docker/repos.json with a lot of plugins installed can
take a lot of time because of the large number of calls to the 'git'
CLI that are used to retrieve various information about the plugin
(eg. branch, latest commit, remote URL, etc).
This is not a problem in production because of memoization and the
much lower number of installed plugins, but it is a problem in test
environment where specs requesting this page can take 10+ seconds with
~100 installed plugins.
This commit speeds up by stubbing the `find_all` method to return only
the first few repositories.
This system spec is flaky and we are getting a blank page so I would
like to see what the HTML is. Previously printing of the page's HTML was
doing it too early such that the ember application has not even boot.
RSpec predicate matchers provide poor output when tests fail.
This commit switches to Capybara RSpec matches so that we get more
debugging information as to why these tests are flaky...
I'm unable to find why the tests are failing in the Discourse core repo's plugin tests workflow. These tests always pass in the plugin repo and my local dev environment.
This PR will refresh the software update page so that self-hosters can more easily understand the plugins they have installed and which plugins need updates, and so that they are able to quickly and easily update them (or update everything).
Co-authored-by: Martin Brennan <mjrbrennan@gmail.com>
The last forced update was more than a year ago. That old image has a lot of old dependencies, including an old `node` version which is no longer supported by some of Discourse's JS dependencies. This commit will instruct self-hosters to perform a command-line rebuild.
In this PR, all references in the UI to the word "`upgrade`" are changed to "`update`". This is to differentiate the update process in self-hosted sites from the plan "upgrade" process in hosted sites.
c.f. https://github.com/discourse/discourse/pull/25200
The new admin sidebar doesn't have plugin outlets, so we
need a way to register links like this Upgrade one. The
admin sidebar is currently experimental, so we need to keep
the old outlet around for now for sites who have not enabled
the admin sidebar.
This time we are not using before in the initializer, due
to the changes in this core PR https://github.com/discourse/discourse/pull/25396
c.f. https://github.com/discourse/discourse/pull/25200
The new admin sidebar doesn't have plugin outlets, so we
need a way to register links like this Upgrade one. The
admin sidebar is currently experimental, so we need to keep
the old outlet around for now for sites who have not enabled
the admin sidebar.