Sebastiaan van Stijn
526a9db743
Merge pull request #3336 from thaJeztah/fix_onbuild_assert
...
integration: adjust tests for omitted "OnBuild"
2025-05-22 10:44:55 +02:00
Sebastiaan van Stijn
e5c3eb18b6
integration: adjust tests for omitted "OnBuild"
...
The Docker API may either return an empty "OnBuild" or omit the
field altogether if it's not set.
Adjust the tests to make either satisfy the test.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2025-05-22 01:46:53 +02:00
Shaun Thompson
db7f8b8bb6
Merge pull request #3296 from thaJeztah/fix_test_create_volume_invalid_driver
...
integration: test_create_volume_invalid_driver allow either 400 or 404
2025-01-17 12:32:14 -05:00
Shaun Thompson
747d23b9d7
Merge pull request #3307 from thaJeztah/deprecated_json_error
...
image load: don't depend on deprecated JSONMessage.error field
2025-01-17 12:30:54 -05:00
Sebastiaan van Stijn
fad84c371a
integration: test_create_volume_invalid_driver allow either 400 or 404
...
The API currently returns a 404 error when trying to create a volume with
an invalid (non-existing) driver. We are considering changing this status
code to be a 400 (invalid parameter), as even though the _reason_ of the
error may be that the plugin / driver is not found, the _cause_ of the
error is that the user provided a plugin / driver that's invalid for the
engine they're connected to.
This patch updates the test to pass for either case.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2025-01-14 14:23:24 +01:00
Sebastiaan van Stijn
5a8a42466e
image load: don't depend on deprecated JSONMessage.error field
...
The error field was deprecated in favor of the errorDetail struct in
[moby@3043c26], but the API continued to return both. This patch updates
docker-py to not depend on the deprecated field.
[moby@3043c26]: 3043c26419
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2025-01-14 13:23:38 +01:00
Sebastiaan van Stijn
03e43be6af
Merge pull request #3297 from thaJeztah/fix_makefile_circref
...
Makefile: fix circular reference for integration-dind
2024-11-18 18:03:11 +01:00
Sebastiaan van Stijn
80a584651b
Merge pull request #2442 from thaJeztah/test_service_logs_un_experimental
...
test_service_logs: stop testing experimental versions
2024-11-18 18:02:30 +01:00
Sebastiaan van Stijn
8ee28517c7
test_service_logs: stop testing experimental versions
...
Service logs are no longer experimental, so updating the tests
to only test against "stable" implementations, and no longer
test the experimental ones.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-18 16:09:21 +01:00
Sebastiaan van Stijn
d9f9b965b2
Makefile: fix circular reference for integration-dind
...
Noticed this warning;
make: Circular integration-dind <- integration-dind dependency dropped.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-18 16:07:01 +01:00
Bjorn Neergaard
fba6ffe297
Merge pull request #3267 from thaJeztah/add_default_version
...
Set a dummy-version if none set, and remove unused APT_MIRROR build-arg
2024-11-18 07:48:00 -07:00
Sebastiaan van Stijn
99ce2e6d56
Makefile: remove unused APT_MIRROR build-arg
...
The APT_MIRROR build-arg was removed from the Dockerfile in commit
ee2310595d
, but wasn't removed from the
Makefile.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-18 15:41:24 +01:00
Sebastiaan van Stijn
504ce6193c
Set a dummy-version if none set
...
Make sure the Dockerfiles can be built even if no VERSION build-arg
is passed.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-18 15:41:19 +01:00
Sebastiaan van Stijn
bb0edd1f66
Merge pull request #3261 from thaJeztah/bump_engine_versions
...
Bump default API version to 1.45 (Moby 26.0/26.1)
2024-10-27 17:09:14 +01:00
Sebastiaan van Stijn
e47e966e94
Bump default API version to 1.45 (Moby 26.0/26.1)
...
- Update API version to the latest maintained release.
0 Adjust tests for API 1.45
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-27 17:03:02 +01:00
Sebastiaan van Stijn
a8bac88221
Merge pull request #3292 from yasonk/fix-exec_run-doc
...
fixing doc for stream param in exec_run
2024-09-30 23:22:45 +02:00
Sebastiaan van Stijn
e031cf0c23
Merge pull request #3290 from laurazard/exec-no-executable-exit-code
...
tests/exec: expect 127 exit code for missing executable
2024-09-30 15:18:31 +02:00
Laura Brehm
b1265470e6
tests/exec: add test for exit code from exec
...
Execs should return the exit code of the exec'd process, if it started.
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
2024-09-30 14:07:04 +01:00
yasonk
6bbf741c8c
fixing doc for stream param in exec_run
...
Signed-off-by: yasonk <yason@hey.com>
2024-09-29 18:58:38 -07:00
Laura Brehm
96ef4d3bee
tests/exec: expect 127 exit code for missing executable
...
Docker Engine has always returned `126` when starting an exec fails due
to a missing binary, but this was due to a bug in the daemon causing the
correct exit code to be overwritten in some cases – see: https://github.com/moby/moby/issues/45795
Change tests to expect correct exit code (`127`).
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
2024-09-27 15:33:11 +01:00
Sebastiaan van Stijn
a3652028b1
Merge pull request #3264 from krissetto/rename-env-var-in-release-pipeline
...
Change env var name in release pipeline to match hatch expectations
2024-05-23 13:09:32 +02:00
Christopher Petito
1ab40c8e92
Fix env var name in release pipeline to match hatch expectations
...
Signed-off-by: Christopher Petito <47751006+krissetto@users.noreply.github.com>
2024-05-23 10:49:23 +00:00
Laura Brehm
b33088e0ca
Merge pull request #3263 from krissetto/fix-release-pipeline
...
Fix env var name in release pipeline
2024-05-23 11:32:12 +01:00
Christopher Petito
45488acfc1
Fix env var name in release pipeline
...
Signed-off-by: Christopher Petito <47751006+krissetto@users.noreply.github.com>
2024-05-23 10:14:18 +00:00
Laura Brehm
20879eca6a
Merge pull request #3262 from krissetto/changelog-7.1.0
2024-05-23 10:37:29 +01:00
Christopher Petito
4f2a26d21e
Added 7.1.0 changelog
...
Signed-off-by: Christopher Petito <47751006+krissetto@users.noreply.github.com>
2024-05-23 09:30:30 +00:00
Sebastiaan van Stijn
7785ad913d
Merge pull request #3257 from felixfontein/requests-hotfix
...
Fix for requests 2.32
2024-05-22 15:02:59 +02:00
Felix Fontein
d8e9bcb278
requests 2.32.0 and 2.32.1 have been yanked.
...
Signed-off-by: Felix Fontein <felix@fontein.de>
2024-05-22 14:50:14 +02:00
Felix Fontein
2a059a9f19
Extend fix to requests 2.32.2+.
...
Signed-off-by: Felix Fontein <felix@fontein.de>
2024-05-22 14:50:14 +02:00
Felix Fontein
e33e0a437e
Hotfix for requests 2.32.0.
...
Signed-off-by: Felix Fontein <felix@fontein.de>
2024-05-22 14:50:14 +02:00
Sebastiaan van Stijn
b86573a3e3
Merge pull request #3260 from krissetto/fix-ci
...
CI fix
2024-05-22 14:45:11 +02:00
Christopher Petito
e34bcf20d9
Update setup-python gh action
...
Signed-off-by: Christopher Petito <47751006+krissetto@users.noreply.github.com>
2024-05-22 11:10:22 +00:00
Christopher Petito
205d2f2bd0
Fix to get our CI working again since we rely on parsing tags.
...
See https://github.com/docker/docker-py/pull/3259 attempts for more details
Signed-off-by: Christopher Petito <47751006+krissetto@users.noreply.github.com>
2024-05-22 10:58:13 +00:00
Bob Du
b6464dbed9
chore: fix return type docs for `container.logs()` ( #2240 )
2024-04-09 16:13:21 -04:00
Milas Bowman
9ad4bddc9e
chore(ci): fix-ups across Make / Docker / GitHub Actions ( #3241 )
2024-04-03 08:44:29 -04:00
Milas Bowman
336e65fc3c
Merge pull request #3212 from valohai/ruff-i
2024-03-29 13:31:57 -04:00
Milas Bowman
4c6437d292
Merge pull request #3212 from valohai/ruff-i
2024-03-29 13:28:43 -04:00
Milas Bowman
0fd79c8c0d
Merge pull request #3207 from valohai/modernize-build
2024-03-29 13:14:36 -04:00
Paweł Gronowski
3d79ce8c60
Merge pull request #3231 from vvoland/engine-25
...
Bump default API version to 1.44 (Moby 25.0)
2024-03-25 17:36:55 +01:00
Paweł Gronowski
dd82f9ae8e
Bump minimum API version to 1.24
...
25.0 raised the minimum supported API verison: https://github.com/moby/moby/pull/46887
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
2024-03-14 11:04:39 +01:00
Paweł Gronowski
e91b280074
Bump default API version to 1.44 (Moby 25.0)
...
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
2024-03-14 11:04:37 +01:00
Rob Murray
cb21af7f69
Fix tests that look at 'Aliases'
...
Inspect output for 'NetworkSettings.Networks.<network>.Aliases'
includes the container's short-id (although it will be removed
in API v1.45, in moby 26.0).
Signed-off-by: Rob Murray <rob.murray@docker.com>
2024-03-13 14:54:25 +00:00
Aarni Koskela
1818712b8c
Untangle circular imports
...
Signed-off-by: Aarni Koskela <akx@iki.fi>
2024-01-03 21:40:11 +02:00
Aarni Koskela
d50cc429c2
Enable Ruff I (import sort), autofix
...
Signed-off-by: Aarni Koskela <akx@iki.fi>
2024-01-03 21:28:56 +02:00
Aarni Koskela
047df6b0d3
Build wheel in CI, upload artifact for perusal
...
Signed-off-by: Aarni Koskela <akx@iki.fi>
2024-01-03 21:20:13 +02:00
Aarni Koskela
ae45d477c4
Use `hatch` for packaging
...
Signed-off-by: Aarni Koskela <akx@iki.fi>
2024-01-03 21:20:11 +02:00
Aarni Koskela
f128956034
Use `build` instead of calling setup.py
...
Signed-off-by: Aarni Koskela <akx@iki.fi>
2024-01-03 21:20:02 +02:00
Milas Bowman
bd164f928a
Merge pull request #3205 from valohai/drop-packaging-dep
...
Drop `packaging` dependency
2024-01-03 14:19:02 -05:00
Aarni Koskela
249654d4d9
Drop `packaging` dependency
...
Compare versions like Moby (api/types/versions/compare.go)
Signed-off-by: Aarni Koskela <akx@iki.fi>
2024-01-03 21:12:37 +02:00
Milas Bowman
694d9792e6
lint: fix string formatting ( #3211 )
...
Merged a linter upgrade along with an older PR, so this was immediately in violation
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
2024-01-03 14:01:42 -05:00