* Update default API version to v1.39
When running the docker-py integration tests in the Moby repository, some
tests were skipped because the API version used was too low:
SKIPPED [1] tests/integration/api_service_test.py:882: API version is too low (< 1.38)
SKIPPED [1] tests/integration/api_swarm_test.py:59: API version is too low (< 1.39)
SKIPPED [1] tests/integration/api_swarm_test.py:38: API version is too low (< 1.39)
SKIPPED [1] tests/integration/api_swarm_test.py:45: API version is too low (< 1.39)
SKIPPED [1] tests/integration/api_swarm_test.py:52: API version is too low (< 1.39)
While it's possible to override the API version to use for testing
using the `DOCKER_TEST_API_VERSION` environment variable, we may want
to set the default to a version that supports all features that were
added.
This patch updates the default API version to v1.39, which is the minimum
version required for those features, and corresponds with Docker 18.09.
Note that the API version of the current (19.03) Docker release is v1.40,
but using that version as default would exclude users that did not update
their Docker version yet (and would not be needed yet for the features provided).
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
* Makefile: set DOCKER_TEST_API_VERSION to v1.39
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This test was updated in 7d92fbdee1, but
omitted the "error" prefix in the message, causing the test to fail;
_________ CreateContainerTest.test_invalid_log_driver_raises_exception _________
tests/integration/api_container_test.py:293: in test_invalid_log_driver_raises_exception
assert excinfo.value.explanation in expected_msgs
E AssertionError: assert 'error looking up logging plugin asdf: plugin "asdf" not found' in ["logger: no log driver named 'asdf' is registered", 'looking up logging plugin asdf: plugin "asdf" not found']
E + where 'error looking up logging plugin asdf: plugin "asdf" not found' = APIError(HTTPError('400 Client Error: Bad Request for url: http+docker://localhost/v1.39/containers/create')).explanation
E + where APIError(HTTPError('400 Client Error: Bad Request for url: http+docker://localhost/v1.39/containers/create')) = <ExceptionInfo APIError tblen=6>.value
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Make sure we use the LTS nodes, to prevent using machines that
we prepared with cgroups v2 (which is not yet supported by docker v19.03)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This replaces the custom dockerswarm/dind image with the official
dind images, which should provide the same functionality.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
aiordache
Ulysses Souza
Till Riedel
Sebastiaan van Stijn
Sebastiaan van Stijn
Anca Iordache
Ville Skyttä
Lucidiot
Ofek Lev
Ulysses Souza
Wilson Júnior