docker
/
docker-py
mirror of https://github.com/docker/docker-py.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
3,373 Commits 23 Branches 129 Tags 8.4 MiB
Commit Graph

10 Commits

Author SHA1 Message Date
Khushiyant b8a6987cd5
fix: keyerror when creating new config (#3200) 
Closes #3110.

---------

Signed-off-by: Khushiyant <khushiyant2002@gmail.com>
 2024-01-03 18:44:53 +00:00
Hugo van Kemenade 4bb99311e2 Don't install mock backport 
Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
 2021-10-11 23:06:12 +03:00
Anthony Sottile 5fcc293ba2 use python3.6+ constructs 
Signed-off-by: Anthony Sottile <asottile@umich.edu>
 2021-07-05 18:30:07 -04:00
Felipe Ruhland d4310b2db0 Fix `KeyError` when creating a new secret 
How to reproduce the issue:

```py
>>> import docker
>>> cli = docker.from_env()
>>> cli.secrets.create(name="any_name", data="1")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/docker-py/docker/models/secrets.py", line 10, in __repr__
    return "<%s: '%s'>" % (self.__class__.__name__, self.name)
  File "/home/docker-py/docker/models/secrets.py", line 14, in name
    return self.attrs['Spec']['Name']
KeyError: 'Spec'
```

The exception raises because create secrets API `/secrets/create` only
return the `id` attribute:
https://docs.docker.com/engine/api/v1.41/#operation/SecretCreate
The secret model is created using just the `id` attribute and fails
when looking for Spec.Name attribute.

```py
def __repr__(self):
    return "<%s: '%s'>" % (self.__class__.__name__, self.name)
```

```py
@property
def name(self):
    return self.attrs['Spec']['Name']
```

I came up with a ugly solution but will prevent the problem to happen
again:

```py
def create(self, **kwargs):
    obj = self.client.api.create_secret(**kwargs)
+   obj.setdefault("Spec", {})["Name"] = kwargs.get("name")
    return self.prepare_model(obj)
```

After the API call, I added the name attribute to the right place to be
used on the property name.

```py
>>> import docker
>>> cli = docker.from_env()
>>> cli.secrets.create(name="any_name", data="1")
<Secret: 'any_name'>
```

It isn't the most elegant solution, but it will do the trick.
I had a previous PR #2517 when I propose using the `id` attribute
instead of `name` on the `__repr__` method, but I think this one will be better.

That fixes #2025

Signed-off-by: Felipe Ruhland <felipe.ruhland@gmail.com>
 2021-03-24 18:03:54 +01:00
aiordache c7c5b551fc set engine version for unit tests to avoid querying the engine 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-08-20 15:29:24 +02:00
Joffrey F 94e9108441 Add ignore_removed param to containers.list() to control whether to 
raise or ignore NotFound

Signed-off-by: Joffrey F <joffrey@docker.com>
 2018-04-25 17:55:16 -07:00
Joffrey F 7fabcdaa4c Update wait to always return a dict 
Signed-off-by: Joffrey F <joffrey@docker.com>
 2018-01-31 16:52:26 -08:00
Joffrey F 6b8dfe4249 Retrieve container logs before container exits / is removed 
Signed-off-by: Joffrey F <joffrey@docker.com>
 2017-12-14 16:53:44 -08:00
Joffrey F f5ac10c469 Rename Client -> DockerClient 
Replace references to old Client with APIClient
Moved contents of services.md to appropriate locations

Signed-off-by: Joffrey F <joffrey@docker.com>
 2016-11-28 15:28:04 -08:00
Ben Firshman 1984f68730
Add new user-focused API 
See #1086

Signed-off-by: Ben Firshman <ben@firshman.co.uk>
 2016-11-22 17:05:43 +00:00