The condition checked if the hotjar-id wasn't empty, but did not
check if it was "set". Because of that, the script would still be
included, producing a JavaScript error.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Before this, docker compose would always first pull the `docs/docstage`
image from docker hub, then build the local docs:
Before this:
```
docker compose up
[+] Running 1/12
⠿ docs Pulled 11.1s
⠧ 706c320525cd Download complete 8.7s
⠴ 4f98bba63633 Download complete 7.5s
⠇ 4f4fb700ef54 Exists 4.8s
⠇ a47abff02990 Download complete 4.8s
⠧ ab1af07f990a Download complete 4.7s
⠧ bd5777bb8f79 Download complete 4.7s
⠧ 8b79b42c3524 Download complete 4.7s
⠧ d4b8ebd00804 Download complete 4.7s
⠧ f1398ae18173 Download complete 4.7s
⠧ 9981e73032c8 Download complete 4.7s
⠧ e5f90f35b4bc Download complete 4.7s
[+] Building 69.1s (15/20)
=> [internal] load .dockerignore 0.0s
=> => transferring context: 196B 0.0s
=> [internal] load build definition from Dockerfile 0.0s
=> => transferring dockerfile: 3.85kB 0.0s
=> resolve image config for docker.io/docker/dockerfile:1 2.2s
...
```
With this patch, the `docs pulled` step is skipped, and we start building
immediately:
```
docker compose up
[+] Building 6.7s (11/20)
=> [internal] load .dockerignore 0.0s
=> => transferring context: 196B 0.0s
=> [internal] load build definition from Dockerfile 0.0s
...
```
Perhaps compose does this as it was to help with caching when building
with the legacy builder, but BuildKit does not use local images for
caching, so we don't need to do so (I'm planning to open a ticket in
compose to discuss this).
As we're using this compose-file to build the docs (not to view some
older version), let's disable pulling, so that we're always building.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The color of the top-navigation for "light" and "night" mode is the
same, so we don't need to override the color (for now). The old override
used a hue that was slightly out of tone with the rest of the theme.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
* Genericize frontend tutorial and make it clear other tech are usable and track it
* Rework backend tutorial to add tabs for other techs and incorporate the build and install commands.
* Guillaume's feedback
* Desktop: we now try to configure HTTP proxies consistently
It's not 100% yet but it's not necessary to configure every component
separately as it was before.
Signed-off-by: David Scott <dave.scott@docker.com>
* Desktop: update HTTP proxy section
In the latest 4.15 it should
- work with Proxy Auto-Configuration
- dynamically ask the developer for username and password, if the
proxy requires auth
- support TLS 1.3 for talking to the proxy
- be controllable with settings management
Signed-off-by: David Scott <dave.scott@docker.com>
* Update desktop/settings/windows.md
* Update desktop/settings/linux.md
* Update desktop/settings/mac.md
* Update desktop/settings/mac.md
* Update desktop/settings/linux.md
* Update desktop/settings/windows.md
Signed-off-by: David Scott <dave.scott@docker.com>
Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com>
jerae-duffin
Jerae Duffin
David Karlsson
CrazyMax
CrazyMax
Bhav Beri
Ivan Curkovic
Craig Osterhout
Usha Mandya
Daniel Junior
Benjamin Grandfond
Sebastiaan van Stijn
dependabot[bot]
David Carrell
David Karlsson
Sebastiaan van Stijn
Guillaume Tardif
Milas Bowman
Allie Sadler
David Scott
Tom
docker-tools-robot
gr0ker