In some cases, (e.g. private key not accessible or has incorrect
permissions) docker-machine failed with error "Something went wrong
running an SSH command!". This commit will add the correct debug
messages and show the correct errors for the bad private keys.
Also, due to incorrect handling POSIX file permissions in Windows
some checks should be ignored.
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
Using the user-defined ssh_config configurations bring more problems
instead of enchancements.
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
Improve doc of azure-subnet-prefix, azure-use-private-ip and
azure-no-public-ip options.
https://github.com/docker/machine/issues/3249
Signed-off-by: Tom Deseyn <tom.deseyn@gmail.com>
When using the --digitalocean-ssh-key-fingerprint flag, no SSH key pair
is generated. Keeping the driver's SSHKeyPath option empty makes sure
the ssh client won't perform any validation on the private key.
Signed-off-by: Bilal Amarni <bilal.amarni@gmail.com>
Making Azure operation polling intervals more frequent to
detect completions faster (and thus making machine creations
faster).
Reduce one Azure API call for each machine command by caching
the discovered Azure Active Directory tenant ID of the user’s
Azure subscription into a local file. This also makes Azure
driver commands faster.
Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
This complements the fix in 705865fa by adding a test for unset flags
with defaults as well as other combinations of set and unset flags.
Signed-off-by: John Sirois <john.sirois@gmail.com>
Previously StringSlice flag defaults were not respected. These use
special handling and that handling did not take account of default
values, always over-writing them. Expand the CommandLine interface to
take advantage of the underlying codegansta/cli.Context IsSet method and
guard default string slice overwrites with an IsSet test.
Signed-off-by: John Sirois <john.sirois@gmail.com>
In some cases, (e.g. private key not accessible or has incorrect
permissions) docker-machine failed with error "Something went wrong
running an SSH command!". This commit will add the correct debug
messages and show the correct errors for the bad private keys.
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
Updated `netstat` command to minimize its output with `-t` and `-l`
flags.
Refactored regex on `libmachine/provision/utils.go`:`checkDaemonUp` to
avoid `matchNetstatOut` returning `true` when remote machine has a
similar port to dockerPort listening (e.g. dockerPort := 2376 and
remote machine has port 23760 listening).
Refactored `utils_test.go` with more accurate `netstat` output.
Signed-off-by: Tiago Pires <tandrepires@gmail.com>
Nathan LeClaire
Nathan LeClaire
Ahmet Alp Balkan
Maksim Malchuk
Tom Deseyn
Markus Bukowski
Bilal Amarni
Bilal Amarni
Olivier Gambier
Victoria
Victoria Bialas
John Sirois
Tiago Pires
Andre Caron