Commit Graph

1850 Commits

Author SHA1 Message Date
Riyaz Faizullabhoy ed1bf1a0a6 Address review comments
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
2016-04-26 17:00:12 -07:00
Riyaz Faizullabhoy ca9fc99ba5 Goodbye Certstore
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
2016-04-26 17:00:09 -07:00
Riyaz Faizullabhoy 01bbd532c6 Update update logic to error out on corrupted previous root metadata
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
2016-04-26 16:59:22 -07:00
Riyaz Faizullabhoy 5901c87feb Update tests
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
2016-04-26 16:59:22 -07:00
Riyaz Faizullabhoy 9da40f07da Foundation for removing certstore
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
2016-04-26 16:59:22 -07:00
Ying Li dc445b4a3a Merge pull request #697 from aaronlehmann/cosmetic
trustmanager: Minor cosmetic source code fixes
2016-04-26 15:28:53 -07:00
Aaron Lehmann 8e30157a5c trustmanager: Minor cosmetic source code fixes
Fixing a few things I noticed scrolling through the Notary 0.3.0-RC1
diff.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-04-26 10:29:39 -07:00
David Lawrence b5a7b2adaa Merge pull request #691 from docker/yubikey-doc-update
Update docs with yubikey info for docker 1.11
2016-04-21 17:16:30 -07:00
David Lawrence 12429b74d4 Merge pull request #692 from docker/makebinaries-docs
better docs for make binaries
2016-04-21 17:15:30 -07:00
Riyaz Faizullabhoy 37d35e896c Update gopath in dir structure
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
2016-04-21 17:12:52 -07:00
Riyaz Faizullabhoy e68e1e1e13 better docs for make binaries
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
2016-04-21 10:28:02 -07:00
Riyaz Faizullabhoy 09af9b1661 Update docs with yubikey info for docker 1.11
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
2016-04-20 23:07:54 -07:00
Ying Li 3b15594f59 Merge pull request #688 from cyli/remove-tuf-client-tests
Remove tuf/client tests
2016-04-20 17:15:03 -07:00
Ying Li 2d72c39e6c Add a few more tests for tuf/store/memorystore.
Also add a few tuf/client/client_test tests back that checks for download failure
if the local timestamp or snapshot is missing in the local TUF repo.

Signed-off-by: Ying Li <ying.li@docker.com>
2016-04-20 17:00:40 -07:00
Ying Li 283c452737 A lot of tuf/client tests are redundant - move the ones that aren't to client_update_test
and just remove tuf/client/client_test.

Signed-off-by: Ying Li <ying.li@docker.com>
2016-04-20 16:59:12 -07:00
Ying Li b2349a0385 Provide a nice SignAndSerialize testutil function to export metadata from a repo.
Signed-off-by: Ying Li <ying.li@docker.com>
2016-04-20 16:59:04 -07:00
Ying Li be82a0a5f4 Merge pull request #687 from cyli/error-refactor
Remove a redundant ErrChecksumMismatch error in tuf/client
2016-04-20 16:57:01 -07:00
Riyaz Faizullabhoy 74a0adc902 Merge pull request #671 from HuKeping/refactor
Rework the main for notary signer
2016-04-20 15:49:38 -07:00
Ying Li 053c2a5a79 Remove a redundant ErrChecksumMismatch error in tuf/client, since we
already have a ErrMismatchedChecksum in tuf/data/errors.

Also, have the CheckHashes function take a role name so that the
ErrMismatchedChecksum error can include the role name.

Signed-off-by: Ying Li <ying.li@docker.com>
2016-04-20 11:08:03 -07:00
HuKeping be03c1a9dc Add some test
Signed-off-by: Hu Keping <hukeping@huawei.com>
2016-04-20 20:48:02 +08:00
HuKeping b3686803c1 Pass to components exactly what they want instead of using global variable
Signed-off-by: Hu Keping <hukeping@huawei.com>
2016-04-20 20:46:23 +08:00
HuKeping 3f1806d70b Move helper function bootstrap to its own file
Signed-off-by: Hu Keping <hukeping@huawei.com>
2016-04-20 20:28:59 +08:00
HuKeping ae889ad37a Move the configuration for TLS to its own file.
Signed-off-by: Hu Keping <hukeping@huawei.com>
2016-04-20 20:25:17 +08:00
HuKeping 8725f6a4c7 Move the configuration for API servers to its own file.
Signed-off-by: Hu Keping <hukeping@huawei.com>
2016-04-20 20:18:02 +08:00
HuKeping 3501c0edf5 Move the setUpCryptoservices to its own file.
Signed-off-by: Hu Keping <hukeping@huawei.com>
2016-04-20 20:06:51 +08:00
HuKeping a80c539ce8 Move the passphraseRetriever to its own file.
Signed-off-by: Hu Keping <hukeping@huawei.com>
2016-04-20 19:42:38 +08:00
HuKeping dc147d12c4 Add a source file to hold the configuration things for signer
Let's name it config.go

Signed-off-by: Hu Keping <hukeping@huawei.com>
2016-04-20 19:42:38 +08:00
HuKeping ba324344ed Add a struct for signer config
We can use a struct of config to hold all the necessary info that needed
to run a notary signer.

Signed-off-by: Hu Keping <hukeping@huawei.com>
2016-04-20 19:42:38 +08:00
Riyaz Faizullabhoy 4d85f964bc Merge pull request #682 from endophage/store_storage
minor cleanup of filestore initialization
2016-04-19 16:49:22 -07:00
David Lawrence 59ae7af769 remove unused tuf/testutils/utils.go
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
2016-04-19 15:48:13 -07:00
David Lawrence 4f58eda1ec removing unused functions in SimpleFileStore
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
2016-04-19 15:46:56 -07:00
David Lawrence 64ea94567b refactoring some duplicate code in parsing x509 certs to keys
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
2016-04-19 15:46:56 -07:00
David Lawrence 31f02ec0f7 minor cleanup of filestore initialization
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
2016-04-19 15:46:56 -07:00
David Lawrence 358add6075 Merge pull request #686 from docker/go1.6.1
Update go in dockerfiles to go 1.6.1
2016-04-19 15:45:45 -07:00
Ying Li ebb2eb8bc6 Merge pull request #683 from cyli/root-rotation-tests
Some root rotation tests and CLI warnings
2016-04-19 15:44:03 -07:00
Ying Li 1367311d41 Update client warning to be more clear about why you need to keep your root key past initial root rotation.
Signed-off-by: Ying Li <ying.li@docker.com>
2016-04-19 15:14:14 -07:00
Ying Li cc5211cdf6 Fix server validation and client update tests to also test threshold when testing
root rotation with the previous root role.

Signed-off-by: Ying Li <ying.li@docker.com>
2016-04-19 15:14:14 -07:00
Ying Li 839a1d076f Add support for thresholds, which means signed.VerifyRoot needs to be have just like
signed.VerifySignatures. So remove signed.VerifyRoot and just use signed.VerifySignatures
instead.  Also, to fix some tests, add an additional check for version when validating
metadata since versions can't be negative.

Signed-off-by: Ying Li <ying.li@docker.com>
2016-04-19 15:14:14 -07:00
Ying Li 0f5a40e591 Use askConfirm rather than processing 'yes' or 'no' input manually everywhere.
Signed-off-by: Ying Li <ying.li@docker.com>
2016-04-19 15:14:14 -07:00
Ying Li 2c26ccb118 Warn users before they rotate the root key with the CLI
Signed-off-by: Ying Li <ying.li@docker.com>
2016-04-19 15:14:14 -07:00
Ying Li 65851590f6 Add a client update test for root rotations that test that the previous root ROLE is satisfied,
as opposed to just requiring we also sign with whatever key the previous root was signed with.

Signed-off-by: Ying Li <ying.li@docker.com>
2016-04-19 15:14:14 -07:00
Ying Li b941c10523 Update server validation test to assert that old root roles do not affect
the server validation requirements at all, just the previous root role
(as opposed to a single old key being required)

Signed-off-by: Ying Li <ying.li@docker.com>
2016-04-19 15:14:14 -07:00
Ying Li 3aeae90290 storage/memory's UpdateMany should fail if versions are not higher
Signed-off-by: Ying Li <ying.li@docker.com>
2016-04-19 15:14:14 -07:00
Ying Li 84b1210bf7 Update go in dockerfiles to go 1.6.1 because we want the HTTPS security update
Signed-off-by: Ying Li <ying.li@docker.com>
2016-04-19 15:13:39 -07:00
David Lawrence b188f1ba7f Merge pull request #684 from docker/add-by-hash
Add by hash command
2016-04-19 14:59:01 -07:00
Riyaz Faizullabhoy 8d357d44cd Error unit tests for bad cli input, include trustpinning merge
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
2016-04-19 13:59:58 -07:00
David Lawrence 4c52b3801f Merge pull request #685 from docker/docs-update
Update doc diagrams
2016-04-19 13:49:03 -07:00
Riyaz Faizullabhoy 378116d37c Add empty hashes check for AddTarget
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
2016-04-19 13:39:26 -07:00
Riyaz Faizullabhoy 26c1ce1865 Include addhash command in config and insufficient arg tests
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
2016-04-19 13:39:26 -07:00
Riyaz Faizullabhoy 1abf013e69 Add positive integration test
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
2016-04-19 13:39:26 -07:00