iamqizhao
7ce43067bd
more comments
2016-07-14 17:17:46 -07:00
iamqizhao
e558cf17ff
fix comments
2016-07-14 17:13:20 -07:00
iamqizhao
7b7cb1ae8c
fix bugs and flaky tests
2016-07-14 17:12:11 -07:00
iamqizhao
e5011a450e
Merge branch 'master' of https://github.com/grpc/grpc-go
2016-07-14 15:10:08 -07:00
Qi Zhao
02fca896ff
Merge pull request #756 from heyitsanthony/fix-cred-clobber
...
credentials: don't overwrite ServerName in given config
2016-07-14 15:09:51 -07:00
Anthony Romano
9a97937ed3
credentials: don't overwrite ServerName in given config
...
The first endpoint will set the ServerName which will then be used by
the second endpoint, causing the transport to reject the second endpoint
since the server cert won't match the server name.
2016-07-14 11:17:40 -07:00
Qi Zhao
7428593149
Merge pull request #759 from menghanl/streams_in_serviceinfo_comments
...
Fix comments
2016-07-14 10:55:28 -07:00
Qi Zhao
108308b1d3
Merge pull request #762 from LK4D4/prevent_double_close
...
server: close only non-closed listeners
2016-07-14 10:55:03 -07:00
iamqizhao
311bcfb8e8
fix some comments
2016-07-14 10:49:31 -07:00
iamqizhao
99c9776beb
add more comments
2016-07-13 18:18:35 -07:00
iamqizhao
48068bbe62
remove debugging info
2016-07-13 18:13:28 -07:00
iamqizhao
6205cb25ab
fix some bugs
2016-07-13 18:05:02 -07:00
Alexander Morozov
47de9c3564
server: close only non-closed listeners
...
The listener can be closed twice: in Close and in Serve. It might lead to
pretty bad things, for example, https://golang.org/src/net/unixsock_posix.go#L340
can delete a file which created by another listener.
Signed-off-by: Alexander Morozov <lk4d4math@gmail.com>
2016-07-12 21:16:45 -07:00
iamqizhao
f53faa647d
minor fix
2016-07-12 19:26:12 -07:00
iamqizhao
2e7aa9a2b1
Error out the send call for a client streaming rpc if the server has returned an error.
2016-07-12 19:24:33 -07:00
Menghan Li
42a2879989
Modify comments
2016-07-11 16:25:52 -07:00
Menghan Li
13edeeffde
Merge pull request #749 from menghanl/streams_in_serviceinfo
...
Split methods and streams in service info
2016-07-11 16:17:12 -07:00
Menghan Li
bc8885608f
Merge unary RPC info and streaming RPC info
2016-07-11 13:09:50 -07:00
Menghan Li
0ea9f970c0
Add StreamInfo for streaming types
2016-07-11 12:09:05 -07:00
Menghan Li
a518fa911d
Split methods and streams in service info
2016-07-11 12:09:05 -07:00
Menghan Li
565b602168
Merge pull request #755 from menghanl/errorf_pointer
...
Make grpc.Errorf return struct pointer
2016-07-11 10:11:51 -07:00
Menghan Li
1b5902d709
Fix review comments
2016-07-08 14:15:16 -07:00
Menghan Li
ffdfb592e8
Fix type assertion error after rebase
2016-07-08 10:35:38 -07:00
Daniel Ruehle
562a45da66
add test to verify that errors defined with same code and description are not considered equal via the error interface
2016-07-08 10:28:36 -07:00
Daniel Ruehle
d2125eeb91
fix error comparison
2016-07-08 10:28:36 -07:00
Daniel Ruehle
55fbdb44ea
compare error strings, not interfaces
2016-07-08 10:28:36 -07:00
Daniel Ruehle
3802318f46
Make Errorf return pointer to rpcError
2016-07-08 10:28:36 -07:00
Menghan Li
461dac9997
Merge pull request #738 from iamqizhao/master
...
[Pre-1.0 Semantics Change] Support Fail-fast and make it the default setup
2016-07-08 10:28:17 -07:00
iamqizhao
9a76919800
Merge branch 'master' of https://github.com/grpc/grpc-go
2016-07-06 17:18:01 -07:00
Menghan Li
4f14d195bf
Merge pull request #753 from iamqizhao/fix
...
Add the missing address metadata
2016-07-06 17:17:39 -07:00
iamqizhao
f492622da4
rebase
2016-07-06 14:16:27 -07:00
Qi Zhao
daeb9cc0f2
Merge pull request #752 from tamird/dupe-balancer
...
remove duplicate balancer field
2016-07-06 14:09:59 -07:00
iamqizhao
5688542ad1
Add the missing address metadata
2016-07-06 11:40:57 -07:00
Tamir Duberstein
ebd9633b55
remove duplicate balancer field
2016-07-05 14:52:25 -04:00
iamqizhao
605ce23104
Merge branch 'master' of https://github.com/grpc/grpc-go
2016-06-30 15:11:56 -07:00
Qi Zhao
a0ff1e78a9
Merge pull request #743 from menghanl/go_vet
...
Fix go vet
2016-06-30 15:10:19 -07:00
iamqizhao
c477cb3b14
fix the flaky test
2016-06-30 14:26:31 -07:00
iamqizhao
be59d023f2
refactor error handling a bit
2016-06-29 15:21:44 -07:00
Menghan Li
78e558bbc1
fix Info passes lock by value
2016-06-29 14:08:23 -07:00
Menghan Li
a6bacfe42c
Fix go vet
2016-06-29 13:36:10 -07:00
Qi Zhao
f38b9a9906
Merge pull request #741 from menghanl/reflection_import
...
Add comments to package reflection
2016-06-29 10:48:42 -07:00
Menghan Li
e297a2401a
Add import comments to package reflection
2016-06-28 17:46:18 -07:00
iamqizhao
213a20c4fe
bug fix, typo fix and slight error refactoring
2016-06-28 16:08:19 -07:00
Qi Zhao
b94a578d43
Merge pull request #726 from menghanl/reflection
...
Server reflection service
2016-06-28 15:26:25 -07:00
Menghan Li
5c7e717663
Merge pull request #740 from idcmp/patch-1
...
Fix typo.
2016-06-28 11:12:29 -07:00
Idcmp
74a71a17ac
Fix typo.
2016-06-27 20:52:25 -07:00
iamqizhao
01ef81a4d9
minor fix including removal of debugging logs, error code fix, etc.
2016-06-27 15:30:20 -07:00
Menghan Li
078c90026f
Minor fixes
2016-06-27 14:51:09 -07:00
iamqizhao
3e71fb360d
Support fail-fast mode and make it the default
2016-06-27 14:36:59 -07:00
Menghan Li
26d2db5487
Add server.GetServiceInfo().
...
To replace server.ServiceMetadata() and server.AllServiceNames().
2016-06-27 12:01:05 -07:00