Commit Graph

77 Commits

Author SHA1 Message Date
eshitachandwani 0a12fb0d84
Revert "credentials: allow audience to be configured (#8421) (#8442)" (#8450)
This reverts commit 7208cdc423.
2025-07-16 15:19:22 +05:30
Chris Staite 7208cdc423
credentials: allow audience to be configured (#8421) (#8442)
There are competing specifications around whether a method should be included in a JWT audience or not.  For example #4713 specifically excluded the method referencing https://google.aip.dev/auth/4111 whereas GCE IAP requires the full URI https://cloud.google.com/iap/docs/authentication-howto.

In order to facilitate both methods, we introduce a new environment variable, namely GRPC_AUDIENCE_IS_FULL_PATH, to allow the method stripping to be disabled.  This defaults to the existing behaviour of stripping the method, but can be set to avoid this.
2025-07-14 13:52:09 -04:00
janardhanvissa d3d2702d29
cleanup: replace dial with newclient (#8196) 2025-05-12 10:57:47 +05:30
eshitachandwani e8a70c6c71
vet: add check to ensure terminating newline (#7645) 2024-10-07 10:34:22 -07:00
eshitachandwani 859602c14c
vet : add check for tabs in text files (#7678) 2024-10-04 17:01:28 +05:30
eshitachandwani 6c48e4760e
replace tab with spaces in text files (#7650) 2024-09-20 11:47:39 +05:30
Nathan Baulch 3b626a7b52
*: fix more typos (#7619) 2024-09-16 10:58:27 -07:00
Purnesh Dixit b6fde8cdd1
vet: add check for trailing spaces (#7576)
* vet: trailing spaces check
2024-09-12 11:40:38 +05:30
Mahé aae9e64cf3
docs: fix and improve anti-patterns.md (#7418) 2024-07-23 13:13:42 -07:00
Purnesh Dixit 5ac73aca1c
documentation: Update proxy docs to point to `WithContextDialer` (#7361) 2024-07-02 12:57:23 -07:00
Bas Kok 5f5d4d2c0b
doc: fix link to error_details example (#7345) 2024-06-25 10:33:32 -07:00
Purnesh Dixit 6d236200ea
documentation: on server, use FromIncomingContext for retrieving context and `SetHeader`, `SetTrailer` to send metadata to client (#7238) 2024-06-04 09:53:02 -07:00
Roger Ng 2174ea60df
documentation: fix typo in anti-patterns.md (#7237) 2024-05-20 10:54:27 -07:00
Elisha Silas 09e6fddbcd
Update docs and examples and tests to use NewClient instead of Dial (#7068)
Co-authored-by: Arvind Bright <arvind.bright100@gmail.com>
Co-authored-by: Doug Fawley <dfawley@google.com>
2024-04-19 10:55:23 -07:00
Doug Fawley a0100790d9
*: remove references to old versions of go (#6545) 2023-08-11 14:14:47 -07:00
ulas 01f8b866af
Add documentation on some anti-patterns (#6034)
Co-authored-by: Doug Fawley <dfawley@google.com>
2023-04-07 10:55:17 -07:00
Theodore Salvo c90744f16a
oauth: mark `NewOauthAccess` as deprecated and update examples to use `TokenSource` (#5882)
* Mark NewOauthAccess as deprecated & change examples

* Fix composite literal uses unkeyed fields for v1.19
2022-12-27 21:06:47 -06:00
Theodore Salvo 4f16fbe410
examples: update server reflection tutorial (#5824)
Fixes https://github.com/grpc/grpc-go/issues/4593
2022-12-19 16:34:28 -08:00
richzw a2054471ce
examples: add new example to show updating metadata in interceptors (#5788) 2022-12-06 08:57:50 -08:00
Doug Fawley 2ebd59436d
Documentation/proxy: update due to Go 1.16 behavior change (#5630) 2022-09-07 07:58:06 -07:00
Aaron Jheng 86ac0fbc40
Documentation: Fix typo (#4445) 2021-05-19 10:57:27 -07:00
Pierre Fenoll 8f126961c4
Fix typo in encoding.md (#4020) 2020-11-17 15:54:06 -08:00
Menghan Li fe98b4c668
doc: update keepalive.md to add why (#3993) 2020-10-29 10:15:45 -07:00
Aaron Jheng 4e6166f62b
Documentation: fix outgoing metadata example code (#3979) 2020-10-27 10:54:58 -07:00
Sean R. Abraham 4a2248a42b
Remove grpc_cli build instructions (#3868)
The instructions didn't work, as the build process has changed a bit. It's probably best to just link to the official build instructions to avoid future skew.
2020-09-10 10:18:02 -07:00
Doug Fawley 44d73dff99
cmd/protoc-gen-go-grpc: rework service registration (#3828) 2020-08-25 09:28:01 -07:00
Menghan Li d6c4e49aab
internal: delete mock from examples (#3766) 2020-07-29 13:03:27 -07:00
Evan Limanto abfbf74f21
doc: fix references to status methods (#3702) 2020-07-09 13:39:24 -07:00
Ben Wells f5cae43845
Fix wording in keep alive documentation (#3625) 2020-05-18 14:18:06 -07:00
Menghan Li 8c50fc2565
revert buffer reuse (#3338)
* Revert "stream: fix returnBuffers race during retry (#3293)"

This reverts commit ede71d589c.

* Revert "codec/proto: reuse of marshal byte buffers (#3167)"

This reverts commit 642675125e.
2020-01-27 13:30:41 -08:00
Adhityaa Chandrasekar cf9eb4f51c benchmark: add support for payload size curves (#3248) 2020-01-06 14:45:41 -08:00
Adhityaa Chandrasekar 642675125e codec/proto: reuse of marshal byte buffers (#3167)
Performance benchmarks can be found below. Obviously, a 8 KiB
request/response is tailored to showcase this improvement as this is
where codec buffer reuse shines, but I've run other benchmarks too (like
1-byte requests and responses) and there's no discernable impact on
performance.

We do not allow reuse of buffers when stat handlers or binlogs are
turned on. This is because those two may need access to the data and
payload even after the data has been written to the wire. In such cases,
we never return the data back to the pool.

A buffer reuse threshold of 1 KiB was determined after several
experiments. There's diminished returns when buffer reuse is enabled for
smaller messages (actually, a negative impact).

unary-networkMode_none-bufConn_false-keepalive_false-benchTime_40s-trace_false-latency_0s-kbps_0-MTU_0-maxConcurrentCalls_6-reqSize_8192B-respSize_8192B-compressor_off-channelz_false-preloader_false
               Title       Before        After Percentage
            TotalOps       839638       906223     7.93%
             SendOps            0            0      NaN%
             RecvOps            0            0      NaN%
            Bytes/op    103788.29     80592.47   -22.35%
           Allocs/op       183.33       189.30     3.27%
             ReqT/op 1375662899.20 1484755763.20     7.93%
            RespT/op 1375662899.20 1484755763.20     7.93%
            50th-Lat    238.746µs    225.019µs    -5.75%
            90th-Lat    514.253µs    456.439µs   -11.24%
            99th-Lat    711.083µs    702.466µs    -1.21%
             Avg-Lat     285.45µs    264.456µs    -7.35%
2019-12-20 09:41:23 -08:00
Ahmet Soormally 7c97d1d53c docs: fix reflection doc (#3138)
added `git submodule update --init` to readme instructions to pull in missing dependencies.
2019-11-04 08:32:18 -08:00
Doug Fawley e2d4ecf5a6
doc: clarify client concurrency (#3001) 2019-09-05 13:20:03 -07:00
Kartik Yadav bc316a57d4 doc: fixing link in keepalive docs (#2755)
The link for enforcement policy in the keepalive docs is wrong.

fixes #2754
2019-04-09 11:34:45 -07:00
Kartik Yadav 981ad1f9d2 doc: fixing broken link in rpc-error doc (#2753)
The link for example in the documentation for RPC errors redirects to the wrong URL.

Fixes #2752
2019-04-09 11:33:11 -07:00
Nguyen Quang Huy 871b88ce2e doc: fix typos (#2655) 2019-02-25 10:31:22 -08:00
Menghan Li 23ef1279c1
doc: fix broken link in auth doc (#2613) 2019-02-07 13:26:12 -08:00
Menghan Li 6086f8d68f
examples: reflection (#2594) 2019-01-25 15:35:01 -08:00
Menghan Li 9d925ce589
examples: metadata (#2500) 2018-12-13 14:45:14 -08:00
Menghan Li 55ef601361
internal: cleanup remaining x/net/context (#2470) 2018-11-28 12:46:35 -08:00
Menghan Li 481c28e8d4
documentation: add proxy doc (#2357) 2018-10-18 13:09:24 -07:00
Menghan Li ad6d187e37
keepalive: godoc improvement and behavior explanation (#2342) 2018-10-02 13:03:51 -07:00
Menghan Li b39aa9e037
Revert stickiness (#2175)
Stickiness will be reimplemented as part of a balancer/resolver redesigning/extending.
2018-06-26 10:02:54 -07:00
dfawley 49c8c81756
Documentation: create doc describing grpc-go's log levels and their usages (#2033) 2018-06-11 09:31:41 -07:00
Eno Compton 0ebfac42d6 Documentation: Add initial documentation on concurrency (#2034) 2018-05-10 13:08:19 -07:00
Menghan Li e8a6e2844b
stickiness: add stickiness support (#1969) 2018-04-24 10:37:52 -07:00
Eno Compton d27df52a27 documentation: add OAuth2 doc and example (#2003) 2018-04-18 11:25:19 -07:00
Karsten Weiss 7de9139327 Fix typos (#1994) 2018-04-16 10:03:02 -07:00
Eno Compton 32d9ffabba Documentation: Fix broken link in rpc-errors.md (#1935) 2018-03-21 10:14:55 -07:00