grpc
/
grpc-java
mirror of https://github.com/grpc/grpc-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #881 from nmittler/fix_benchmarks 

Fixing the benchmarks
This commit is contained in:
Nathan Mittler 2015-08-26 14:31:09 -07:00
parent 4221f5a81c d5977c4552
commit 40c66a17a9
3 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
benchmarks/build.gradle
View File

@ -24,7 +24,7 @@ jmh {
warmupIterations = 10 warmupIterations = 10
iterations = 10 iterations = 10
fork = 1 fork = 1
jvmArgs = "-server -Xms768m -Xmx768m -dsa -da -XX:+AggressiveOpts -XX:+UseBiasedLocking -XX:+UseFastAccessorMethods -XX:+OptimizeStringConcat" jvmArgs = "-server -Xms2g -Xmx2g -dsa -da -XX:+AggressiveOpts -XX:+UseBiasedLocking -XX:+UseFastAccessorMethods -XX:+OptimizeStringConcat"
} }
dependencies { dependencies {

4
benchmarks/src/jmh/java/io/grpc/benchmarks/netty/AbstractBenchmark.java
View File

@ -419,8 +419,6 @@ public abstract class AbstractBenchmark {
counter.addAndGet(counterDelta); counter.addAndGet(counterDelta);
requestObserverRef.get().onValue(request.slice()); requestObserverRef.get().onValue(request.slice());
streamingCall.request(1); streamingCall.request(1);
} else {
requestObserverRef.get().onCompleted();
} }
} }
@ -463,8 +461,6 @@ public abstract class AbstractBenchmark {
if (!done.get()) { if (!done.get()) {
counter.addAndGet(counterDelta); counter.addAndGet(counterDelta);
streamingCall.request(1); streamingCall.request(1);
} else {
requestObserverRef.get().onCompleted();
} }
} }

6
stub/src/main/java/io/grpc/stub/StreamObserver.java
View File

@ -55,7 +55,7 @@ public interface StreamObserver<V> {
* *
* @param value the value passed to the stream * @param value the value passed to the stream
*/ */
public void onValue(V value); void onValue(V value);
/** /**
* Receives a terminating error from the stream. * Receives a terminating error from the stream.
@ -66,7 +66,7 @@ public interface StreamObserver<V> {
* *
* @param t the error occurred on the stream * @param t the error occurred on the stream
*/ */
public void onError(Throwable t); void onError(Throwable t);
/** /**
* Receives a notification of successful stream completion. * Receives a notification of successful stream completion.
@ -75,5 +75,5 @@ public interface StreamObserver<V> {
* exception is thrown by an implementation of {@code onCompleted} no further calls to any method * exception is thrown by an implementation of {@code onCompleted} no further calls to any method
* are allowed. * are allowed.
*/ */
public void onCompleted(); void onCompleted();
} }